* [PATCH] Staging: xgifb:XGI_main_26: Fixed coding style issues
@ 2017-02-18 9:29 Georgios Emmanouil
2017-02-22 17:33 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Georgios Emmanouil @ 2017-02-18 9:29 UTC (permalink / raw)
To: arnaud.patard, gregkh, waltfeasel, karniksayli1995,
clifton.a.barnes, shiva
Cc: devel, linux-kernel
Fixed coding style issues. Patch applies to linux-next-20170217 tree.
Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
index 6930f7e..1be0343 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -1480,9 +1480,9 @@ static void XGIfb_detect_VB(struct xgifb_video_info *xgifb_info)
cr32 = xgifb_reg_get(XGICR, IND_XGI_SCRATCH_REG_CR32);
- if ((cr32 & SIS_CRT1) && !XGIfb_crt1off)
+ if ((cr32 & SIS_CRT1) && !XGIfb_crt1off) {
XGIfb_crt1off = 0;
- else {
+ } else {
if (cr32 & 0x5F)
XGIfb_crt1off = 1;
else
@@ -1500,18 +1500,19 @@ static void XGIfb_detect_VB(struct xgifb_video_info *xgifb_info)
xgifb_info->display2 = XGIFB_DISP_NONE;
}
- if (XGIfb_tvplug != -1)
+ if (XGIfb_tvplug != -1) {
/* Override with option */
xgifb_info->TV_plug = XGIfb_tvplug;
- else if (cr32 & SIS_VB_HIVISION) {
+ } else if (cr32 & SIS_VB_HIVISION) {
xgifb_info->TV_type = TVMODE_HIVISION;
xgifb_info->TV_plug = TVPLUG_SVIDEO;
- } else if (cr32 & SIS_VB_SVIDEO)
+ } else if (cr32 & SIS_VB_SVIDEO) {
xgifb_info->TV_plug = TVPLUG_SVIDEO;
- else if (cr32 & SIS_VB_COMPOSITE)
+ } else if (cr32 & SIS_VB_COMPOSITE) {
xgifb_info->TV_plug = TVPLUG_COMPOSITE;
- else if (cr32 & SIS_VB_SCART)
+ } else if (cr32 & SIS_VB_SCART) {
xgifb_info->TV_plug = TVPLUG_SCART;
+ }
if (xgifb_info->TV_type == 0) {
temp = xgifb_reg_get(XGICR, 0x38);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: xgifb:XGI_main_26: Fixed coding style issues
2017-02-18 9:29 [PATCH] Staging: xgifb:XGI_main_26: Fixed coding style issues Georgios Emmanouil
@ 2017-02-22 17:33 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-02-22 17:33 UTC (permalink / raw)
To: Georgios Emmanouil
Cc: arnaud.patard, waltfeasel, karniksayli1995, clifton.a.barnes,
shiva, devel, linux-kernel
On Sat, Feb 18, 2017 at 11:29:46AM +0200, Georgios Emmanouil wrote:
> Fixed coding style issues. Patch applies to linux-next-20170217 tree.
>
> Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
_what_ coding style issues did you fix? Please be specific and do not
try to fix more than one "type" of issue in a single patch, make it a
patch series.
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-22 17:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-18 9:29 [PATCH] Staging: xgifb:XGI_main_26: Fixed coding style issues Georgios Emmanouil
2017-02-22 17:33 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).