* [PATCH v2] staging: xgifb: function definition argument should also have an identifier name'
@ 2017-02-18 13:46 Arushi Singhal
2017-02-22 17:34 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Arushi Singhal @ 2017-02-18 13:46 UTC (permalink / raw)
To: arnaud.patard; +Cc: Greg Kroah-Hartman, devel, linux-kernel, outreachy-kernel
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/staging/xgifb/vb_init.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h
index 500cabe41a3c..e835054b87bf 100644
--- a/drivers/staging/xgifb/vb_init.h
+++ b/drivers/staging/xgifb/vb_init.h
@@ -1,6 +1,5 @@
#ifndef _VBINIT_
#define _VBINIT_
unsigned char XGIInitNew(struct pci_dev *pdev);
-void XGIRegInit(struct vb_device_info *, unsigned long);
+void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr);
#endif
-
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: xgifb: function definition argument should also have an identifier name'
2017-02-18 13:46 [PATCH v2] staging: xgifb: function definition argument should also have an identifier name' Arushi Singhal
@ 2017-02-22 17:34 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2017-02-22 17:34 UTC (permalink / raw)
To: Arushi Singhal; +Cc: arnaud.patard, devel, linux-kernel, outreachy-kernel
On Sat, Feb 18, 2017 at 07:16:11PM +0530, Arushi Singhal wrote:
> function definition argument 'struct vb_device_info *' and 'unsigned
> long' should also have an identifier name.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/xgifb/vb_init.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
What changed from v1? Please always list it. Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] staging: xgifb: function definition argument should also have an identifier name'
@ 2017-02-21 19:35 Arushi Singhal
0 siblings, 0 replies; 3+ messages in thread
From: Arushi Singhal @ 2017-02-21 19:35 UTC (permalink / raw)
To: arnaud.patard; +Cc: Greg Kroah-Hartman, devel, linux-kernel, outreachy-kernel
function definition argument like 'struct vb_device_info *','unsigned
long' etc. should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
Changes in v2:
- By mistake one irrelevant line was added which is removed in this
patch.
---
drivers/staging/xgifb/vb_setmode.h | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.h b/drivers/staging/xgifb/vb_setmode.h
index 6f082a7a5a4a..c6317ab00474 100644
--- a/drivers/staging/xgifb/vb_setmode.h
+++ b/drivers/staging/xgifb/vb_setmode.h
@@ -1,14 +1,14 @@
#ifndef _VBSETMODE_
#define _VBSETMODE_
-void InitTo330Pointer(unsigned char, struct vb_device_info *);
-void XGI_UnLockCRT2(struct vb_device_info *);
-void XGI_LockCRT2(struct vb_device_info *);
-void XGI_DisplayOff(struct xgifb_video_info *,
- struct xgi_hw_device_info *,
- struct vb_device_info *);
-void XGI_GetVBType(struct vb_device_info *);
-void XGI_SenseCRT1(struct vb_device_info *);
+void InitTo330Pointer(unsigned char ChipType, struct vb_device_info *pVBInfo);
+void XGI_UnLockCRT2(struct vb_device_info *pVBInfo);
+void XGI_LockCRT2(struct vb_device_info *pVBInfo);
+void XGI_DisplayOff(struct xgifb_video_info *xgifb_info,
+ struct xgi_hw_device_info *pXGIHWDE,
+ struct vb_device_info *pVBInfo);
+void XGI_GetVBType(struct vb_device_info *pVBInfo);
+void XGI_SenseCRT1(struct vb_device_info *pVBInfo);
unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
struct xgi_hw_device_info *HwDeviceExtension,
unsigned short ModeNo);
@@ -18,6 +18,6 @@ unsigned char XGI_SearchModeID(unsigned short ModeNo,
unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
unsigned short ModeNo,
unsigned short ModeIdIndex,
- struct vb_device_info *);
+ struct vb_device_info *pVBInfo);
#endif
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-22 17:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-18 13:46 [PATCH v2] staging: xgifb: function definition argument should also have an identifier name' Arushi Singhal
2017-02-22 17:34 ` Greg Kroah-Hartman
2017-02-21 19:35 Arushi Singhal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).