linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors
@ 2017-02-23  1:13 Dmitry V. Levin
  2017-02-23 11:30 ` [PATCH v2] " Dmitry V. Levin
  2017-02-23 11:57 ` [PATCH] " Sergei Shtylyov
  0 siblings, 2 replies; 4+ messages in thread
From: Dmitry V. Levin @ 2017-02-23  1:13 UTC (permalink / raw)
  To: David S. Miller, David Lebrun; +Cc: netdev, linux-kernel

Include <linux/in6.h> in uapi/linux/seg6.h to fix the following
linux/seg6.h userspace compilation error:

/usr/include/linux/seg6.h:31:18: error: array type has incomplete element type 'struct in6_addr'
  struct in6_addr segments[0];

Include <linux/seg6.h> in uapi/linux/seg6_iptunnel.h to fix
the following linux/seg6_iptunnel.h userspace compilation error:

/usr/include/linux/seg6_iptunnel.h:26:21: error: array type has incomplete element type 'struct ipv6_sr_hdr'
  struct ipv6_sr_hdr srh[0];

Fixes: a50a05f4("ipv6: sr: add missing Kbuild export for header files")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
 include/uapi/linux/seg6.h          | 1 +
 include/uapi/linux/seg6_iptunnel.h | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/include/uapi/linux/seg6.h b/include/uapi/linux/seg6.h
index 61df8d3..7278511 100644
--- a/include/uapi/linux/seg6.h
+++ b/include/uapi/linux/seg6.h
@@ -15,6 +15,7 @@
 #define _UAPI_LINUX_SEG6_H
 
 #include <linux/types.h>
+#include <linux/in6.h>		/* For struct in6_addr. */
 
 /*
  * SRH
diff --git a/include/uapi/linux/seg6_iptunnel.h b/include/uapi/linux/seg6_iptunnel.h
index 7a7183d..b6e5a0a 100644
--- a/include/uapi/linux/seg6_iptunnel.h
+++ b/include/uapi/linux/seg6_iptunnel.h
@@ -14,6 +14,8 @@
 #ifndef _UAPI_LINUX_SEG6_IPTUNNEL_H
 #define _UAPI_LINUX_SEG6_IPTUNNEL_H
 
+#include <linux/seg6.h>		/* For struct ipv6_sr_hdr. */
+
 enum {
 	SEG6_IPTUNNEL_UNSPEC,
 	SEG6_IPTUNNEL_SRH,
-- 
ldv

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors
  2017-02-23  1:13 [PATCH] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors Dmitry V. Levin
@ 2017-02-23 11:30 ` Dmitry V. Levin
  2017-02-23 15:55   ` David Miller
  2017-02-23 11:57 ` [PATCH] " Sergei Shtylyov
  1 sibling, 1 reply; 4+ messages in thread
From: Dmitry V. Levin @ 2017-02-23 11:30 UTC (permalink / raw)
  To: David S. Miller, David Lebrun; +Cc: netdev, linux-kernel

Include <linux/in6.h> in uapi/linux/seg6.h to fix the following
linux/seg6.h userspace compilation error:

/usr/include/linux/seg6.h:31:18: error: array type has incomplete element type 'struct in6_addr'
  struct in6_addr segments[0];

Include <linux/seg6.h> in uapi/linux/seg6_iptunnel.h to fix
the following linux/seg6_iptunnel.h userspace compilation error:

/usr/include/linux/seg6_iptunnel.h:26:21: error: array type has incomplete element type 'struct ipv6_sr_hdr'
  struct ipv6_sr_hdr srh[0];

Fixes: a50a05f497a2 ("ipv6: sr: add missing Kbuild export for header files")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
v2: fixed "Fixes:" line

 include/uapi/linux/seg6.h          | 1 +
 include/uapi/linux/seg6_iptunnel.h | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/include/uapi/linux/seg6.h b/include/uapi/linux/seg6.h
index 61df8d3..7278511 100644
--- a/include/uapi/linux/seg6.h
+++ b/include/uapi/linux/seg6.h
@@ -15,6 +15,7 @@
 #define _UAPI_LINUX_SEG6_H
 
 #include <linux/types.h>
+#include <linux/in6.h>		/* For struct in6_addr. */
 
 /*
  * SRH
diff --git a/include/uapi/linux/seg6_iptunnel.h b/include/uapi/linux/seg6_iptunnel.h
index 7a7183d..b6e5a0a 100644
--- a/include/uapi/linux/seg6_iptunnel.h
+++ b/include/uapi/linux/seg6_iptunnel.h
@@ -14,6 +14,8 @@
 #ifndef _UAPI_LINUX_SEG6_IPTUNNEL_H
 #define _UAPI_LINUX_SEG6_IPTUNNEL_H
 
+#include <linux/seg6.h>		/* For struct ipv6_sr_hdr. */
+
 enum {
 	SEG6_IPTUNNEL_UNSPEC,
 	SEG6_IPTUNNEL_SRH,
-- 
ldv

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors
  2017-02-23  1:13 [PATCH] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors Dmitry V. Levin
  2017-02-23 11:30 ` [PATCH v2] " Dmitry V. Levin
@ 2017-02-23 11:57 ` Sergei Shtylyov
  1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2017-02-23 11:57 UTC (permalink / raw)
  To: Dmitry V. Levin, David S. Miller, David Lebrun; +Cc: netdev, linux-kernel

On 2/23/2017 4:13 AM, Dmitry V. Levin wrote:

> Include <linux/in6.h> in uapi/linux/seg6.h to fix the following
> linux/seg6.h userspace compilation error:
>
> /usr/include/linux/seg6.h:31:18: error: array type has incomplete element type 'struct in6_addr'
>   struct in6_addr segments[0];
>
> Include <linux/seg6.h> in uapi/linux/seg6_iptunnel.h to fix
> the following linux/seg6_iptunnel.h userspace compilation error:
>
> /usr/include/linux/seg6_iptunnel.h:26:21: error: array type has incomplete element type 'struct ipv6_sr_hdr'
>   struct ipv6_sr_hdr srh[0];
>
> Fixes: a50a05f4("ipv6: sr: add missing Kbuild export for header files")

    12 digits and space before ( as well.

> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
[...]

MBR, Sergei

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors
  2017-02-23 11:30 ` [PATCH v2] " Dmitry V. Levin
@ 2017-02-23 15:55   ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-02-23 15:55 UTC (permalink / raw)
  To: ldv; +Cc: david.lebrun, netdev, linux-kernel

From: "Dmitry V. Levin" <ldv@altlinux.org>
Date: Thu, 23 Feb 2017 14:30:34 +0300

> Include <linux/in6.h> in uapi/linux/seg6.h to fix the following
> linux/seg6.h userspace compilation error:
> 
> /usr/include/linux/seg6.h:31:18: error: array type has incomplete element type 'struct in6_addr'
>   struct in6_addr segments[0];
> 
> Include <linux/seg6.h> in uapi/linux/seg6_iptunnel.h to fix
> the following linux/seg6_iptunnel.h userspace compilation error:
> 
> /usr/include/linux/seg6_iptunnel.h:26:21: error: array type has incomplete element type 'struct ipv6_sr_hdr'
>   struct ipv6_sr_hdr srh[0];
> 
> Fixes: a50a05f497a2 ("ipv6: sr: add missing Kbuild export for header files")
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
> v2: fixed "Fixes:" line

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-02-23 15:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-23  1:13 [PATCH] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors Dmitry V. Levin
2017-02-23 11:30 ` [PATCH v2] " Dmitry V. Levin
2017-02-23 15:55   ` David Miller
2017-02-23 11:57 ` [PATCH] " Sergei Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).