* [PATCH] staging: ks7010: codes in the comments are removed
@ 2017-02-24 23:11 Arushi Singhal
2017-02-25 6:32 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Arushi Singhal @ 2017-02-24 23:11 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, outreachy-kernel
Commenting Code Is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments does not explain what the code is
doing so there is no use of commenting them.
So in thos patch codes in the comments are removed.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/staging/ks7010/ks7010_sdio.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 2c263f98bdbb..54aa2e2f516f 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -495,10 +495,6 @@ static void ks7010_rw_function(struct work_struct *work)
/* wiat after WAKEUP */
while (time_after(priv->last_wakeup + ((30 * HZ) / 1000), jiffies)) {
DPRINTK(4, "wait after WAKEUP\n");
-/*
- * queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
- * (priv->last_wakeup + ((30*HZ)/1000) - jiffies));
- */
dev_info(&priv->ks_wlan_hw.sdio_card->func->dev,
"wake: %lu %lu\n",
priv->last_wakeup + (30 * HZ) / 1000,
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: ks7010: codes in the comments are removed
2017-02-24 23:11 [PATCH] staging: ks7010: codes in the comments are removed Arushi Singhal
@ 2017-02-25 6:32 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2017-02-25 6:32 UTC (permalink / raw)
To: Arushi Singhal; +Cc: gregkh, devel, linux-kernel, outreachy-kernel
Remember to use the imperative and to make your subject lines as short as
possible. Here the subject line could be "remove code in comments".
julia
On Sat, 25 Feb 2017, Arushi Singhal wrote:
> Commenting Code Is a Bad Idea.
> Comments are their to explain the code and how the code achieves its
> goal and as codes in the comments does not explain what the code is
> doing so there is no use of commenting them.
> So in thos patch codes in the comments are removed.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index 2c263f98bdbb..54aa2e2f516f 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -495,10 +495,6 @@ static void ks7010_rw_function(struct work_struct *work)
> /* wiat after WAKEUP */
> while (time_after(priv->last_wakeup + ((30 * HZ) / 1000), jiffies)) {
> DPRINTK(4, "wait after WAKEUP\n");
> -/*
> - * queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
> - * (priv->last_wakeup + ((30*HZ)/1000) - jiffies));
> - */
> dev_info(&priv->ks_wlan_hw.sdio_card->func->dev,
> "wake: %lu %lu\n",
> priv->last_wakeup + (30 * HZ) / 1000,
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170224231154.GA32083%40arushi-HP-Pavilion-Notebook.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-25 6:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-24 23:11 [PATCH] staging: ks7010: codes in the comments are removed Arushi Singhal
2017-02-25 6:32 ` [Outreachy kernel] " Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).