linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump
       [not found] <f9a9b434-ea38-3f7f-6207-8c7bc7317bc4@mojatatu.com>
@ 2017-03-05  0:01 ` Alexey Khoroshilov
  2017-03-05  2:21   ` Jamal Hadi Salim
  2017-03-07 22:13   ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Alexey Khoroshilov @ 2017-03-05  0:01 UTC (permalink / raw)
  To: Jamal Hadi Salim
  Cc: Alexey Khoroshilov, David S. Miller, netdev, linux-kernel, ldv-project

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 net/sched/act_skbmod.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/sched/act_skbmod.c b/net/sched/act_skbmod.c
index 3b7074e23024..c736627f8f4a 100644
--- a/net/sched/act_skbmod.c
+++ b/net/sched/act_skbmod.c
@@ -228,7 +228,6 @@ static int tcf_skbmod_dump(struct sk_buff *skb, struct tc_action *a,
 
 	return skb->len;
 nla_put_failure:
-	rcu_read_unlock();
 	nlmsg_trim(skb, b);
 	return -1;
 }
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump
  2017-03-05  0:01 ` [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump Alexey Khoroshilov
@ 2017-03-05  2:21   ` Jamal Hadi Salim
  2017-03-07 22:13   ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Jamal Hadi Salim @ 2017-03-05  2:21 UTC (permalink / raw)
  To: Alexey Khoroshilov; +Cc: David S. Miller, netdev, linux-kernel, ldv-project

On 17-03-04 07:01 PM, Alexey Khoroshilov wrote:
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump
  2017-03-05  0:01 ` [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump Alexey Khoroshilov
  2017-03-05  2:21   ` Jamal Hadi Salim
@ 2017-03-07 22:13   ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-03-07 22:13 UTC (permalink / raw)
  To: khoroshilov; +Cc: jhs, netdev, linux-kernel, ldv-project

From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Sun,  5 Mar 2017 03:01:55 +0300

> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Applied and queued up for -stable, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-03-07 22:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <f9a9b434-ea38-3f7f-6207-8c7bc7317bc4@mojatatu.com>
2017-03-05  0:01 ` [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump Alexey Khoroshilov
2017-03-05  2:21   ` Jamal Hadi Salim
2017-03-07 22:13   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).