* [PATCH v3 0/2] staging: speakup: checkpatch guided cleanups.
@ 2017-03-14 5:16 Arushi Singhal
2017-03-14 5:16 ` [PATCH v3 1/2] staging: speakup: Add blank line after declarations Arushi Singhal
2017-03-14 5:16 ` [PATCH v3 2/2] staging: speakup: fix "Alignment match open parenthesis" Arushi Singhal
0 siblings, 2 replies; 4+ messages in thread
From: Arushi Singhal @ 2017-03-14 5:16 UTC (permalink / raw)
To: w.d.hubbs
Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup,
devel, linux-kernel, Arushi Singhal
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (2):
staging: speakup: Add blank line after declarations
staging: speakup: fix "Alignment match open parenthesis"
drivers/staging/speakup/kobjects.c | 2 +-
drivers/staging/speakup/main.c | 1 +
drivers/staging/speakup/serialio.c | 1 +
drivers/staging/speakup/speakup_dtlk.c | 1 +
4 files changed, 4 insertions(+), 1 deletion(-)
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 1/2] staging: speakup: Add blank line after declarations
2017-03-14 5:16 [PATCH v3 0/2] staging: speakup: checkpatch guided cleanups Arushi Singhal
@ 2017-03-14 5:16 ` Arushi Singhal
2017-03-14 5:16 ` [PATCH v3 2/2] staging: speakup: fix "Alignment match open parenthesis" Arushi Singhal
1 sibling, 0 replies; 4+ messages in thread
From: Arushi Singhal @ 2017-03-14 5:16 UTC (permalink / raw)
To: w.d.hubbs
Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup,
devel, linux-kernel, Arushi Singhal
Patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Add a blank line after enum and struct declarations.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v3
- change the subject and commit message to make it more relevant.
drivers/staging/speakup/main.c | 1 +
drivers/staging/speakup/serialio.c | 1 +
drivers/staging/speakup/speakup_dtlk.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index 6786cfab7460..4b750ec8cd59 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -108,6 +108,7 @@ enum {
CT_Window,
CT_Max
};
+
#define read_all_mode CT_Max
static struct tty_struct *tty;
diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
index aade52ee15a0..d51e382cb835 100644
--- a/drivers/staging/speakup/serialio.c
+++ b/drivers/staging/speakup/serialio.c
@@ -21,6 +21,7 @@ static void start_serial_interrupt(int irq);
static const struct old_serial_port rs_table[] = {
SERIAL_PORT_DFNS
};
+
static const struct old_serial_port *serstate;
static int timeouts;
diff --git a/drivers/staging/speakup/speakup_dtlk.c b/drivers/staging/speakup/speakup_dtlk.c
index eede2d82183a..c0b2208aa8a7 100644
--- a/drivers/staging/speakup/speakup_dtlk.c
+++ b/drivers/staging/speakup/speakup_dtlk.c
@@ -43,6 +43,7 @@ static int port_forced;
static unsigned int synth_portlist[] = {
0x25e, 0x29e, 0x2de, 0x31e, 0x35e, 0x39e, 0
};
+
static u_char synth_status;
static struct var_t vars[] = {
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 2/2] staging: speakup: fix "Alignment match open parenthesis"
2017-03-14 5:16 [PATCH v3 0/2] staging: speakup: checkpatch guided cleanups Arushi Singhal
2017-03-14 5:16 ` [PATCH v3 1/2] staging: speakup: Add blank line after declarations Arushi Singhal
@ 2017-03-14 5:16 ` Arushi Singhal
2017-03-16 2:15 ` Greg KH
1 sibling, 1 reply; 4+ messages in thread
From: Arushi Singhal @ 2017-03-14 5:16 UTC (permalink / raw)
To: w.d.hubbs
Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup,
devel, linux-kernel, Arushi Singhal
Alig arguments with open parenthesis.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v3
- Improve the commit message.
drivers/staging/speakup/kobjects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index 8a586323b728..ca85476e3ff7 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -93,7 +93,7 @@ static void report_char_chartab_status(int reset, int received, int used,
} else if (received) {
len = snprintf(buf, sizeof(buf),
" updated %d of %d %s\n",
- used, received, object_type[do_characters]);
+ used, received, object_type[do_characters]);
if (rejected)
snprintf(buf + (len - 1), sizeof(buf) - (len - 1),
" with %d reject%s\n",
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 2/2] staging: speakup: fix "Alignment match open parenthesis"
2017-03-14 5:16 ` [PATCH v3 2/2] staging: speakup: fix "Alignment match open parenthesis" Arushi Singhal
@ 2017-03-16 2:15 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-03-16 2:15 UTC (permalink / raw)
To: Arushi Singhal
Cc: w.d.hubbs, devel, kirk, speakup, linux-kernel, outreachy-kernel,
samuel.thibault, chris
On Tue, Mar 14, 2017 at 10:46:43AM +0530, Arushi Singhal wrote:
> Alig arguments with open parenthesis.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> changes in v3
> - Improve the commit message.
Did not apply as I think someone else already did this same work.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-16 2:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-14 5:16 [PATCH v3 0/2] staging: speakup: checkpatch guided cleanups Arushi Singhal
2017-03-14 5:16 ` [PATCH v3 1/2] staging: speakup: Add blank line after declarations Arushi Singhal
2017-03-14 5:16 ` [PATCH v3 2/2] staging: speakup: fix "Alignment match open parenthesis" Arushi Singhal
2017-03-16 2:15 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).