* [PATCH] pinctrl: qcom: Don't clear status bit on irq_unmask
@ 2017-03-14 15:23 Bjorn Andersson
2017-03-16 15:32 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Andersson @ 2017-03-14 15:23 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-arm-msm, linux-soc, linux-gpio, linux-kernel, Timur Tabi,
stable, Stephen Boyd
Clearing the status bit on irq_unmask will discard any pending interrupt
that did arrive after the irq_ack, i.e. while the IRQ handler function
was executing.
Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver")
Cc: stable@vger.kernel.org
Cc: Stephen Boyd <sboyd@codeaurora.org>
Reported-by: Timur Tabi <timur@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index f8e9e1c2b2f6..faf038978650 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -594,10 +594,6 @@ static void msm_gpio_irq_unmask(struct irq_data *d)
raw_spin_lock_irqsave(&pctrl->lock, flags);
- val = readl(pctrl->regs + g->intr_status_reg);
- val &= ~BIT(g->intr_status_bit);
- writel(val, pctrl->regs + g->intr_status_reg);
-
val = readl(pctrl->regs + g->intr_cfg_reg);
val |= BIT(g->intr_enable_bit);
writel(val, pctrl->regs + g->intr_cfg_reg);
--
2.12.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: qcom: Don't clear status bit on irq_unmask
2017-03-14 15:23 [PATCH] pinctrl: qcom: Don't clear status bit on irq_unmask Bjorn Andersson
@ 2017-03-16 15:32 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2017-03-16 15:32 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, open list:ARM/QUALCOMM SUPPORT, linux-gpio,
linux-kernel, Timur Tabi, stable, Stephen Boyd
On Tue, Mar 14, 2017 at 4:23 PM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> Clearing the status bit on irq_unmask will discard any pending interrupt
> that did arrive after the irq_ack, i.e. while the IRQ handler function
> was executing.
>
> Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver")
> Cc: stable@vger.kernel.org
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Reported-by: Timur Tabi <timur@codeaurora.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-16 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-14 15:23 [PATCH] pinctrl: qcom: Don't clear status bit on irq_unmask Bjorn Andersson
2017-03-16 15:32 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).