* [PATCH v2] usb: phy: isp1301: Add OF device ID table
@ 2017-03-15 3:46 Javier Martinez Canillas
2017-03-28 13:45 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Javier Martinez Canillas @ 2017-03-15 3:46 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Greg Kroah-Hartman, linux-usb, Felipe Balbi
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Changes in v2:
- Don't use of_match_ptr() to avoid build warning when CONFIG_OF is disabled.
drivers/usb/phy/phy-isp1301.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/phy/phy-isp1301.c b/drivers/usb/phy/phy-isp1301.c
index db68156568e6..f333024660b4 100644
--- a/drivers/usb/phy/phy-isp1301.c
+++ b/drivers/usb/phy/phy-isp1301.c
@@ -33,6 +33,12 @@ static const struct i2c_device_id isp1301_id[] = {
};
MODULE_DEVICE_TABLE(i2c, isp1301_id);
+static const struct of_device_id isp1301_of_match[] = {
+ {.compatible = "nxp,isp1301" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, isp1301_of_match);
+
static struct i2c_client *isp1301_i2c_client;
static int __isp1301_write(struct isp1301 *isp, u8 reg, u8 value, u8 clear)
@@ -130,6 +136,7 @@ static int isp1301_remove(struct i2c_client *client)
static struct i2c_driver isp1301_driver = {
.driver = {
.name = DRV_NAME,
+ .of_match_table = isp1301_of_match,
},
.probe = isp1301_probe,
.remove = isp1301_remove,
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] usb: phy: isp1301: Add OF device ID table
2017-03-15 3:46 [PATCH v2] usb: phy: isp1301: Add OF device ID table Javier Martinez Canillas
@ 2017-03-28 13:45 ` Felipe Balbi
2017-03-28 13:54 ` Javier Martinez Canillas
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2017-03-28 13:45 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Javier Martinez Canillas, Greg Kroah-Hartman, linux-usb
Hi,
Javier Martinez Canillas <javier@osg.samsung.com> writes:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
this is already upstream. Care to send an incremental diff in case we
need this fixed further?
--
balbi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] usb: phy: isp1301: Add OF device ID table
2017-03-28 13:45 ` Felipe Balbi
@ 2017-03-28 13:54 ` Javier Martinez Canillas
0 siblings, 0 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2017-03-28 13:54 UTC (permalink / raw)
To: Felipe Balbi, linux-kernel; +Cc: Greg Kroah-Hartman, linux-usb
Hello Felipe,
On 03/28/2017 09:45 AM, Felipe Balbi wrote:
>
> Hi,
>
> Javier Martinez Canillas <javier@osg.samsung.com> writes:
>> The driver doesn't have a struct of_device_id table but supported devices
>> are registered via Device Trees. This is working on the assumption that a
>> I2C device registered via OF will always match a legacy I2C device ID and
>> that the MODALIAS reported will always be of the form i2c:<device>.
>>
>> But this could change in the future so the correct approach is to have an
>> OF device ID table if the devices are registered via OF.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> this is already upstream. Care to send an incremental diff in case we
> need this fixed further?
>
Ah, sorry. I missed that was already picked. Sure, I'll post an incremental
diff on top of v1. Thanks!
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-28 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-15 3:46 [PATCH v2] usb: phy: isp1301: Add OF device ID table Javier Martinez Canillas
2017-03-28 13:45 ` Felipe Balbi
2017-03-28 13:54 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).