* [PATCH 1/4] staging: atomisp: fix unsigned int comparison with less than zero
@ 2017-03-15 5:55 Daeseok Youn
0 siblings, 0 replies; only message in thread
From: Daeseok Youn @ 2017-03-15 5:55 UTC (permalink / raw)
To: mchehab
Cc: gregkh, daeseok.youn, alan, dan.carpenter, singhalsimran0,
linux-media, devel, linux-kernel, kernel-janitors
Fix warnings from the smatch tool
atomisp_cmd.c:2649
atomisp_set_array_res() warn:
unsigned 'config->width' is never less than zero.
atomisp_cmd.c:2650
atomisp_set_array_res() warn:
unsigned 'config->height' is never less than zero.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
index 1ee99d0..9c3ba11 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
@@ -2646,8 +2646,7 @@ int atomisp_set_array_res(struct atomisp_sub_device *asd,
struct atomisp_resolution *config)
{
dev_dbg(asd->isp->dev, ">%s start\n", __func__);
- if (config == NULL || config->width < 0
- || config->height < 0) {
+ if (!config) {
dev_err(asd->isp->dev, "Set sensor array size is not valid\n");
return -EINVAL;
}
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-03-15 5:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-15 5:55 [PATCH 1/4] staging: atomisp: fix unsigned int comparison with less than zero Daeseok Youn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).