* [PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example
@ 2017-03-20 9:57 Antonio Borneo
2017-03-20 9:57 ` [PATCH 2/4] ARM: SPEAr: DT: Remove nonexistent properties Antonio Borneo
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Antonio Borneo @ 2017-03-20 9:57 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Mark Rutland
Cc: Antonio Borneo, Viresh Kumar, Shiraz Hashim, Russell King,
Brijesh Singh, Suravee Suthikulpanit, Tom Lendacky,
Catalin Marinas, Will Deacon, Ray Jui, Scott Branden, Jon Mason,
bcm-kernel-feedback-list, linux-spi, devicetree, linux-kernel,
linux-arm-kernel
The properties "pl022,hierarchy" and "pl022,slave-tx-disable" were
initially proposed till patch V4 [1] but then discarded in V5 [2]
when the patch set was taken over by another developer, as
explained in patch history in [3].
The above properties never landed in mainline code but were then
listed in the binding example by a following commit dc715452e914
("spi: pl022: use generic DMA slave configuration if possible")
and later on they were copy-paste in some board's DT.
Remove the nonexistent properties from the example.
Also remove a spaces-only line at the end of the file.
[1] https://lkml.org/lkml/2012/7/9/421
[2] https://lkml.org/lkml/2012/8/21/427
[3] https://lkml.org/lkml/2012/8/21/436
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
---
To: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Viresh Kumar <vireshk@kernel.org>
Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Brijesh Singh <brijeshkumar.singh@amd.com>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Jon Mason <jonmason@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-spi@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
Documentation/devicetree/bindings/spi/spi_pl022.txt | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/spi_pl022.txt b/Documentation/devicetree/bindings/spi/spi_pl022.txt
index 4d1673ca8cf8..2692a5726c3f 100644
--- a/Documentation/devicetree/bindings/spi/spi_pl022.txt
+++ b/Documentation/devicetree/bindings/spi/spi_pl022.txt
@@ -56,9 +56,7 @@ Example:
spi-max-frequency = <12000000>;
spi-cpol;
spi-cpha;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
- pl022,slave-tx-disable;
pl022,com-mode = <0x2>;
pl022,rx-level-trig = <0>;
pl022,tx-level-trig = <0>;
@@ -67,4 +65,3 @@ Example:
pl022,duplex = <0>;
};
};
-
--
2.12.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/4] ARM: SPEAr: DT: Remove nonexistent properties
2017-03-20 9:57 [PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example Antonio Borneo
@ 2017-03-20 9:57 ` Antonio Borneo
2017-03-20 11:05 ` Viresh Kumar
2017-03-20 9:57 ` [PATCH 3/4] arm64: dts: amd: Remove nonexistent property Antonio Borneo
` (3 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: Antonio Borneo @ 2017-03-20 9:57 UTC (permalink / raw)
To: Viresh Kumar, Shiraz Hashim
Cc: Antonio Borneo, Mark Brown, Rob Herring, Mark Rutland,
Russell King, Brijesh Singh, Suravee Suthikulpanit, Tom Lendacky,
Catalin Marinas, Will Deacon, Ray Jui, Scott Branden, Jon Mason,
bcm-kernel-feedback-list, linux-spi, devicetree, linux-kernel,
linux-arm-kernel
The properties "pl022,hierarchy" and "pl022,slave-tx-disable" are
not documented in DT binding and don't exist in the driver code.
They have no effect and can be removed.
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
---
Cc: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
To: Viresh Kumar <vireshk@kernel.org>
To: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Brijesh Singh <brijeshkumar.singh@amd.com>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Jon Mason <jonmason@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-spi@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
arch/arm/boot/dts/spear1310-evb.dts | 6 ------
arch/arm/boot/dts/spear1340-evb.dts | 6 ------
2 files changed, 12 deletions(-)
diff --git a/arch/arm/boot/dts/spear1310-evb.dts b/arch/arm/boot/dts/spear1310-evb.dts
index 84101e4eebbf..e70f78b7eaf4 100644
--- a/arch/arm/boot/dts/spear1310-evb.dts
+++ b/arch/arm/boot/dts/spear1310-evb.dts
@@ -358,9 +358,7 @@
#size-cells = <0>;
spi-max-frequency = <1000000>;
spi-cpha;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
- pl022,slave-tx-disable;
pl022,com-mode = <0>;
pl022,rx-level-trig = <0>;
pl022,tx-level-trig = <0>;
@@ -391,9 +389,7 @@
spi-max-frequency = <12000000>;
spi-cpol;
spi-cpha;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
- pl022,slave-tx-disable;
pl022,com-mode = <0x2>;
pl022,rx-level-trig = <0>;
pl022,tx-level-trig = <0>;
@@ -407,9 +403,7 @@
reg = <2>;
spi-max-frequency = <25000000>;
spi-cpha;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
- pl022,slave-tx-disable;
pl022,com-mode = <0x2>;
pl022,rx-level-trig = <0>;
pl022,tx-level-trig = <0>;
diff --git a/arch/arm/boot/dts/spear1340-evb.dts b/arch/arm/boot/dts/spear1340-evb.dts
index 6565f3cb866f..f31d2e83fae5 100644
--- a/arch/arm/boot/dts/spear1340-evb.dts
+++ b/arch/arm/boot/dts/spear1340-evb.dts
@@ -451,9 +451,7 @@
spi-max-frequency = <12000000>;
spi-cpol;
spi-cpha;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
- pl022,slave-tx-disable;
pl022,com-mode = <0x2>;
pl022,rx-level-trig = <0>;
pl022,tx-level-trig = <0>;
@@ -467,9 +465,7 @@
spi-max-frequency = <1000000>;
spi-cpha;
reg = <1>;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
- pl022,slave-tx-disable;
pl022,com-mode = <0>;
pl022,rx-level-trig = <0>;
pl022,tx-level-trig = <0>;
@@ -501,9 +497,7 @@
reg = <2>;
spi-max-frequency = <25000000>;
spi-cpha;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
- pl022,slave-tx-disable;
pl022,com-mode = <0x2>;
pl022,rx-level-trig = <0>;
pl022,tx-level-trig = <0>;
--
2.12.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/4] arm64: dts: amd: Remove nonexistent property
2017-03-20 9:57 [PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example Antonio Borneo
2017-03-20 9:57 ` [PATCH 2/4] ARM: SPEAr: DT: Remove nonexistent properties Antonio Borneo
@ 2017-03-20 9:57 ` Antonio Borneo
2017-03-20 9:57 ` [PATCH 4/4] arm64: dts: NS2: Remove nonexistent properties Antonio Borneo
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Antonio Borneo @ 2017-03-20 9:57 UTC (permalink / raw)
To: Brijesh Singh, Suravee Suthikulpanit, Tom Lendacky
Cc: Antonio Borneo, Mark Brown, Rob Herring, Mark Rutland,
Viresh Kumar, Shiraz Hashim, Russell King, Catalin Marinas,
Will Deacon, Ray Jui, Scott Branden, Jon Mason,
bcm-kernel-feedback-list, linux-spi, devicetree, linux-kernel,
linux-arm-kernel
The property "pl022,hierarchy" is not documented in DT binding
and doesn't exist in the driver code.
It has no effect and can be removed.
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
---
Cc: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Viresh Kumar <vireshk@kernel.org>
Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
To: Brijesh Singh <brijeshkumar.singh@amd.com>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Jon Mason <jonmason@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-spi@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts | 1 -
arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts | 1 -
arch/arm64/boot/dts/amd/amd-overdrive.dts | 1 -
arch/arm64/boot/dts/amd/husky.dts | 1 -
4 files changed, 4 deletions(-)
diff --git a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts
index 8e3074a4947d..399baf4040e3 100644
--- a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts
+++ b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts
@@ -70,7 +70,6 @@
reg = <0>;
spi-max-frequency = <20000000>;
voltage-ranges = <3200 3400>;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
pl022,com-mode = <0x0>;
pl022,rx-level-trig = <0>;
diff --git a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts
index ed5e043f37aa..be60accbcaf7 100644
--- a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts
+++ b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts
@@ -74,7 +74,6 @@
reg = <0>;
spi-max-frequency = <20000000>;
voltage-ranges = <3200 3400>;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
pl022,com-mode = <0x0>;
pl022,rx-level-trig = <0>;
diff --git a/arch/arm64/boot/dts/amd/amd-overdrive.dts b/arch/arm64/boot/dts/amd/amd-overdrive.dts
index 128fa942f09e..940cc33f3a69 100644
--- a/arch/arm64/boot/dts/amd/amd-overdrive.dts
+++ b/arch/arm64/boot/dts/amd/amd-overdrive.dts
@@ -51,7 +51,6 @@
gpios = <&gpio0 7 0>;
interrupt-parent = <&gpio0>;
interrupts = <7 3>;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
pl022,com-mode = <0x0>;
pl022,rx-level-trig = <0>;
diff --git a/arch/arm64/boot/dts/amd/husky.dts b/arch/arm64/boot/dts/amd/husky.dts
index 1381d4b2bf1b..e4a6a9122671 100644
--- a/arch/arm64/boot/dts/amd/husky.dts
+++ b/arch/arm64/boot/dts/amd/husky.dts
@@ -70,7 +70,6 @@
reg = <0>;
spi-max-frequency = <20000000>;
voltage-ranges = <3200 3400>;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
pl022,com-mode = <0x0>;
pl022,rx-level-trig = <0>;
--
2.12.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 4/4] arm64: dts: NS2: Remove nonexistent properties
2017-03-20 9:57 [PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example Antonio Borneo
2017-03-20 9:57 ` [PATCH 2/4] ARM: SPEAr: DT: Remove nonexistent properties Antonio Borneo
2017-03-20 9:57 ` [PATCH 3/4] arm64: dts: amd: Remove nonexistent property Antonio Borneo
@ 2017-03-20 9:57 ` Antonio Borneo
2017-03-20 13:42 ` [PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example Mark Rutland
2017-03-21 18:46 ` Applied "spi: pl022: remove nonexistent properties from DT binding example" to the spi tree Mark Brown
4 siblings, 0 replies; 7+ messages in thread
From: Antonio Borneo @ 2017-03-20 9:57 UTC (permalink / raw)
To: Ray Jui, Scott Branden, Jon Mason
Cc: Antonio Borneo, Mark Brown, Rob Herring, Mark Rutland,
Viresh Kumar, Shiraz Hashim, Russell King, Brijesh Singh,
Suravee Suthikulpanit, Tom Lendacky, Catalin Marinas,
Will Deacon, bcm-kernel-feedback-list, linux-spi, devicetree,
linux-kernel, linux-arm-kernel
The properties "pl022,hierarchy" and "pl022,slave-tx-disable" are
not documented in DT binding and don't exist in the driver code.
They have no effect and can be removed.
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
---
Cc: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Viresh Kumar <vireshk@kernel.org>
Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Brijesh Singh <brijeshkumar.singh@amd.com>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
To: Ray Jui <rjui@broadcom.com>
To: Scott Branden <sbranden@broadcom.com>
To: Jon Mason <jonmason@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-spi@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
arch/arm64/boot/dts/broadcom/ns2-svk.dts | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
index 5ae08161649e..2fbd3cd40def 100644
--- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts
+++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
@@ -113,9 +113,7 @@
spi-max-frequency = <5000000>;
spi-cpha = <1>;
spi-cpol = <1>;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
- pl022,slave-tx-disable = <0>;
pl022,com-mode = <0>;
pl022,rx-level-trig = <1>;
pl022,tx-level-trig = <1>;
@@ -137,9 +135,7 @@
at25,page-size = <64>;
spi-cpha = <1>;
spi-cpol = <1>;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
- pl022,slave-tx-disable = <0>;
pl022,com-mode = <0>;
pl022,rx-level-trig = <1>;
pl022,tx-level-trig = <1>;
--
2.12.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/4] ARM: SPEAr: DT: Remove nonexistent properties
2017-03-20 9:57 ` [PATCH 2/4] ARM: SPEAr: DT: Remove nonexistent properties Antonio Borneo
@ 2017-03-20 11:05 ` Viresh Kumar
0 siblings, 0 replies; 7+ messages in thread
From: Viresh Kumar @ 2017-03-20 11:05 UTC (permalink / raw)
To: Antonio Borneo
Cc: Viresh Kumar, Shiraz Hashim, Mark Brown, Rob Herring,
Mark Rutland, Russell King, Brijesh Singh, Suravee Suthikulpanit,
Tom Lendacky, Catalin Marinas, Will Deacon, Ray Jui,
Scott Branden, Jon Mason, bcm-kernel-feedback-list, linux-spi,
devicetree, linux-kernel, linux-arm-kernel
On 20-03-17, 10:57, Antonio Borneo wrote:
> The properties "pl022,hierarchy" and "pl022,slave-tx-disable" are
> not documented in DT binding and don't exist in the driver code.
> They have no effect and can be removed.
>
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
> ---
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> To: Viresh Kumar <vireshk@kernel.org>
> To: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Brijesh Singh <brijeshkumar.singh@amd.com>
> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Jon Mason <jonmason@broadcom.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: linux-spi@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/boot/dts/spear1310-evb.dts | 6 ------
> arch/arm/boot/dts/spear1340-evb.dts | 6 ------
> 2 files changed, 12 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example
2017-03-20 9:57 [PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example Antonio Borneo
` (2 preceding siblings ...)
2017-03-20 9:57 ` [PATCH 4/4] arm64: dts: NS2: Remove nonexistent properties Antonio Borneo
@ 2017-03-20 13:42 ` Mark Rutland
2017-03-21 18:46 ` Applied "spi: pl022: remove nonexistent properties from DT binding example" to the spi tree Mark Brown
4 siblings, 0 replies; 7+ messages in thread
From: Mark Rutland @ 2017-03-20 13:42 UTC (permalink / raw)
To: Antonio Borneo
Cc: Mark Brown, Rob Herring, Viresh Kumar, Shiraz Hashim,
Russell King, Brijesh Singh, Suravee Suthikulpanit, Tom Lendacky,
Catalin Marinas, Will Deacon, Ray Jui, Scott Branden, Jon Mason,
bcm-kernel-feedback-list, linux-spi, devicetree, linux-kernel,
linux-arm-kernel
On Mon, Mar 20, 2017 at 10:57:18AM +0100, Antonio Borneo wrote:
> The properties "pl022,hierarchy" and "pl022,slave-tx-disable" were
> initially proposed till patch V4 [1] but then discarded in V5 [2]
> when the patch set was taken over by another developer, as
> explained in patch history in [3].
> The above properties never landed in mainline code but were then
> listed in the binding example by a following commit dc715452e914
> ("spi: pl022: use generic DMA slave configuration if possible")
> and later on they were copy-paste in some board's DT.
>
> Remove the nonexistent properties from the example.
> Also remove a spaces-only line at the end of the file.
>
> [1] https://lkml.org/lkml/2012/7/9/421
> [2] https://lkml.org/lkml/2012/8/21/427
> [3] https://lkml.org/lkml/2012/8/21/436
>
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
For the series:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> diff --git a/Documentation/devicetree/bindings/spi/spi_pl022.txt b/Documentation/devicetree/bindings/spi/spi_pl022.txt
> index 4d1673ca8cf8..2692a5726c3f 100644
> --- a/Documentation/devicetree/bindings/spi/spi_pl022.txt
> +++ b/Documentation/devicetree/bindings/spi/spi_pl022.txt
> @@ -56,9 +56,7 @@ Example:
> spi-max-frequency = <12000000>;
> spi-cpol;
> spi-cpha;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> - pl022,slave-tx-disable;
> pl022,com-mode = <0x2>;
> pl022,rx-level-trig = <0>;
> pl022,tx-level-trig = <0>;
> @@ -67,4 +65,3 @@ Example:
> pl022,duplex = <0>;
> };
> };
> -
> --
> 2.12.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Applied "spi: pl022: remove nonexistent properties from DT binding example" to the spi tree
2017-03-20 9:57 [PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example Antonio Borneo
` (3 preceding siblings ...)
2017-03-20 13:42 ` [PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example Mark Rutland
@ 2017-03-21 18:46 ` Mark Brown
4 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2017-03-21 18:46 UTC (permalink / raw)
To: Antonio Borneo
Cc: Mark Brown, Mark Brown, Rob Herring, Mark Rutland, Viresh Kumar,
Shiraz Hashim, Russell King, Brijesh Singh,
Suravee Suthikulpanit, Tom Lendacky, Catalin Marinas,
Will Deacon, Ray Jui, Scott Branden, Jon Mason,
bcm-kernel-feedback-list, linux-spi, devicetree, linux-kernel,
linux-arm-kernel, linux-spi
The patch
spi: pl022: remove nonexistent properties from DT binding example
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From e6a72e057fa3e0ad38ec59c4779647a7bd390a37 Mon Sep 17 00:00:00 2001
From: Antonio Borneo <borneo.antonio@gmail.com>
Date: Mon, 20 Mar 2017 10:57:18 +0100
Subject: [PATCH] spi: pl022: remove nonexistent properties from DT binding
example
The properties "pl022,hierarchy" and "pl022,slave-tx-disable" were
initially proposed till patch V4 [1] but then discarded in V5 [2]
when the patch set was taken over by another developer, as
explained in patch history in [3].
The above properties never landed in mainline code but were then
listed in the binding example by a following commit dc715452e914
("spi: pl022: use generic DMA slave configuration if possible")
and later on they were copy-paste in some board's DT.
Remove the nonexistent properties from the example.
Also remove a spaces-only line at the end of the file.
[1] https://lkml.org/lkml/2012/7/9/421
[2] https://lkml.org/lkml/2012/8/21/427
[3] https://lkml.org/lkml/2012/8/21/436
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
Documentation/devicetree/bindings/spi/spi_pl022.txt | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/spi_pl022.txt b/Documentation/devicetree/bindings/spi/spi_pl022.txt
index 4d1673ca8cf8..2692a5726c3f 100644
--- a/Documentation/devicetree/bindings/spi/spi_pl022.txt
+++ b/Documentation/devicetree/bindings/spi/spi_pl022.txt
@@ -56,9 +56,7 @@ Example:
spi-max-frequency = <12000000>;
spi-cpol;
spi-cpha;
- pl022,hierarchy = <0>;
pl022,interface = <0>;
- pl022,slave-tx-disable;
pl022,com-mode = <0x2>;
pl022,rx-level-trig = <0>;
pl022,tx-level-trig = <0>;
@@ -67,4 +65,3 @@ Example:
pl022,duplex = <0>;
};
};
-
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-03-21 18:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-20 9:57 [PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example Antonio Borneo
2017-03-20 9:57 ` [PATCH 2/4] ARM: SPEAr: DT: Remove nonexistent properties Antonio Borneo
2017-03-20 11:05 ` Viresh Kumar
2017-03-20 9:57 ` [PATCH 3/4] arm64: dts: amd: Remove nonexistent property Antonio Borneo
2017-03-20 9:57 ` [PATCH 4/4] arm64: dts: NS2: Remove nonexistent properties Antonio Borneo
2017-03-20 13:42 ` [PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example Mark Rutland
2017-03-21 18:46 ` Applied "spi: pl022: remove nonexistent properties from DT binding example" to the spi tree Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).