* [PATCH RT] tty: serial: st-asc: Make the locking RT aware
@ 2017-03-21 16:05 lionel.debieve
2017-03-21 18:44 ` Steven Rostedt
0 siblings, 1 reply; 7+ messages in thread
From: lionel.debieve @ 2017-03-21 16:05 UTC (permalink / raw)
To: linux-rt-users, linux-kernel
Cc: bigeasy, tglx, rostedt, Patrice Chotard, Greg Kroah-Hartman,
Jiri Slaby, Lionel Debieve
From: Lionel Debieve <lionel.debieve@st.com>
The lock is a sleeping lock and local_irq_save() is not the
standard implementation now. Working for both -RT and non
RT.
Signed-off-by: Lionel Debieve <lionel.debieve@st.com>
---
drivers/tty/serial/st-asc.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index 379e5bd..1815423 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -803,13 +803,12 @@ static void asc_console_write(struct console *co, const char *s, unsigned count)
int locked = 1;
u32 intenable;
- local_irq_save(flags);
if (port->sysrq)
locked = 0; /* asc_interrupt has already claimed the lock */
else if (oops_in_progress)
- locked = spin_trylock(&port->lock);
+ locked = spin_trylock_irqsave(&port->lock, flags);
else
- spin_lock(&port->lock);
+ spin_lock_irqsave(&port->lock, flags);
/*
* Disable interrupts so we don't get the IRQ line bouncing
@@ -827,8 +826,7 @@ static void asc_console_write(struct console *co, const char *s, unsigned count)
asc_out(port, ASC_INTEN, intenable);
if (locked)
- spin_unlock(&port->lock);
- local_irq_restore(flags);
+ spin_unlock_irqrestore(&port->lock, flags);
}
static int asc_console_setup(struct console *co, char *options)
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware
2017-03-21 16:05 [PATCH RT] tty: serial: st-asc: Make the locking RT aware lionel.debieve
@ 2017-03-21 18:44 ` Steven Rostedt
2017-03-21 18:51 ` Thomas Gleixner
0 siblings, 1 reply; 7+ messages in thread
From: Steven Rostedt @ 2017-03-21 18:44 UTC (permalink / raw)
To: lionel.debieve
Cc: linux-rt-users, linux-kernel, bigeasy, tglx, Patrice Chotard,
Greg Kroah-Hartman, Jiri Slaby
On Tue, 21 Mar 2017 17:05:40 +0100
<lionel.debieve@st.com> wrote:
> From: Lionel Debieve <lionel.debieve@st.com>
>
> The lock is a sleeping lock and local_irq_save() is not the
> standard implementation now. Working for both -RT and non
> RT.
If this is for both RT and non RT then the patch subject should just be
[PATCH] and not [PATCH RT] as the latter tells upstream folks not to
bother.
>
> Signed-off-by: Lionel Debieve <lionel.debieve@st.com>
> ---
> drivers/tty/serial/st-asc.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index 379e5bd..1815423 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -803,13 +803,12 @@ static void asc_console_write(struct console
> *co, const char *s, unsigned count) int locked = 1;
> u32 intenable;
>
> - local_irq_save(flags);
> if (port->sysrq)
> locked = 0; /* asc_interrupt has already claimed the
> lock */ else if (oops_in_progress)
> - locked = spin_trylock(&port->lock);
> + locked = spin_trylock_irqsave(&port->lock, flags);
> else
> - spin_lock(&port->lock);
> + spin_lock_irqsave(&port->lock, flags);
>
> /*
> * Disable interrupts so we don't get the IRQ line bouncing
I'm nervous about the above comment, which in full is:
/*
* Disable interrupts so we don't get the IRQ line bouncing
* up and down while interrupts are disabled.
*/
I'm not sure if disabling interrupts helps on an SMP system. This patch
does change what happens when port->sysrq is set. But I'm not sure we
care.
-- Steve
> @@ -827,8 +826,7 @@ static void asc_console_write(struct console *co,
> const char *s, unsigned count) asc_out(port, ASC_INTEN, intenable);
>
> if (locked)
> - spin_unlock(&port->lock);
> - local_irq_restore(flags);
> + spin_unlock_irqrestore(&port->lock, flags);
> }
>
> static int asc_console_setup(struct console *co, char *options)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware
2017-03-21 18:44 ` Steven Rostedt
@ 2017-03-21 18:51 ` Thomas Gleixner
2017-03-21 20:15 ` Steven Rostedt
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Gleixner @ 2017-03-21 18:51 UTC (permalink / raw)
To: Steven Rostedt
Cc: lionel.debieve, linux-rt-users, linux-kernel, bigeasy,
Patrice Chotard, Greg Kroah-Hartman, Jiri Slaby
On Tue, 21 Mar 2017, Steven Rostedt wrote:
> > /*
> > * Disable interrupts so we don't get the IRQ line bouncing
>
> I'm nervous about the above comment, which in full is:
>
> /*
> * Disable interrupts so we don't get the IRQ line bouncing
> * up and down while interrupts are disabled.
> */
>
> I'm not sure if disabling interrupts helps on an SMP system. This patch
> does change what happens when port->sysrq is set. But I'm not sure we
> care.
It disables interrupts at the device level which obviously helps whether on
SMP or not.
Thanks,
tglx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware
2017-03-21 18:51 ` Thomas Gleixner
@ 2017-03-21 20:15 ` Steven Rostedt
2017-03-22 8:43 ` Lionel DEBIEVE
0 siblings, 1 reply; 7+ messages in thread
From: Steven Rostedt @ 2017-03-21 20:15 UTC (permalink / raw)
To: Thomas Gleixner
Cc: lionel.debieve, linux-rt-users, linux-kernel, bigeasy,
Patrice Chotard, Greg Kroah-Hartman, Jiri Slaby
On Tue, 21 Mar 2017 19:51:47 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:
> On Tue, 21 Mar 2017, Steven Rostedt wrote:
> > > /*
> > > * Disable interrupts so we don't get the IRQ line
> > > bouncing
> >
> > I'm nervous about the above comment, which in full is:
> >
> > /*
> > * Disable interrupts so we don't get the IRQ line bouncing
> > * up and down while interrupts are disabled.
> > */
> >
> > I'm not sure if disabling interrupts helps on an SMP system. This
> > patch does change what happens when port->sysrq is set. But I'm not
> > sure we care.
>
> It disables interrupts at the device level which obviously helps
> whether on SMP or not.
>
OK, so this has nothing to do with the local_irq_save() that is being
removed, which would be fine then.
-- Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware
2017-03-21 20:15 ` Steven Rostedt
@ 2017-03-22 8:43 ` Lionel DEBIEVE
2017-03-22 16:10 ` Steven Rostedt
0 siblings, 1 reply; 7+ messages in thread
From: Lionel DEBIEVE @ 2017-03-22 8:43 UTC (permalink / raw)
To: Steven Rostedt, Thomas Gleixner
Cc: linux-rt-users, linux-kernel, bigeasy, Patrice CHOTARD,
Greg Kroah-Hartman, Jiri Slaby
Just to agree with Thomas.
Do you want me to resend the patch without RT tag?
BR,
Lionel
On 03/21/2017 09:15 PM, Steven Rostedt wrote:
> On Tue, 21 Mar 2017 19:51:47 +0100 (CET)
> Thomas Gleixner <tglx@linutronix.de> wrote:
>
>> On Tue, 21 Mar 2017, Steven Rostedt wrote:
>>>> /*
>>>> * Disable interrupts so we don't get the IRQ line
>>>> bouncing
>>> I'm nervous about the above comment, which in full is:
>>>
>>> /*
>>> * Disable interrupts so we don't get the IRQ line bouncing
>>> * up and down while interrupts are disabled.
>>> */
>>>
>>> I'm not sure if disabling interrupts helps on an SMP system. This
>>> patch does change what happens when port->sysrq is set. But I'm not
>>> sure we care.
>> It disables interrupts at the device level which obviously helps
>> whether on SMP or not.
>>
> OK, so this has nothing to do with the local_irq_save() that is being
> removed, which would be fine then.
>
>
> -- Steve
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware
2017-03-22 8:43 ` Lionel DEBIEVE
@ 2017-03-22 16:10 ` Steven Rostedt
2017-03-22 16:14 ` Lionel DEBIEVE
0 siblings, 1 reply; 7+ messages in thread
From: Steven Rostedt @ 2017-03-22 16:10 UTC (permalink / raw)
To: Lionel DEBIEVE
Cc: Thomas Gleixner, linux-rt-users, linux-kernel, bigeasy,
Patrice CHOTARD, Greg Kroah-Hartman, Jiri Slaby
On Wed, 22 Mar 2017 08:43:50 +0000
Lionel DEBIEVE <lionel.debieve@st.com> wrote:
> Just to agree with Thomas.
>
> Do you want me to resend the patch without RT tag?
>
Yes please. And hopefully it will be picked up in mainline.
-- Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH RT] tty: serial: st-asc: Make the locking RT aware
2017-03-22 16:10 ` Steven Rostedt
@ 2017-03-22 16:14 ` Lionel DEBIEVE
0 siblings, 0 replies; 7+ messages in thread
From: Lionel DEBIEVE @ 2017-03-22 16:14 UTC (permalink / raw)
To: Steven Rostedt
Cc: Thomas Gleixner, linux-rt-users, linux-kernel, bigeasy,
Patrice CHOTARD, Greg Kroah-Hartman, Jiri Slaby
OK, resend without.
BR
Lionel
-----Original Message-----
From: Steven Rostedt [mailto:rostedt@goodmis.org]
Sent: mercredi 22 mars 2017 17:11
To: Lionel DEBIEVE <lionel.debieve@st.com>
Cc: Thomas Gleixner <tglx@linutronix.de>; linux-rt-users@vger.kernel.org; linux-kernel@vger.kernel.org; bigeasy@linutronix.de; Patrice CHOTARD <patrice.chotard@st.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware
On Wed, 22 Mar 2017 08:43:50 +0000
Lionel DEBIEVE <lionel.debieve@st.com> wrote:
> Just to agree with Thomas.
>
> Do you want me to resend the patch without RT tag?
>
Yes please. And hopefully it will be picked up in mainline.
-- Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-03-22 16:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-21 16:05 [PATCH RT] tty: serial: st-asc: Make the locking RT aware lionel.debieve
2017-03-21 18:44 ` Steven Rostedt
2017-03-21 18:51 ` Thomas Gleixner
2017-03-21 20:15 ` Steven Rostedt
2017-03-22 8:43 ` Lionel DEBIEVE
2017-03-22 16:10 ` Steven Rostedt
2017-03-22 16:14 ` Lionel DEBIEVE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).