* [PATCH] ipmi: bt-bmc: Add ast2500 compatible string
@ 2017-03-22 14:01 Joel Stanley
2017-03-22 14:09 ` Cédric Le Goater
2017-03-29 1:22 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Joel Stanley @ 2017-03-22 14:01 UTC (permalink / raw)
To: Corey Minyard
Cc: openipmi-developer, linux-kernel, devicetree,
Cédric Le Goater, Andrew Jeffery, Mark Rutland, Rob Herring
The ast2500 SoCs contain the same IPMI BT device.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 4 +++-
drivers/char/ipmi/bt-bmc.c | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt
index 6f28969af9dc..028268fd99ee 100644
--- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt
+++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt
@@ -6,7 +6,9 @@ perform in-band IPMI communication with their host.
Required properties:
-- compatible : should be "aspeed,ast2400-ibt-bmc"
+- compatible : should be one of
+ "aspeed,ast2400-ibt-bmc"
+ "aspeed,ast2500-ibt-bmc"
- reg: physical address and size of the registers
Optional properties:
diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
index fc9e8891eae3..002907e6c7d9 100644
--- a/drivers/char/ipmi/bt-bmc.c
+++ b/drivers/char/ipmi/bt-bmc.c
@@ -485,6 +485,7 @@ static int bt_bmc_remove(struct platform_device *pdev)
static const struct of_device_id bt_bmc_match[] = {
{ .compatible = "aspeed,ast2400-ibt-bmc" },
+ { .compatible = "aspeed,ast2500-ibt-bmc" },
{ },
};
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ipmi: bt-bmc: Add ast2500 compatible string
2017-03-22 14:01 [PATCH] ipmi: bt-bmc: Add ast2500 compatible string Joel Stanley
@ 2017-03-22 14:09 ` Cédric Le Goater
2017-03-29 1:22 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Cédric Le Goater @ 2017-03-22 14:09 UTC (permalink / raw)
To: Joel Stanley, Corey Minyard
Cc: openipmi-developer, linux-kernel, devicetree, Andrew Jeffery,
Mark Rutland, Rob Herring
On 03/22/2017 03:01 PM, Joel Stanley wrote:
> The ast2500 SoCs contain the same IPMI BT device.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 4 +++-
> drivers/char/ipmi/bt-bmc.c | 1 +
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt
> index 6f28969af9dc..028268fd99ee 100644
> --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt
> +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt
> @@ -6,7 +6,9 @@ perform in-band IPMI communication with their host.
>
> Required properties:
>
> -- compatible : should be "aspeed,ast2400-ibt-bmc"
> +- compatible : should be one of
> + "aspeed,ast2400-ibt-bmc"
> + "aspeed,ast2500-ibt-bmc"
> - reg: physical address and size of the registers
>
> Optional properties:
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index fc9e8891eae3..002907e6c7d9 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -485,6 +485,7 @@ static int bt_bmc_remove(struct platform_device *pdev)
>
> static const struct of_device_id bt_bmc_match[] = {
> { .compatible = "aspeed,ast2400-ibt-bmc" },
> + { .compatible = "aspeed,ast2500-ibt-bmc" },
> { },
> };
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ipmi: bt-bmc: Add ast2500 compatible string
2017-03-22 14:01 [PATCH] ipmi: bt-bmc: Add ast2500 compatible string Joel Stanley
2017-03-22 14:09 ` Cédric Le Goater
@ 2017-03-29 1:22 ` Rob Herring
2017-03-29 2:16 ` Corey Minyard
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2017-03-29 1:22 UTC (permalink / raw)
To: Joel Stanley
Cc: Corey Minyard, openipmi-developer, linux-kernel, devicetree,
Cédric Le Goater, Andrew Jeffery, Mark Rutland
On Thu, Mar 23, 2017 at 12:31:12AM +1030, Joel Stanley wrote:
> The ast2500 SoCs contain the same IPMI BT device.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 4 +++-
> drivers/char/ipmi/bt-bmc.c | 1 +
> 2 files changed, 4 insertions(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ipmi: bt-bmc: Add ast2500 compatible string
2017-03-29 1:22 ` Rob Herring
@ 2017-03-29 2:16 ` Corey Minyard
0 siblings, 0 replies; 4+ messages in thread
From: Corey Minyard @ 2017-03-29 2:16 UTC (permalink / raw)
To: Rob Herring, Joel Stanley
Cc: openipmi-developer, linux-kernel, devicetree,
Cédric Le Goater, Andrew Jeffery, Mark Rutland
On 03/28/2017 08:22 PM, Rob Herring wrote:
> On Thu, Mar 23, 2017 at 12:31:12AM +1030, Joel Stanley wrote:
>> The ast2500 SoCs contain the same IPMI BT device.
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> ---
>> Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 4 +++-
>> drivers/char/ipmi/bt-bmc.c | 1 +
>> 2 files changed, 4 insertions(+), 1 deletion(-)
> Acked-by: Rob Herring <robh@kernel.org>
This is in the IPMI tree for the next kernel.
Thanks all,
-corey
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-29 2:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-22 14:01 [PATCH] ipmi: bt-bmc: Add ast2500 compatible string Joel Stanley
2017-03-22 14:09 ` Cédric Le Goater
2017-03-29 1:22 ` Rob Herring
2017-03-29 2:16 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).