* [PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma
@ 2017-03-29 6:53 vaibhavddit
2017-03-29 7:08 ` Greg KH
2017-03-29 22:55 ` kbuild test robot
0 siblings, 2 replies; 3+ messages in thread
From: vaibhavddit @ 2017-03-29 6:53 UTC (permalink / raw)
To: thomas.petazzoni; +Cc: gregkh, devel, linux-kernel, Vaibhav Kothari
From: Vaibhav Kothari <vaibhavddit@gmail.com>
Removed whitespace & comma in fbtft-bus.c as a part of
checkpatch.pl fix-up.
Signed-off-by: Vaibhav Kothari <vaibhavddit@gmail.com>
---
drivers/staging/fbtft/fbtft-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 3475b1b..2a18417 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -56,9 +56,9 @@ void func(struct fbtft_par *par, int len, ...) \
} \
EXPORT_SYMBOL(func);
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
{
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma
2017-03-29 6:53 [PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma vaibhavddit
@ 2017-03-29 7:08 ` Greg KH
2017-03-29 22:55 ` kbuild test robot
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2017-03-29 7:08 UTC (permalink / raw)
To: vaibhavddit; +Cc: thomas.petazzoni, devel, linux-kernel
On Wed, Mar 29, 2017 at 12:23:01PM +0530, vaibhavddit@gmail.com wrote:
> From: Vaibhav Kothari <vaibhavddit@gmail.com>
>
> Removed whitespace & comma in fbtft-bus.c as a part of
> checkpatch.pl fix-up.
Did you test build this? Always do so, otherwise you will get grumpy
emails saying you need to test-build your changes...
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma
2017-03-29 6:53 [PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma vaibhavddit
2017-03-29 7:08 ` Greg KH
@ 2017-03-29 22:55 ` kbuild test robot
1 sibling, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2017-03-29 22:55 UTC (permalink / raw)
To: vaibhavddit
Cc: kbuild-all, thomas.petazzoni, devel, gregkh, Vaibhav Kothari,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 5236 bytes --]
Hi Vaibhav,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.11-rc4 next-20170329]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/vaibhavddit-gmail-com/drivers-staging-fbtft-Hush-Checkpatch-pl-Error-about-unnecessary-whitespace-and-comma/20170330-063109
config: x86_64-randconfig-x009-201713 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/staging/fbtft/fbtft-bus.c:59:49: error: macro "define_fbtft_write_reg" requires 3 arguments, but only 2 given
define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
^
>> drivers/staging/fbtft/fbtft-bus.c:14:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
void func(struct fbtft_par *par, int len, ...) \
^
drivers/staging/fbtft/fbtft-bus.c:60:1: note: in expansion of macro 'define_fbtft_write_reg'
define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
^~~~~~~~~~~~~~~~~~~~~~
drivers/staging/fbtft/fbtft-bus.c:61:52: error: macro "define_fbtft_write_reg" requires 3 arguments, but only 2 given
define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
^
drivers/staging/fbtft/fbtft-bus.c:63:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
^~~~
vim +/define_fbtft_write_reg +59 drivers/staging/fbtft/fbtft-bus.c
8 *
9 * void (*write_reg)(struct fbtft_par *par, int len, ...);
10 *
11 *****************************************************************************/
12
13 #define define_fbtft_write_reg(func, type, modifier) \
> 14 void func(struct fbtft_par *par, int len, ...) \
15 { \
16 va_list args; \
17 int i, ret; \
18 int offset = 0; \
19 type *buf = (type *)par->buf; \
20 \
21 if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) { \
22 va_start(args, len); \
23 for (i = 0; i < len; i++) { \
24 buf[i] = (type)va_arg(args, unsigned int); \
25 } \
26 va_end(args); \
27 fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, type, buf, len, "%s: ", __func__); \
28 } \
29 \
30 va_start(args, len); \
31 \
32 if (par->startbyte) { \
33 *(u8 *)par->buf = par->startbyte; \
34 buf = (type *)(par->buf + 1); \
35 offset = 1; \
36 } \
37 \
38 *buf = modifier((type)va_arg(args, unsigned int)); \
39 ret = fbtft_write_buf_dc(par, par->buf, sizeof(type) + offset, 0); \
40 if (ret < 0) \
41 goto out; \
42 len--; \
43 \
44 if (par->startbyte) \
45 *(u8 *)par->buf = par->startbyte | 0x2; \
46 \
47 if (len) { \
48 i = len; \
49 while (i--) \
50 *buf++ = modifier((type)va_arg(args, unsigned int)); \
51 fbtft_write_buf_dc(par, par->buf, \
52 len * (sizeof(type) + offset), 1); \
53 } \
54 out: \
55 va_end(args); \
56 } \
57 EXPORT_SYMBOL(func);
58
> 59 define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
60 define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
61 define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
62
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29016 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-29 22:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-29 6:53 [PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma vaibhavddit
2017-03-29 7:08 ` Greg KH
2017-03-29 22:55 ` kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).