* [PATCH 0/3] introduce QorIQ DPAA 1.x QBMan device tree nodes
@ 2017-03-30 14:37 Madalin Bucur
2017-03-30 14:37 ` [PATCH 1/3] dts: arm64: add DPAA QBMan portals Madalin Bucur
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Madalin Bucur @ 2017-03-30 14:37 UTC (permalink / raw)
To: robh+dt, mark.rutland, devicetree
Cc: linux-arm-kernel, linux-kernel, catalin.marinas, will.deacon,
shawnguo, Gang.Liu, Madalin Bucur
This patch set introduces the QorIQ Data Path Acceleration Arhitecture
(DPAA) Queue Manager and Buffer Manager device tree nodes for the ARM
based DPAA 1.x platforms.
Madalin Bucur (3):
dts: arm64: add DPAA QBMan portals
dts: arm64: add LS1043A DPAA QBMan nodes
dts: arm64: add LS1046A DPAA QBMan nodes
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 52 +++++++++++++++
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 52 +++++++++++++++
.../boot/dts/freescale/qoriq-bman1-portals.dtsi | 67 +++++++++++++++++++
.../boot/dts/freescale/qoriq-qman1-portals.dtsi | 76 ++++++++++++++++++++++
4 files changed, 247 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/qoriq-bman1-portals.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/qoriq-qman1-portals.dtsi
--
2.1.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/3] dts: arm64: add DPAA QBMan portals
2017-03-30 14:37 [PATCH 0/3] introduce QorIQ DPAA 1.x QBMan device tree nodes Madalin Bucur
@ 2017-03-30 14:37 ` Madalin Bucur
2017-03-31 1:49 ` Shawn Guo
2017-03-30 14:37 ` [PATCH 2/3] dts: arm64: add LS1043A DPAA QBMan nodes Madalin Bucur
2017-03-30 14:37 ` [PATCH 3/3] dts: arm64: add LS1046A " Madalin Bucur
2 siblings, 1 reply; 10+ messages in thread
From: Madalin Bucur @ 2017-03-30 14:37 UTC (permalink / raw)
To: robh+dt, mark.rutland, devicetree
Cc: linux-arm-kernel, linux-kernel, catalin.marinas, will.deacon,
shawnguo, Gang.Liu, Madalin Bucur, Roy Pledge
Add the DPAA 1.x DPAA QMan and BMan portal nodes.
Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
.../boot/dts/freescale/qoriq-bman1-portals.dtsi | 67 +++++++++++++++++++
.../boot/dts/freescale/qoriq-qman1-portals.dtsi | 76 ++++++++++++++++++++++
2 files changed, 143 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/qoriq-bman1-portals.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/qoriq-qman1-portals.dtsi
diff --git a/arch/arm64/boot/dts/freescale/qoriq-bman1-portals.dtsi b/arch/arm64/boot/dts/freescale/qoriq-bman1-portals.dtsi
new file mode 100644
index 0000000..b007344
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/qoriq-bman1-portals.dtsi
@@ -0,0 +1,67 @@
+/*
+ * QorIQ BMan Portals device tree
+ *
+ * Copyright 2011-2016 Freescale Semiconductor Inc.
+ *
+ * SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+ */
+
+&bportals {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "simple-bus";
+
+ bman-portal@0 {
+ compatible = "fsl,bman-portal";
+ reg = <0x0 0x4000 0x4000000 0x4000>;
+ interrupts = <0 173 0x4>;
+ };
+
+ bman-portal@10000 {
+ compatible = "fsl,bman-portal";
+ reg = <0x10000 0x4000 0x4010000 0x4000>;
+ interrupts = <0 175 0x4>;
+ };
+
+ bman-portal@20000 {
+ compatible = "fsl,bman-portal";
+ reg = <0x20000 0x4000 0x4020000 0x4000>;
+ interrupts = <0 177 0x4>;
+ };
+
+ bman-portal@30000 {
+ compatible = "fsl,bman-portal";
+ reg = <0x30000 0x4000 0x4030000 0x4000>;
+ interrupts = <0 179 0x4>;
+ };
+
+ bman-portal@40000 {
+ compatible = "fsl,bman-portal";
+ reg = <0x40000 0x4000 0x4040000 0x4000>;
+ interrupts = <0 181 0x4>;
+ };
+
+ bman-portal@50000 {
+ compatible = "fsl,bman-portal";
+ reg = <0x50000 0x4000 0x4050000 0x4000>;
+ interrupts = <0 183 0x4>;
+ };
+
+ bman-portal@60000 {
+ compatible = "fsl,bman-portal";
+ reg = <0x60000 0x4000 0x4060000 0x4000>;
+ interrupts = <0 185 0x4>;
+ };
+
+ bman-portal@70000 {
+ compatible = "fsl,bman-portal";
+ reg = <0x70000 0x4000 0x4070000 0x4000>;
+ interrupts = <0 187 0x4>;
+ };
+
+ bman-portal@80000 {
+ compatible = "fsl,bman-portal";
+ reg = <0x80000 0x4000 0x4080000 0x4000>;
+ interrupts = <0 189 0x4>;
+ };
+};
diff --git a/arch/arm64/boot/dts/freescale/qoriq-qman1-portals.dtsi b/arch/arm64/boot/dts/freescale/qoriq-qman1-portals.dtsi
new file mode 100644
index 0000000..4baec2c
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/qoriq-qman1-portals.dtsi
@@ -0,0 +1,76 @@
+/*
+ * QorIQ QMan Portals device tree
+ *
+ * Copyright 2011-2016 Freescale Semiconductor Inc.
+ *
+ * SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+ */
+
+&qportals {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "simple-bus";
+
+ qportal0: qman-portal@0 {
+ compatible = "fsl,qman-portal";
+ reg = <0x0 0x4000 0x4000000 0x4000>;
+ interrupts = <0 172 0x4>;
+ cell-index = <0>;
+ };
+
+ qportal1: qman-portal@10000 {
+ compatible = "fsl,qman-portal";
+ reg = <0x10000 0x4000 0x4010000 0x4000>;
+ interrupts = <0 174 0x4>;
+ cell-index = <1>;
+ };
+
+ qportal2: qman-portal@20000 {
+ compatible = "fsl,qman-portal";
+ reg = <0x20000 0x4000 0x4020000 0x4000>;
+ interrupts = <0 176 0x4>;
+ cell-index = <2>;
+ };
+
+ qportal3: qman-portal@30000 {
+ compatible = "fsl,qman-portal";
+ reg = <0x30000 0x4000 0x4030000 0x4000>;
+ interrupts = <0 178 0x4>;
+ cell-index = <3>;
+ };
+
+ qportal4: qman-portal@40000 {
+ compatible = "fsl,qman-portal";
+ reg = <0x40000 0x4000 0x4040000 0x4000>;
+ interrupts = <0 180 0x4>;
+ cell-index = <4>;
+ };
+
+ qportal5: qman-portal@50000 {
+ compatible = "fsl,qman-portal";
+ reg = <0x50000 0x4000 0x4050000 0x4000>;
+ interrupts = <0 182 0x4>;
+ cell-index = <5>;
+ };
+
+ qportal6: qman-portal@60000 {
+ compatible = "fsl,qman-portal";
+ reg = <0x60000 0x4000 0x4060000 0x4000>;
+ interrupts = <0 184 0x4>;
+ cell-index = <6>;
+ };
+
+ qportal7: qman-portal@70000 {
+ compatible = "fsl,qman-portal";
+ reg = <0x70000 0x4000 0x4070000 0x4000>;
+ interrupts = <0 186 0x4>;
+ cell-index = <7>;
+ };
+
+ qportal8: qman-portal@80000 {
+ compatible = "fsl,qman-portal";
+ reg = <0x80000 0x4000 0x4080000 0x4000>;
+ interrupts = <0 188 0x4>;
+ cell-index = <8>;
+ };
+};
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/3] dts: arm64: add LS1043A DPAA QBMan nodes
2017-03-30 14:37 [PATCH 0/3] introduce QorIQ DPAA 1.x QBMan device tree nodes Madalin Bucur
2017-03-30 14:37 ` [PATCH 1/3] dts: arm64: add DPAA QBMan portals Madalin Bucur
@ 2017-03-30 14:37 ` Madalin Bucur
2017-03-31 2:02 ` Shawn Guo
2017-03-30 14:37 ` [PATCH 3/3] dts: arm64: add LS1046A " Madalin Bucur
2 siblings, 1 reply; 10+ messages in thread
From: Madalin Bucur @ 2017-03-30 14:37 UTC (permalink / raw)
To: robh+dt, mark.rutland, devicetree
Cc: linux-arm-kernel, linux-kernel, catalin.marinas, will.deacon,
shawnguo, Gang.Liu, Madalin Bucur, Roy Pledge
Add the DPAA 1.x QMan and BMan nodes in the LS1043A device tree.
Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 52 ++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index ec13a6e..8434e89 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -106,6 +106,33 @@
/* DRAM space 1, size: 2GiB DRAM */
};
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ bman_fbpr: bman-fbpr {
+ compatible = "shared-dma-pool";
+ size = <0 0x1000000>;
+ alignment = <0 0x1000000>;
+ no-map;
+ };
+
+ qman_fqd: qman-fqd {
+ compatible = "shared-dma-pool";
+ size = <0 0x400000>;
+ alignment = <0 0x400000>;
+ no-map;
+ };
+
+ qman_pfdr: qman-pfdr {
+ compatible = "shared-dma-pool";
+ size = <0 0x2000000>;
+ alignment = <0 0x2000000>;
+ no-map;
+ };
+ };
+
sysclk: sysclk {
compatible = "fixed-clock";
#clock-cells = <0>;
@@ -333,6 +360,28 @@
};
};
+ qman: qman@1880000 {
+ compatible = "fsl,qman";
+ reg = <0x00 0x1880000 0x0 0x10000>;
+ interrupts = <0 45 0x4>;
+ memory-region = <&qman_fqd &qman_pfdr>;
+ };
+
+ bman: bman@1890000 {
+ compatible = "fsl,bman";
+ reg = <0x00 0x1890000 0x0 0x10000>;
+ interrupts = <0 45 0x4>;
+ memory-region = <&bman_fbpr>;
+ };
+
+ bportals: bman-portals@508000000 {
+ ranges = <0x0 0x5 0x08000000 0x8000000>;
+ };
+
+ qportals: qman-portals@500000000 {
+ ranges = <0x0 0x5 0x00000000 0x8000000>;
+ };
+
dspi0: dspi@2100000 {
compatible = "fsl,ls1043a-dspi", "fsl,ls1021a-v1.0-dspi";
#address-cells = <1>;
@@ -686,3 +735,6 @@
};
};
+
+#include "qoriq-qman1-portals.dtsi"
+#include "qoriq-bman1-portals.dtsi"
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/3] dts: arm64: add LS1046A DPAA QBMan nodes
2017-03-30 14:37 [PATCH 0/3] introduce QorIQ DPAA 1.x QBMan device tree nodes Madalin Bucur
2017-03-30 14:37 ` [PATCH 1/3] dts: arm64: add DPAA QBMan portals Madalin Bucur
2017-03-30 14:37 ` [PATCH 2/3] dts: arm64: add LS1043A DPAA QBMan nodes Madalin Bucur
@ 2017-03-30 14:37 ` Madalin Bucur
2017-03-31 2:29 ` Shawn Guo
2 siblings, 1 reply; 10+ messages in thread
From: Madalin Bucur @ 2017-03-30 14:37 UTC (permalink / raw)
To: robh+dt, mark.rutland, devicetree
Cc: linux-arm-kernel, linux-kernel, catalin.marinas, will.deacon,
shawnguo, Gang.Liu, Madalin Bucur, Roy Pledge
Add the QBMan device tree nodes for LS1046A devices.
Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 52 ++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 4a164b8..67e073a 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -268,6 +268,30 @@
};
};
+ qman: qman@1880000 {
+ compatible = "fsl,qman";
+ reg = <0x00 0x1880000 0x0 0x10000>;
+ interrupts = <0 45 0x4>;
+ memory-region = <&qman_fqd &qman_pfdr>;
+
+ };
+
+ bman: bman@1890000 {
+ compatible = "fsl,bman";
+ reg = <0x00 0x1890000 0x0 0x10000>;
+ interrupts = <0 45 0x4>;
+ memory-region = <&bman_fbpr>;
+
+ };
+
+ qportals: qman-portals@500000000 {
+ ranges = <0x0 0x5 0x00000000 0x8000000>;
+ };
+
+ bportals: bman-portals@508000000 {
+ ranges = <0x0 0x5 0x08000000 0x8000000>;
+ };
+
dcfg: dcfg@1ee0000 {
compatible = "fsl,ls1046a-dcfg", "syscon";
reg = <0x0 0x1ee0000 0x0 0x10000>;
@@ -592,4 +616,32 @@
clocks = <&clockgen 4 1>;
};
};
+
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ bman_fbpr: bman-fbpr {
+ compatible = "shared-dma-pool";
+ size = <0 0x1000000>;
+ alignment = <0 0x1000000>;
+ no-map;
+ };
+ qman_fqd: qman-fqd {
+ compatible = "shared-dma-pool";
+ size = <0 0x800000>;
+ alignment = <0 0x800000>;
+ no-map;
+ };
+ qman_pfdr: qman-pfdr {
+ compatible = "shared-dma-pool";
+ size = <0 0x2000000>;
+ alignment = <0 0x2000000>;
+ no-map;
+ };
+ };
};
+
+#include "qoriq-qman1-portals.dtsi"
+#include "qoriq-bman1-portals.dtsi"
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] dts: arm64: add DPAA QBMan portals
2017-03-30 14:37 ` [PATCH 1/3] dts: arm64: add DPAA QBMan portals Madalin Bucur
@ 2017-03-31 1:49 ` Shawn Guo
2017-05-12 14:14 ` Madalin-Cristian Bucur
0 siblings, 1 reply; 10+ messages in thread
From: Shawn Guo @ 2017-03-31 1:49 UTC (permalink / raw)
To: Madalin Bucur
Cc: robh+dt, mark.rutland, devicetree, Gang.Liu, catalin.marinas,
Roy Pledge, will.deacon, linux-kernel, linux-arm-kernel
On Thu, Mar 30, 2017 at 05:37:50PM +0300, Madalin Bucur wrote:
> Add the DPAA 1.x DPAA QMan and BMan portal nodes.
>
> Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
The patches should be prefixed like 'arm64: dts: ...'.
> ---
> .../boot/dts/freescale/qoriq-bman1-portals.dtsi | 67 +++++++++++++++++++
> .../boot/dts/freescale/qoriq-qman1-portals.dtsi | 76 ++++++++++++++++++++++
> 2 files changed, 143 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/qoriq-bman1-portals.dtsi
> create mode 100644 arch/arm64/boot/dts/freescale/qoriq-qman1-portals.dtsi
What does the suffix number '1' mean here?
>
> diff --git a/arch/arm64/boot/dts/freescale/qoriq-bman1-portals.dtsi b/arch/arm64/boot/dts/freescale/qoriq-bman1-portals.dtsi
> new file mode 100644
> index 0000000..b007344
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/qoriq-bman1-portals.dtsi
> @@ -0,0 +1,67 @@
> +/*
> + * QorIQ BMan Portals device tree
> + *
> + * Copyright 2011-2016 Freescale Semiconductor Inc.
> + *
> + * SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> + */
> +
> +&bportals {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "simple-bus";
> +
> + bman-portal@0 {
> + compatible = "fsl,bman-portal";
The bindings/soc/fsl/bman-portals.txt says: Must include
"fsl,bman-portal-<hardware revision>".
> + reg = <0x0 0x4000 0x4000000 0x4000>;
Can we write it in the same way how the example in the bindings doc
does?
reg = <0x0 0x4000>, <0x4000000 0x4000>;
It's more obvious to tell that it has two memory regions.
> + interrupts = <0 173 0x4>;
Can we use GIC_SPI and IRQ_TYPE_LEVEL_HIGH which are defined by
headers in include/dt-bindings/interrupt-controller/ to make it more
readable?
Shawn
> + };
> +
> + bman-portal@10000 {
> + compatible = "fsl,bman-portal";
> + reg = <0x10000 0x4000 0x4010000 0x4000>;
> + interrupts = <0 175 0x4>;
> + };
> +
> + bman-portal@20000 {
> + compatible = "fsl,bman-portal";
> + reg = <0x20000 0x4000 0x4020000 0x4000>;
> + interrupts = <0 177 0x4>;
> + };
> +
> + bman-portal@30000 {
> + compatible = "fsl,bman-portal";
> + reg = <0x30000 0x4000 0x4030000 0x4000>;
> + interrupts = <0 179 0x4>;
> + };
> +
> + bman-portal@40000 {
> + compatible = "fsl,bman-portal";
> + reg = <0x40000 0x4000 0x4040000 0x4000>;
> + interrupts = <0 181 0x4>;
> + };
> +
> + bman-portal@50000 {
> + compatible = "fsl,bman-portal";
> + reg = <0x50000 0x4000 0x4050000 0x4000>;
> + interrupts = <0 183 0x4>;
> + };
> +
> + bman-portal@60000 {
> + compatible = "fsl,bman-portal";
> + reg = <0x60000 0x4000 0x4060000 0x4000>;
> + interrupts = <0 185 0x4>;
> + };
> +
> + bman-portal@70000 {
> + compatible = "fsl,bman-portal";
> + reg = <0x70000 0x4000 0x4070000 0x4000>;
> + interrupts = <0 187 0x4>;
> + };
> +
> + bman-portal@80000 {
> + compatible = "fsl,bman-portal";
> + reg = <0x80000 0x4000 0x4080000 0x4000>;
> + interrupts = <0 189 0x4>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/freescale/qoriq-qman1-portals.dtsi b/arch/arm64/boot/dts/freescale/qoriq-qman1-portals.dtsi
> new file mode 100644
> index 0000000..4baec2c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/qoriq-qman1-portals.dtsi
> @@ -0,0 +1,76 @@
> +/*
> + * QorIQ QMan Portals device tree
> + *
> + * Copyright 2011-2016 Freescale Semiconductor Inc.
> + *
> + * SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> + */
> +
> +&qportals {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "simple-bus";
> +
> + qportal0: qman-portal@0 {
> + compatible = "fsl,qman-portal";
> + reg = <0x0 0x4000 0x4000000 0x4000>;
> + interrupts = <0 172 0x4>;
> + cell-index = <0>;
> + };
> +
> + qportal1: qman-portal@10000 {
> + compatible = "fsl,qman-portal";
> + reg = <0x10000 0x4000 0x4010000 0x4000>;
> + interrupts = <0 174 0x4>;
> + cell-index = <1>;
> + };
> +
> + qportal2: qman-portal@20000 {
> + compatible = "fsl,qman-portal";
> + reg = <0x20000 0x4000 0x4020000 0x4000>;
> + interrupts = <0 176 0x4>;
> + cell-index = <2>;
> + };
> +
> + qportal3: qman-portal@30000 {
> + compatible = "fsl,qman-portal";
> + reg = <0x30000 0x4000 0x4030000 0x4000>;
> + interrupts = <0 178 0x4>;
> + cell-index = <3>;
> + };
> +
> + qportal4: qman-portal@40000 {
> + compatible = "fsl,qman-portal";
> + reg = <0x40000 0x4000 0x4040000 0x4000>;
> + interrupts = <0 180 0x4>;
> + cell-index = <4>;
> + };
> +
> + qportal5: qman-portal@50000 {
> + compatible = "fsl,qman-portal";
> + reg = <0x50000 0x4000 0x4050000 0x4000>;
> + interrupts = <0 182 0x4>;
> + cell-index = <5>;
> + };
> +
> + qportal6: qman-portal@60000 {
> + compatible = "fsl,qman-portal";
> + reg = <0x60000 0x4000 0x4060000 0x4000>;
> + interrupts = <0 184 0x4>;
> + cell-index = <6>;
> + };
> +
> + qportal7: qman-portal@70000 {
> + compatible = "fsl,qman-portal";
> + reg = <0x70000 0x4000 0x4070000 0x4000>;
> + interrupts = <0 186 0x4>;
> + cell-index = <7>;
> + };
> +
> + qportal8: qman-portal@80000 {
> + compatible = "fsl,qman-portal";
> + reg = <0x80000 0x4000 0x4080000 0x4000>;
> + interrupts = <0 188 0x4>;
> + cell-index = <8>;
> + };
> +};
> --
> 2.1.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] dts: arm64: add LS1043A DPAA QBMan nodes
2017-03-30 14:37 ` [PATCH 2/3] dts: arm64: add LS1043A DPAA QBMan nodes Madalin Bucur
@ 2017-03-31 2:02 ` Shawn Guo
2017-05-12 14:14 ` Madalin-Cristian Bucur
0 siblings, 1 reply; 10+ messages in thread
From: Shawn Guo @ 2017-03-31 2:02 UTC (permalink / raw)
To: Madalin Bucur
Cc: robh+dt, mark.rutland, devicetree, linux-arm-kernel,
linux-kernel, catalin.marinas, will.deacon, Gang.Liu, Roy Pledge
On Thu, Mar 30, 2017 at 05:37:51PM +0300, Madalin Bucur wrote:
> Add the DPAA 1.x QMan and BMan nodes in the LS1043A device tree.
>
> Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 52 ++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index ec13a6e..8434e89 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -106,6 +106,33 @@
> /* DRAM space 1, size: 2GiB DRAM */
> };
>
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + bman_fbpr: bman-fbpr {
> + compatible = "shared-dma-pool";
> + size = <0 0x1000000>;
> + alignment = <0 0x1000000>;
> + no-map;
> + };
> +
> + qman_fqd: qman-fqd {
> + compatible = "shared-dma-pool";
> + size = <0 0x400000>;
> + alignment = <0 0x400000>;
> + no-map;
> + };
> +
> + qman_pfdr: qman-pfdr {
> + compatible = "shared-dma-pool";
> + size = <0 0x2000000>;
> + alignment = <0 0x2000000>;
> + no-map;
> + };
> + };
> +
> sysclk: sysclk {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> @@ -333,6 +360,28 @@
> };
> };
>
> + qman: qman@1880000 {
> + compatible = "fsl,qman";
> + reg = <0x00 0x1880000 0x0 0x10000>;
s/0x00/0x0?
Shawn
> + interrupts = <0 45 0x4>;
> + memory-region = <&qman_fqd &qman_pfdr>;
> + };
> +
> + bman: bman@1890000 {
> + compatible = "fsl,bman";
> + reg = <0x00 0x1890000 0x0 0x10000>;
> + interrupts = <0 45 0x4>;
> + memory-region = <&bman_fbpr>;
> + };
> +
> + bportals: bman-portals@508000000 {
> + ranges = <0x0 0x5 0x08000000 0x8000000>;
> + };
> +
> + qportals: qman-portals@500000000 {
> + ranges = <0x0 0x5 0x00000000 0x8000000>;
> + };
> +
> dspi0: dspi@2100000 {
> compatible = "fsl,ls1043a-dspi", "fsl,ls1021a-v1.0-dspi";
> #address-cells = <1>;
> @@ -686,3 +735,6 @@
> };
>
> };
> +
> +#include "qoriq-qman1-portals.dtsi"
> +#include "qoriq-bman1-portals.dtsi"
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] dts: arm64: add LS1046A DPAA QBMan nodes
2017-03-30 14:37 ` [PATCH 3/3] dts: arm64: add LS1046A " Madalin Bucur
@ 2017-03-31 2:29 ` Shawn Guo
2017-05-12 14:14 ` Madalin-Cristian Bucur
0 siblings, 1 reply; 10+ messages in thread
From: Shawn Guo @ 2017-03-31 2:29 UTC (permalink / raw)
To: Madalin Bucur
Cc: robh+dt, mark.rutland, devicetree, linux-arm-kernel,
linux-kernel, catalin.marinas, will.deacon, Gang.Liu, Roy Pledge
On Thu, Mar 30, 2017 at 05:37:52PM +0300, Madalin Bucur wrote:
> Add the QBMan device tree nodes for LS1046A devices.
>
> Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 52 ++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 4a164b8..67e073a 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -268,6 +268,30 @@
> };
> };
>
> + qman: qman@1880000 {
> + compatible = "fsl,qman";
> + reg = <0x00 0x1880000 0x0 0x10000>;
> + interrupts = <0 45 0x4>;
> + memory-region = <&qman_fqd &qman_pfdr>;
> +
> + };
> +
> + bman: bman@1890000 {
> + compatible = "fsl,bman";
> + reg = <0x00 0x1890000 0x0 0x10000>;
> + interrupts = <0 45 0x4>;
> + memory-region = <&bman_fbpr>;
> +
> + };
> +
> + qportals: qman-portals@500000000 {
> + ranges = <0x0 0x5 0x00000000 0x8000000>;
> + };
> +
> + bportals: bman-portals@508000000 {
> + ranges = <0x0 0x5 0x08000000 0x8000000>;
> + };
> +
> dcfg: dcfg@1ee0000 {
> compatible = "fsl,ls1046a-dcfg", "syscon";
> reg = <0x0 0x1ee0000 0x0 0x10000>;
> @@ -592,4 +616,32 @@
> clocks = <&clockgen 4 1>;
> };
> };
> +
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + bman_fbpr: bman-fbpr {
> + compatible = "shared-dma-pool";
> + size = <0 0x1000000>;
> + alignment = <0 0x1000000>;
> + no-map;
> + };
Please have a newline between nodes.
Shawn
> + qman_fqd: qman-fqd {
> + compatible = "shared-dma-pool";
> + size = <0 0x800000>;
> + alignment = <0 0x800000>;
> + no-map;
> + };
> + qman_pfdr: qman-pfdr {
> + compatible = "shared-dma-pool";
> + size = <0 0x2000000>;
> + alignment = <0 0x2000000>;
> + no-map;
> + };
> + };
> };
> +
> +#include "qoriq-qman1-portals.dtsi"
> +#include "qoriq-bman1-portals.dtsi"
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 1/3] dts: arm64: add DPAA QBMan portals
2017-03-31 1:49 ` Shawn Guo
@ 2017-05-12 14:14 ` Madalin-Cristian Bucur
0 siblings, 0 replies; 10+ messages in thread
From: Madalin-Cristian Bucur @ 2017-05-12 14:14 UTC (permalink / raw)
To: Shawn Guo
Cc: robh+dt, mark.rutland, devicetree, Gang Liu, catalin.marinas,
Roy Pledge, will.deacon, linux-kernel, linux-arm-kernel
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Friday, March 31, 2017 4:50 AM
> On Thu, Mar 30, 2017 at 05:37:50PM +0300, Madalin Bucur wrote:
> > Add the DPAA 1.x DPAA QMan and BMan portal nodes.
> >
> > Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
> > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
>
> The patches should be prefixed like 'arm64: dts: ...'.
>
> > ---
> > .../boot/dts/freescale/qoriq-bman1-portals.dtsi | 67
> +++++++++++++++++++
> > .../boot/dts/freescale/qoriq-qman1-portals.dtsi | 76
> ++++++++++++++++++++++
> > 2 files changed, 143 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/freescale/qoriq-bman1-
> portals.dtsi
> > create mode 100644 arch/arm64/boot/dts/freescale/qoriq-qman1-
> portals.dtsi
>
> What does the suffix number '1' mean here?
Will be removed, was used to differentiate between different revisions
on PPC, inherited from there.
> >
> > diff --git a/arch/arm64/boot/dts/freescale/qoriq-bman1-portals.dtsi
> b/arch/arm64/boot/dts/freescale/qoriq-bman1-portals.dtsi
> > new file mode 100644
> > index 0000000..b007344
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/qoriq-bman1-portals.dtsi
> > @@ -0,0 +1,67 @@
> > +/*
> > + * QorIQ BMan Portals device tree
> > + *
> > + * Copyright 2011-2016 Freescale Semiconductor Inc.
> > + *
> > + * SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> > + */
> > +
> > +&bportals {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "simple-bus";
> > +
> > + bman-portal@0 {
> > + compatible = "fsl,bman-portal";
>
> The bindings/soc/fsl/bman-portals.txt says: Must include
> "fsl,bman-portal-<hardware revision>".
This is satisfied by device tree fix-ups performed by the bootloader
adding the correct version. I'll introduce a comment about this here.
> > + reg = <0x0 0x4000 0x4000000 0x4000>;
>
> Can we write it in the same way how the example in the bindings doc
> does?
>
> reg = <0x0 0x4000>, <0x4000000 0x4000>;
>
> It's more obvious to tell that it has two memory regions.
Will change that.
> > + interrupts = <0 173 0x4>;
>
> Can we use GIC_SPI and IRQ_TYPE_LEVEL_HIGH which are defined by
> headers in include/dt-bindings/interrupt-controller/ to make it more
> readable?
Yes, done.
> Shawn
<snip>
Thanks,
Madalin
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 2/3] dts: arm64: add LS1043A DPAA QBMan nodes
2017-03-31 2:02 ` Shawn Guo
@ 2017-05-12 14:14 ` Madalin-Cristian Bucur
0 siblings, 0 replies; 10+ messages in thread
From: Madalin-Cristian Bucur @ 2017-05-12 14:14 UTC (permalink / raw)
To: Shawn Guo
Cc: robh+dt, mark.rutland, devicetree, linux-arm-kernel,
linux-kernel, catalin.marinas, will.deacon, Gang Liu, Roy Pledge
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> On Thu, Mar 30, 2017 at 05:37:51PM +0300, Madalin Bucur wrote:
> > Add the DPAA 1.x QMan and BMan nodes in the LS1043A device tree.
> >
> > Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
> > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 52
> ++++++++++++++++++++++++++
> > 1 file changed, 52 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> > index ec13a6e..8434e89 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> > @@ -106,6 +106,33 @@
> > /* DRAM space 1, size: 2GiB DRAM */
> > };
> >
> > + reserved-memory {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges;
> > +
> > + bman_fbpr: bman-fbpr {
> > + compatible = "shared-dma-pool";
> > + size = <0 0x1000000>;
> > + alignment = <0 0x1000000>;
> > + no-map;
> > + };
> > +
> > + qman_fqd: qman-fqd {
> > + compatible = "shared-dma-pool";
> > + size = <0 0x400000>;
> > + alignment = <0 0x400000>;
> > + no-map;
> > + };
> > +
> > + qman_pfdr: qman-pfdr {
> > + compatible = "shared-dma-pool";
> > + size = <0 0x2000000>;
> > + alignment = <0 0x2000000>;
> > + no-map;
> > + };
> > + };
> > +
> > sysclk: sysclk {
> > compatible = "fixed-clock";
> > #clock-cells = <0>;
> > @@ -333,6 +360,28 @@
> > };
> > };
> >
> > + qman: qman@1880000 {
> > + compatible = "fsl,qman";
> > + reg = <0x00 0x1880000 0x0 0x10000>;
>
> s/0x00/0x0?
>
> Shawn
Yes, fixed all new introduced occurrences.
> > + interrupts = <0 45 0x4>;
> > + memory-region = <&qman_fqd &qman_pfdr>;
> > + };
> > +
> > + bman: bman@1890000 {
> > + compatible = "fsl,bman";
> > + reg = <0x00 0x1890000 0x0 0x10000>;
> > + interrupts = <0 45 0x4>;
> > + memory-region = <&bman_fbpr>;
> > + };
> > +
> > + bportals: bman-portals@508000000 {
> > + ranges = <0x0 0x5 0x08000000 0x8000000>;
> > + };
> > +
> > + qportals: qman-portals@500000000 {
> > + ranges = <0x0 0x5 0x00000000 0x8000000>;
> > + };
> > +
> > dspi0: dspi@2100000 {
> > compatible = "fsl,ls1043a-dspi", "fsl,ls1021a-v1.0-
> dspi";
> > #address-cells = <1>;
> > @@ -686,3 +735,6 @@
> > };
> >
> > };
> > +
> > +#include "qoriq-qman1-portals.dtsi"
> > +#include "qoriq-bman1-portals.dtsi"
> > --
> > 2.1.0
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 3/3] dts: arm64: add LS1046A DPAA QBMan nodes
2017-03-31 2:29 ` Shawn Guo
@ 2017-05-12 14:14 ` Madalin-Cristian Bucur
0 siblings, 0 replies; 10+ messages in thread
From: Madalin-Cristian Bucur @ 2017-05-12 14:14 UTC (permalink / raw)
To: Shawn Guo
Cc: robh+dt, mark.rutland, devicetree, linux-arm-kernel,
linux-kernel, catalin.marinas, will.deacon, Gang Liu, Roy Pledge
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Friday, March 31, 2017 5:30 AM
> On Thu, Mar 30, 2017 at 05:37:52PM +0300, Madalin Bucur wrote:
> > Add the QBMan device tree nodes for LS1046A devices.
> >
> > Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
> > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 52
> ++++++++++++++++++++++++++
> > 1 file changed, 52 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > index 4a164b8..67e073a 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > @@ -268,6 +268,30 @@
> > };
> > };
> >
> > + qman: qman@1880000 {
> > + compatible = "fsl,qman";
> > + reg = <0x00 0x1880000 0x0 0x10000>;
> > + interrupts = <0 45 0x4>;
> > + memory-region = <&qman_fqd &qman_pfdr>;
> > +
> > + };
> > +
> > + bman: bman@1890000 {
> > + compatible = "fsl,bman";
> > + reg = <0x00 0x1890000 0x0 0x10000>;
> > + interrupts = <0 45 0x4>;
> > + memory-region = <&bman_fbpr>;
> > +
> > + };
> > +
> > + qportals: qman-portals@500000000 {
> > + ranges = <0x0 0x5 0x00000000 0x8000000>;
> > + };
> > +
> > + bportals: bman-portals@508000000 {
> > + ranges = <0x0 0x5 0x08000000 0x8000000>;
> > + };
> > +
> > dcfg: dcfg@1ee0000 {
> > compatible = "fsl,ls1046a-dcfg", "syscon";
> > reg = <0x0 0x1ee0000 0x0 0x10000>;
> > @@ -592,4 +616,32 @@
> > clocks = <&clockgen 4 1>;
> > };
> > };
> > +
> > + reserved-memory {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges;
> > +
> > + bman_fbpr: bman-fbpr {
> > + compatible = "shared-dma-pool";
> > + size = <0 0x1000000>;
> > + alignment = <0 0x1000000>;
> > + no-map;
> > + };
>
> Please have a newline between nodes.
>
> Shawn
Done.
> > + qman_fqd: qman-fqd {
> > + compatible = "shared-dma-pool";
> > + size = <0 0x800000>;
> > + alignment = <0 0x800000>;
> > + no-map;
> > + };
> > + qman_pfdr: qman-pfdr {
> > + compatible = "shared-dma-pool";
> > + size = <0 0x2000000>;
> > + alignment = <0 0x2000000>;
> > + no-map;
> > + };
> > + };
> > };
> > +
> > +#include "qoriq-qman1-portals.dtsi"
> > +#include "qoriq-bman1-portals.dtsi"
> > --
> > 2.1.0
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-05-12 14:14 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-30 14:37 [PATCH 0/3] introduce QorIQ DPAA 1.x QBMan device tree nodes Madalin Bucur
2017-03-30 14:37 ` [PATCH 1/3] dts: arm64: add DPAA QBMan portals Madalin Bucur
2017-03-31 1:49 ` Shawn Guo
2017-05-12 14:14 ` Madalin-Cristian Bucur
2017-03-30 14:37 ` [PATCH 2/3] dts: arm64: add LS1043A DPAA QBMan nodes Madalin Bucur
2017-03-31 2:02 ` Shawn Guo
2017-05-12 14:14 ` Madalin-Cristian Bucur
2017-03-30 14:37 ` [PATCH 3/3] dts: arm64: add LS1046A " Madalin Bucur
2017-03-31 2:29 ` Shawn Guo
2017-05-12 14:14 ` Madalin-Cristian Bucur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).