From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 1/3] clocksource: Augment bindings for Faraday timer
Date: Fri, 7 Apr 2017 15:41:49 +0200 [thread overview]
Message-ID: <20170407134149.GJ2078@mai> (raw)
In-Reply-To: <20170324213235.16119-1-linus.walleij@linaro.org>
On Fri, Mar 24, 2017 at 10:32:33PM +0100, Linus Walleij wrote:
> It turns out that the Cortina Gemini timer block is just a
> standard IP block from Faraday Technology named FTTMR010.
>
> In order to make things clear and understandable, we rename the
> bindings with a Faraday compatible as primary and the Cortina
> gemini as a more specific case.
>
> For the plain Faraday timer we require two clock references,
> while the Gemini can keep it's syscon lookup pattern.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
Rob ? Is this change ok for you?
Thanks.
-- Daniel
> .../bindings/timer/cortina,gemini-timer.txt | 22 ---------------
> .../devicetree/bindings/timer/faraday,fttmr010.txt | 33 ++++++++++++++++++++++
> 2 files changed, 33 insertions(+), 22 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt
> create mode 100644 Documentation/devicetree/bindings/timer/faraday,fttmr010.txt
>
> diff --git a/Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt b/Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt
> deleted file mode 100644
> index 16ea1d3b2e9e..000000000000
> --- a/Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -Cortina Systems Gemini timer
> -
> -This timer is embedded in the Cortina Systems Gemini SoCs.
> -
> -Required properties:
> -
> -- compatible : Must be "cortina,gemini-timer"
> -- reg : Should contain registers location and length
> -- interrupts : Should contain the three timer interrupts with
> - flags for rising edge
> -- syscon : a phandle to the global Gemini system controller
> -
> -Example:
> -
> -timer@43000000 {
> - compatible = "cortina,gemini-timer";
> - reg = <0x43000000 0x1000>;
> - interrupts = <14 IRQ_TYPE_EDGE_RISING>, /* Timer 1 */
> - <15 IRQ_TYPE_EDGE_RISING>, /* Timer 2 */
> - <16 IRQ_TYPE_EDGE_RISING>; /* Timer 3 */
> - syscon = <&syscon>;
> -};
> diff --git a/Documentation/devicetree/bindings/timer/faraday,fttmr010.txt b/Documentation/devicetree/bindings/timer/faraday,fttmr010.txt
> new file mode 100644
> index 000000000000..b73ca6cd07f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/faraday,fttmr010.txt
> @@ -0,0 +1,33 @@
> +Faraday Technology timer
> +
> +This timer is a generic IP block from Faraday Technology, embedded in the
> +Cortina Systems Gemini SoCs and other designs.
> +
> +Required properties:
> +
> +- compatible : Must be one of
> + "faraday,fttmr010"
> + "cortina,gemini-timer"
> +- reg : Should contain registers location and length
> +- interrupts : Should contain the three timer interrupts usually with
> + flags for falling edge
> +
> +Optionally required properties:
> +
> +- clocks : a clock to provide the tick rate for "faraday,fttmr010"
> +- clock-names : should be "EXTCLK" and "PCLK" for the external tick timer
> + and peripheral clock respectively, for "faraday,fttmr010"
> +- syscon : a phandle to the global Gemini system controller if the compatible
> + type is "cortina,gemini-timer"
> +
> +Example:
> +
> +timer@43000000 {
> + compatible = "faraday,fttmr010";
> + reg = <0x43000000 0x1000>;
> + interrupts = <14 IRQ_TYPE_EDGE_FALLING>, /* Timer 1 */
> + <15 IRQ_TYPE_EDGE_FALLING>, /* Timer 2 */
> + <16 IRQ_TYPE_EDGE_FALLING>; /* Timer 3 */
> + clocks = <&extclk>, <&pclk>;
> + clock-names = "EXTCLK", "PCLK";
> +};
> --
> 2.9.3
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2017-04-07 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 21:32 [PATCH 1/3] clocksource: Augment bindings for Faraday timer Linus Walleij
2017-03-24 21:32 ` [PATCH 2/3] clocksource: rename Gemini timer to Faraday Linus Walleij
2017-03-24 21:32 ` [PATCH 3/3] clocksource: fttmr010: refactor to handle clock Linus Walleij
2017-04-07 13:41 ` Daniel Lezcano [this message]
2017-04-07 14:27 ` [PATCH 1/3] clocksource: Augment bindings for Faraday timer Rob Herring
2017-04-07 21:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407134149.GJ2078@mai \
--to=daniel.lezcano@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).