* [PATCH][-next] nfp: don't dereference a null nn->eth_port to print a warning
@ 2017-04-06 12:54 Colin King
2017-04-06 23:15 ` Jakub Kicinski
2017-04-08 15:14 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-04-06 12:54 UTC (permalink / raw)
To: Jakub Kicinski, David S . Miller, Simon Horman, oss-drivers, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
On the case where nn->eth_port is null the warning message
is printing the port by dereferencing this null pointer.
Remove the deference to avoid a crash when printing the
warning message.
Detected by CoverityScan, CID#1426198 ("Dereference after null check")
Fixes: ce22f5a2cbe3c627 ("nfp: separate high level and low level NSP headers")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c
index 3e1f97e88710..4c6863a072d3 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c
@@ -495,8 +495,7 @@ static void nfp_net_refresh_netdevs(struct work_struct *work)
list_for_each_entry_safe(nn, next, &pf->ports, port_list) {
if (!nn->eth_port) {
- nfp_warn(pf->cpp, "Warning: port %d not present after reconfig\n",
- nn->eth_port->eth_index);
+ nfp_warn(pf->cpp, "Warning: port not present after reconfig\n");
continue;
}
if (!nn->eth_port->override_changed)
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][-next] nfp: don't dereference a null nn->eth_port to print a warning
2017-04-06 12:54 [PATCH][-next] nfp: don't dereference a null nn->eth_port to print a warning Colin King
@ 2017-04-06 23:15 ` Jakub Kicinski
2017-04-08 15:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2017-04-06 23:15 UTC (permalink / raw)
To: Colin King
Cc: David S . Miller, Simon Horman, oss-drivers, netdev,
kernel-janitors, linux-kernel
On Thu, 6 Apr 2017 13:54:35 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> On the case where nn->eth_port is null the warning message
> is printing the port by dereferencing this null pointer.
> Remove the deference to avoid a crash when printing the
> warning message.
>
> Detected by CoverityScan, CID#1426198 ("Dereference after null check")
>
> Fixes: ce22f5a2cbe3c627 ("nfp: separate high level and low level NSP headers")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][-next] nfp: don't dereference a null nn->eth_port to print a warning
2017-04-06 12:54 [PATCH][-next] nfp: don't dereference a null nn->eth_port to print a warning Colin King
2017-04-06 23:15 ` Jakub Kicinski
@ 2017-04-08 15:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-04-08 15:14 UTC (permalink / raw)
To: colin.king
Cc: jakub.kicinski, simon.horman, oss-drivers, netdev,
kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 6 Apr 2017 13:54:35 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> On the case where nn->eth_port is null the warning message
> is printing the port by dereferencing this null pointer.
> Remove the deference to avoid a crash when printing the
> warning message.
>
> Detected by CoverityScan, CID#1426198 ("Dereference after null check")
>
> Fixes: ce22f5a2cbe3c627 ("nfp: separate high level and low level NSP headers")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-08 15:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-06 12:54 [PATCH][-next] nfp: don't dereference a null nn->eth_port to print a warning Colin King
2017-04-06 23:15 ` Jakub Kicinski
2017-04-08 15:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).