linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] reset: hi6220: Set module license so that it can be loaded
@ 2017-04-08  7:18 Jeremy Linton
  2017-04-10  2:07 ` Xinliang Liu
  2017-04-10  9:03 ` Philipp Zabel
  0 siblings, 2 replies; 3+ messages in thread
From: Jeremy Linton @ 2017-04-08  7:18 UTC (permalink / raw)
  To: linux-kernel
  Cc: p.zabel, saberlily.xia, puck.chen, xinliang.liu, Jeremy Linton

The hi6220_reset driver can be built as a standalone module
yet it cannot be loaded because it depends on GPL exported symbols.

Lets set the module license so that the module loads, and things like
the on-board kirin drm starts working.

Signed-off-by: Jeremy Linton <lintonrjeremy@gmail.com>
---
 drivers/reset/hisilicon/hi6220_reset.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
index 35ce53e..d5e5229 100644
--- a/drivers/reset/hisilicon/hi6220_reset.c
+++ b/drivers/reset/hisilicon/hi6220_reset.c
@@ -155,3 +155,5 @@ static int __init hi6220_reset_init(void)
 }
 
 postcore_initcall(hi6220_reset_init);
+
+MODULE_LICENSE("GPL v2");
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] reset: hi6220: Set module license so that it can be loaded
  2017-04-08  7:18 [PATCH] reset: hi6220: Set module license so that it can be loaded Jeremy Linton
@ 2017-04-10  2:07 ` Xinliang Liu
  2017-04-10  9:03 ` Philipp Zabel
  1 sibling, 0 replies; 3+ messages in thread
From: Xinliang Liu @ 2017-04-10  2:07 UTC (permalink / raw)
  To: Jeremy Linton
  Cc: Linux Kernel Mailing List, Philipp Zabel, Xia Qing, Feng Chen

On 8 April 2017 at 15:18, Jeremy Linton <lintonrjeremy@gmail.com> wrote:
> The hi6220_reset driver can be built as a standalone module
> yet it cannot be loaded because it depends on GPL exported symbols.
>
> Lets set the module license so that the module loads, and things like
> the on-board kirin drm starts working.
>
> Signed-off-by: Jeremy Linton <lintonrjeremy@gmail.com>

reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>

Thanks,
-xinliang

> ---
>  drivers/reset/hisilicon/hi6220_reset.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
> index 35ce53e..d5e5229 100644
> --- a/drivers/reset/hisilicon/hi6220_reset.c
> +++ b/drivers/reset/hisilicon/hi6220_reset.c
> @@ -155,3 +155,5 @@ static int __init hi6220_reset_init(void)
>  }
>
>  postcore_initcall(hi6220_reset_init);
> +
> +MODULE_LICENSE("GPL v2");
> --
> 2.10.2
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] reset: hi6220: Set module license so that it can be loaded
  2017-04-08  7:18 [PATCH] reset: hi6220: Set module license so that it can be loaded Jeremy Linton
  2017-04-10  2:07 ` Xinliang Liu
@ 2017-04-10  9:03 ` Philipp Zabel
  1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2017-04-10  9:03 UTC (permalink / raw)
  To: Jeremy Linton; +Cc: linux-kernel, saberlily.xia, puck.chen, xinliang.liu

On Sat, 2017-04-08 at 02:18 -0500, Jeremy Linton wrote:
> The hi6220_reset driver can be built as a standalone module
> yet it cannot be loaded because it depends on GPL exported symbols.
> 
> Lets set the module license so that the module loads, and things like
> the on-board kirin drm starts working.
> 
> Signed-off-by: Jeremy Linton <lintonrjeremy@gmail.com>
> ---
>  drivers/reset/hisilicon/hi6220_reset.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
> index 35ce53e..d5e5229 100644
> --- a/drivers/reset/hisilicon/hi6220_reset.c
> +++ b/drivers/reset/hisilicon/hi6220_reset.c
> @@ -155,3 +155,5 @@ static int __init hi6220_reset_init(void)
>  }
>  
>  postcore_initcall(hi6220_reset_init);
> +
> +MODULE_LICENSE("GPL v2");

Applied, thanks.

regards
Philipp

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-04-10  9:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-08  7:18 [PATCH] reset: hi6220: Set module license so that it can be loaded Jeremy Linton
2017-04-10  2:07 ` Xinliang Liu
2017-04-10  9:03 ` Philipp Zabel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).