* [PATCH] power: supply: lp8788: add missing comma between literal strings
@ 2017-04-07 23:33 Colin King
2017-04-11 14:47 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-04-07 23:33 UTC (permalink / raw)
To: Milo Kim, Sebastian Reichel, linux-pm; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a missing comma between the last two literal strings in
array stime, so add it in.
Detected by PVS-Studio, warning: V653
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/power/supply/lp8788-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c
index 509e2b341bd6..677f7c40b25a 100644
--- a/drivers/power/supply/lp8788-charger.c
+++ b/drivers/power/supply/lp8788-charger.c
@@ -651,7 +651,7 @@ static ssize_t lp8788_show_eoc_time(struct device *dev,
{
struct lp8788_charger *pchg = dev_get_drvdata(dev);
char *stime[] = { "400ms", "5min", "10min", "15min",
- "20min", "25min", "30min" "No timeout" };
+ "20min", "25min", "30min", "No timeout" };
u8 val;
lp8788_read_byte(pchg->lp, LP8788_CHG_EOC, &val);
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: supply: lp8788: add missing comma between literal strings
2017-04-07 23:33 [PATCH] power: supply: lp8788: add missing comma between literal strings Colin King
@ 2017-04-11 14:47 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2017-04-11 14:47 UTC (permalink / raw)
To: Colin King; +Cc: Milo Kim, linux-pm, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
Hi,
On Sat, Apr 08, 2017 at 12:33:36AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a missing comma between the last two literal strings in
> array stime, so add it in.
>
> Detected by PVS-Studio, warning: V653
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Giedrius Statkevičius sent this patch two weeks ago, I
already applied his patch.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-11 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-07 23:33 [PATCH] power: supply: lp8788: add missing comma between literal strings Colin King
2017-04-11 14:47 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).