From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
dietmar.eggemann@arm.com, Morten.Rasmussen@arm.com,
yuyang.du@intel.com, pjt@google.com, bsegall@google.com
Subject: Re: [PATCH v2] sched/fair: update scale invariance of PELT
Date: Wed, 12 Apr 2017 17:44:47 +0200 [thread overview]
Message-ID: <20170412154447.coqnzhlhimz5pc3l@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170412145047.GA19363@linaro.org>
On Wed, Apr 12, 2017 at 04:50:47PM +0200, Vincent Guittot wrote:
> Le Wednesday 12 Apr 2017 à 13:28:58 (+0200), Peter Zijlstra a écrit :
> >
> > |---------|---------| (wall-time)
> > ----****------------- F=100%
> > ----******----------- F= 66%
> > |--------------|----| (fudge-time)
>
> It has been a bit hard for me to catch the diagram above because you scale the
> idle time to get same ratio at 100% and 66% wherease I don't scale idle
> time but only running time.
Ah, so below I wrote that we then scale each window back to equal size,
so the absolute size in wall-time becomes immaterial.
> > (explicitly not used 50%, because then the second window would have
> > collapsed to 0, imagine the joy if you go lower still)
>
> The second window can't collapse because we are working on delta time not
> absolute wall-time and the delta is for only 1 type at a time: running or idle
Right, but consider what happens when F drops too low, idle goes away
from where there would've been some at F=1. At that point things become
unrecoverable afaict.
> > So in fudge-time the first window has 6/15 == 4/10 for the max-freq /
> > wall-time combo.
> >
> > >
> > > Then l = p' - p''. The lost idle time is tracked to apply the same amount of decay
> > > window when the task is sleeping
> > >
> > > so at the end we have a number of decay window of p''+l = p'' so we still have
> > > the same amount of decay window than previously.
> >
> > Now, we have to stretch time back to equal window size, and while you do
> > that for the active windows, we have to do manual compensation for idle
> > windows (which is somewhat ugleh) and is where the lost-time comes from.
>
> We can't stretch idle time because there is no relation between the idle time
> and the current capacity.
Brain melts..
> > Also, this all feels entirely yucky, because as per the above, if we'd
> > ran at 33%, we'd have ended up with a negative time window.
>
> Not sure to catch how we can end up with negative window. We are working with
> delta time not absolute time.
|---------|---------|---------| F=100%
--****------------------------
|--------------|----|---------| F= 66%
--******----------------------
|-------------------|---------| F= 50%
--********--------------------
|-----------------------------| F= 33%
--************----------------
So what happens is that when the (wall) time for a window goes negative
it simply moves the next window along, until that too is compressed
etc..
So in the above figure, the right most edge of F=33% contains 2 whole
periods of idle time, both contracted to measure 0 (wall) time.
The only thing you have to recover them from is the lost idle time
measure.
> > Not to mention that this only seems to work for low utilization. Once
> > you hit higher utilization scenarios, where there isn't much idle time
> > to compensate for the stretching, things go wobbly. Although both
> > scenarios might end up being the same.
>
> During the running phase, we calculate how much idle time has diseappeared
> because we are running at lower frequency and we compensate it once back to
> idle.
>
> >
> > And instead of resurrecting 0 sized windows, you throw them out, which
>
> I don't catch point above
It might've been slightly inaccurate. But the point remains that you
destroy time. Not all accrued lost idle time is recovered.
+ if (sa->util_sum < (LOAD_AVG_MAX * 1000)) {
+ /*
+ * Add the idle time stolen by running at lower compute
+ * capacity
+ */
+ delta += sa->stolen_idle_time;
+ }
+ sa->stolen_idle_time = 0;
See here, stolen_idle_time is reset regardless. Time is non-continuous
at that point.
I still have to draw me more interesting cases, I'm not convinced I
fully understand things.
next prev parent reply other threads:[~2017-04-12 15:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 9:18 [PATCH v2] sched/fair: update scale invariance of PELT Vincent Guittot
2017-04-10 17:38 ` Peter Zijlstra
2017-04-11 7:52 ` Vincent Guittot
2017-04-11 8:53 ` Peter Zijlstra
2017-04-11 9:40 ` Vincent Guittot
2017-04-11 10:41 ` Peter Zijlstra
2017-04-11 10:49 ` Peter Zijlstra
2017-04-11 13:09 ` Vincent Guittot
2017-04-12 11:28 ` Peter Zijlstra
2017-04-12 14:50 ` Vincent Guittot
2017-04-12 15:44 ` Peter Zijlstra [this message]
2017-04-13 9:42 ` Vincent Guittot
2017-04-13 13:32 ` Peter Zijlstra
2017-04-13 14:59 ` Vincent Guittot
2017-04-13 18:06 ` Peter Zijlstra
2017-04-14 8:47 ` Vincent Guittot
2017-04-11 12:08 ` Vincent Guittot
2017-04-11 9:12 ` Peter Zijlstra
2017-04-11 9:46 ` Vincent Guittot
2017-04-13 13:39 ` Peter Zijlstra
2017-04-13 15:16 ` Vincent Guittot
2017-04-13 16:13 ` Peter Zijlstra
2017-04-14 8:49 ` Vincent Guittot
2017-04-19 16:31 ` Vincent Guittot
2017-04-28 15:52 ` Morten Rasmussen
2017-04-28 17:08 ` Dietmar Eggemann
2017-05-03 17:11 ` Vincent Guittot
2017-04-28 22:09 ` Peter Zijlstra
2017-05-01 9:00 ` Peter Zijlstra
2017-05-02 13:38 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412154447.coqnzhlhimz5pc3l@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Morten.Rasmussen@arm.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pjt@google.com \
--cc=vincent.guittot@linaro.org \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).