* [PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias
@ 2017-04-11 1:01 Jarod Wilson
2017-04-11 4:40 ` Alex Williamson
2017-04-12 17:33 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Jarod Wilson @ 2017-04-11 1:01 UTC (permalink / raw)
To: linux-kernel; +Cc: Jarod Wilson, linux-pci, Alex Williamson, Bjorn Helgaas
This bridge has the same problems as the ITE 8892, which were resulting in
crippling an older PCI 1Gbps NIC down to 45Mbps throughput with IOMMU and
VT-d enabled. With the patch, this old e1000 goes back up to ~900Mbps.
Suggested-by: Alex Williamson <alex.williamson@redhat.com>
CC: linux-pci@vger.kernel.org
CC: Alex Williamson <alex.williamson@redhat.com>
CC: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
drivers/pci/quirks.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 9236e40ac055..c95fbf2431f8 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3914,6 +3914,8 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ASMEDIA, 0x1080,
DECLARE_PCI_FIXUP_HEADER(0x10e3, 0x8113, quirk_use_pcie_bridge_dma_alias);
/* ITE 8892, https://bugzilla.kernel.org/show_bug.cgi?id=73551 */
DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8892, quirk_use_pcie_bridge_dma_alias);
+/* ITE 8893 has the same problem as the 8892 */
+DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8893, quirk_use_pcie_bridge_dma_alias);
/* Intel 82801, https://bugzilla.kernel.org/show_bug.cgi?id=44881#c49 */
DECLARE_PCI_FIXUP_HEADER(0x8086, 0x244e, quirk_use_pcie_bridge_dma_alias);
--
2.12.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias
2017-04-11 1:01 [PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias Jarod Wilson
@ 2017-04-11 4:40 ` Alex Williamson
2017-04-12 17:33 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2017-04-11 4:40 UTC (permalink / raw)
To: Jarod Wilson; +Cc: linux-kernel, linux-pci, Bjorn Helgaas
On Mon, 10 Apr 2017 21:01:27 -0400
Jarod Wilson <jarod@redhat.com> wrote:
> This bridge has the same problems as the ITE 8892, which were resulting in
> crippling an older PCI 1Gbps NIC down to 45Mbps throughput with IOMMU and
> VT-d enabled. With the patch, this old e1000 goes back up to ~900Mbps.
>
> Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> CC: linux-pci@vger.kernel.org
> CC: Alex Williamson <alex.williamson@redhat.com>
> CC: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> ---
> drivers/pci/quirks.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 9236e40ac055..c95fbf2431f8 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3914,6 +3914,8 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ASMEDIA, 0x1080,
> DECLARE_PCI_FIXUP_HEADER(0x10e3, 0x8113, quirk_use_pcie_bridge_dma_alias);
> /* ITE 8892, https://bugzilla.kernel.org/show_bug.cgi?id=73551 */
> DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8892, quirk_use_pcie_bridge_dma_alias);
> +/* ITE 8893 has the same problem as the 8892 */
> +DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8893, quirk_use_pcie_bridge_dma_alias);
> /* Intel 82801, https://bugzilla.kernel.org/show_bug.cgi?id=44881#c49 */
> DECLARE_PCI_FIXUP_HEADER(0x8086, 0x244e, quirk_use_pcie_bridge_dma_alias);
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias
2017-04-11 1:01 [PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias Jarod Wilson
2017-04-11 4:40 ` Alex Williamson
@ 2017-04-12 17:33 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2017-04-12 17:33 UTC (permalink / raw)
To: Jarod Wilson; +Cc: linux-kernel, linux-pci, Alex Williamson, Bjorn Helgaas
On Mon, Apr 10, 2017 at 09:01:27PM -0400, Jarod Wilson wrote:
> This bridge has the same problems as the ITE 8892, which were resulting in
> crippling an older PCI 1Gbps NIC down to 45Mbps throughput with IOMMU and
> VT-d enabled. With the patch, this old e1000 goes back up to ~900Mbps.
>
> Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> CC: linux-pci@vger.kernel.org
> CC: Alex Williamson <alex.williamson@redhat.com>
> CC: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
Applied with Alex's reviewed-by to pci/iommu for v4.12, thanks!
> ---
> drivers/pci/quirks.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 9236e40ac055..c95fbf2431f8 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3914,6 +3914,8 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ASMEDIA, 0x1080,
> DECLARE_PCI_FIXUP_HEADER(0x10e3, 0x8113, quirk_use_pcie_bridge_dma_alias);
> /* ITE 8892, https://bugzilla.kernel.org/show_bug.cgi?id=73551 */
> DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8892, quirk_use_pcie_bridge_dma_alias);
> +/* ITE 8893 has the same problem as the 8892 */
> +DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8893, quirk_use_pcie_bridge_dma_alias);
> /* Intel 82801, https://bugzilla.kernel.org/show_bug.cgi?id=44881#c49 */
> DECLARE_PCI_FIXUP_HEADER(0x8086, 0x244e, quirk_use_pcie_bridge_dma_alias);
>
> --
> 2.12.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-12 17:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-11 1:01 [PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias Jarod Wilson
2017-04-11 4:40 ` Alex Williamson
2017-04-12 17:33 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).