* [PATCH nf-next] ip_vs_sync: change comparison on sync_refresh_period
@ 2017-04-12 20:38 Aaron Conole
2017-04-12 22:48 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Aaron Conole @ 2017-04-12 20:38 UTC (permalink / raw)
To: netfilter-devel
Cc: netdev, linux-kernel, Wensong Zhang, Simon Horman,
Julian Anastasov, Pablo Neira Ayuso, Jozsef Kadlecsik
The sync_refresh_period variable is unsigned, so it can never be < 0.
Signed-off-by: Aaron Conole <aconole@bytheb.org>
---
net/netfilter/ipvs/ip_vs_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
index b03c280..123dc0f 100644
--- a/net/netfilter/ipvs/ip_vs_sync.c
+++ b/net/netfilter/ipvs/ip_vs_sync.c
@@ -520,7 +520,7 @@ static int ip_vs_sync_conn_needed(struct netns_ipvs *ipvs,
if (!(cp->flags & IP_VS_CONN_F_TEMPLATE) &&
pkts % sync_period != sysctl_sync_threshold(ipvs))
return 0;
- } else if (sync_refresh_period <= 0 &&
+ } else if (!sync_refresh_period &&
pkts != sysctl_sync_threshold(ipvs))
return 0;
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH nf-next] ip_vs_sync: change comparison on sync_refresh_period
2017-04-12 20:38 [PATCH nf-next] ip_vs_sync: change comparison on sync_refresh_period Aaron Conole
@ 2017-04-12 22:48 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2017-04-12 22:48 UTC (permalink / raw)
To: Aaron Conole
Cc: netfilter-devel, netdev, linux-kernel, Wensong Zhang,
Julian Anastasov, Pablo Neira Ayuso, Jozsef Kadlecsik
On Wed, Apr 12, 2017 at 04:38:12PM -0400, Aaron Conole wrote:
> The sync_refresh_period variable is unsigned, so it can never be < 0.
>
> Signed-off-by: Aaron Conole <aconole@bytheb.org>
Thanks Aaron,
I have applied this to ipvs-next after updating the prefix to "ipvs:".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-12 22:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-12 20:38 [PATCH nf-next] ip_vs_sync: change comparison on sync_refresh_period Aaron Conole
2017-04-12 22:48 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).