From: Borislav Petkov <bp@alien8.de>
To: "Baicar, Tyler" <tbaicar@codeaurora.org>
Cc: christoffer.dall@linaro.org, marc.zyngier@arm.com,
pbonzini@redhat.com, rkrcmar@redhat.com, linux@armlinux.org.uk,
catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net,
lenb@kernel.org, matt@codeblueprint.co.uk,
robert.moore@intel.com, lv.zheng@intel.com, nkaje@codeaurora.org,
zjzhang@codeaurora.org, mark.rutland@arm.com,
james.morse@arm.com, akpm@linux-foundation.org,
eun.taik.lee@samsung.com, sandeepa.s.prabhu@gmail.com,
labbott@redhat.com, shijie.huang@arm.com,
rruigrok@codeaurora.org, paul.gortmaker@windriver.com,
tn@semihalf.com, fu.wei@linaro.org, rostedt@goodmis.org,
bristot@redhat.com, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-efi@vger.kernel.org, devel@acpica.org,
Suzuki.Poulose@arm.com, punit.agrawal@arm.com, astone@redhat.com,
harba@codeaurora.org, hanjun.guo@linaro.org,
john.garry@huawei.com, shiju.jose@huawei.com, joe@perches.com,
gengdongjiu@huawei.com, xiexiuqi@huawei.com
Subject: Re: [PATCH V14 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1
Date: Thu, 13 Apr 2017 22:47:45 +0200 [thread overview]
Message-ID: <20170413204744.iizyyi32v4hjt3fc@pd.tnic> (raw)
In-Reply-To: <8a31ef45-68f6-d444-f174-4a485cccd696@codeaurora.org>
On Thu, Apr 13, 2017 at 02:30:21PM -0600, Baicar, Tyler wrote:
> I do not agree with this. The struct being passed to this function is
> already named acpi_hest_generic_data in the existing code and all over this
> code is named gdata not just d.
And I'm saying they're too long - the preexisting ones and the ones
you're adding - and impair readability. This whole driver is one
unreadable ugly pile and if I were the maintainer I would never allowed
it in its current form.
But I don't think it really has a maintainer - poor Rafael has to deal
with it because it is under drivers/acpi/ and that whole RAS firmware
crap got thrown over the wall at some point and now we're stuck with it.
So this is just my opinion since he asked me to take a look.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2017-04-13 20:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 19:30 [PATCH V14 00/10] Add UEFI 2.6 and ACPI 6.1 updates for RAS on ARM64 Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 01/10] acpi: apei: read ack upon ghes record consumption Tyler Baicar
2017-04-11 17:15 ` Borislav Petkov
2017-04-13 19:45 ` Baicar, Tyler
2017-03-28 19:30 ` [PATCH V14 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1 Tyler Baicar
2017-04-12 13:34 ` Borislav Petkov
2017-04-12 16:40 ` Joe Perches
2017-04-13 20:30 ` Baicar, Tyler
2017-04-13 20:47 ` Borislav Petkov [this message]
2017-04-13 21:33 ` Baicar, Tyler
2017-03-28 19:30 ` [PATCH V14 03/10] efi: parse ARM processor error Tyler Baicar
2017-04-12 16:51 ` Borislav Petkov
2017-04-13 20:32 ` Baicar, Tyler
2017-03-28 19:30 ` [PATCH V14 04/10] arm64: exception: handle Synchronous External Abort Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 05/10] acpi: apei: handle SEA notification type for ARMv8 Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 06/10] acpi: apei: panic OS with fatal error status block Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 07/10] efi: print unrecognized CPER section Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 08/10] ras: acpi / apei: generate trace event for " Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 09/10] trace, ras: add ARM processor error trace event Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 10/10] arm/arm64: KVM: add guest SEA support Tyler Baicar
2017-03-28 20:26 ` Christoffer Dall
2017-03-28 21:33 ` Baicar, Tyler
2017-03-28 22:18 ` Christoffer Dall
2017-04-06 17:12 ` [PATCH V14 00/10] Add UEFI 2.6 and ACPI 6.1 updates for RAS on ARM64 Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413204744.iizyyi32v4hjt3fc@pd.tnic \
--to=bp@alien8.de \
--cc=Suzuki.Poulose@arm.com \
--cc=akpm@linux-foundation.org \
--cc=astone@redhat.com \
--cc=bristot@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=devel@acpica.org \
--cc=eun.taik.lee@samsung.com \
--cc=fu.wei@linaro.org \
--cc=gengdongjiu@huawei.com \
--cc=hanjun.guo@linaro.org \
--cc=harba@codeaurora.org \
--cc=james.morse@arm.com \
--cc=joe@perches.com \
--cc=john.garry@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=labbott@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lv.zheng@intel.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=nkaje@codeaurora.org \
--cc=paul.gortmaker@windriver.com \
--cc=pbonzini@redhat.com \
--cc=punit.agrawal@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rkrcmar@redhat.com \
--cc=robert.moore@intel.com \
--cc=rostedt@goodmis.org \
--cc=rruigrok@codeaurora.org \
--cc=sandeepa.s.prabhu@gmail.com \
--cc=shijie.huang@arm.com \
--cc=shiju.jose@huawei.com \
--cc=tbaicar@codeaurora.org \
--cc=tn@semihalf.com \
--cc=will.deacon@arm.com \
--cc=xiexiuqi@huawei.com \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).