From: "Baicar, Tyler" <tbaicar@codeaurora.org>
To: Borislav Petkov <bp@alien8.de>
Cc: christoffer.dall@linaro.org, marc.zyngier@arm.com,
pbonzini@redhat.com, rkrcmar@redhat.com, linux@armlinux.org.uk,
catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net,
lenb@kernel.org, matt@codeblueprint.co.uk,
robert.moore@intel.com, lv.zheng@intel.com, nkaje@codeaurora.org,
zjzhang@codeaurora.org, mark.rutland@arm.com,
james.morse@arm.com, akpm@linux-foundation.org,
eun.taik.lee@samsung.com, sandeepa.s.prabhu@gmail.com,
labbott@redhat.com, shijie.huang@arm.com,
rruigrok@codeaurora.org, paul.gortmaker@windriver.com,
tn@semihalf.com, fu.wei@linaro.org, rostedt@goodmis.org,
bristot@redhat.com, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-efi@vger.kernel.org, devel@acpica.org,
Suzuki.Poulose@arm.com, punit.agrawal@arm.com, astone@redhat.com,
harba@codeaurora.org, hanjun.guo@linaro.org,
john.garry@huawei.com, shiju.jose@huawei.com, joe@perches.com,
gengdongjiu@huawei.com, xiexiuqi@huawei.com
Subject: Re: [PATCH V14 01/10] acpi: apei: read ack upon ghes record consumption
Date: Thu, 13 Apr 2017 13:45:26 -0600 [thread overview]
Message-ID: <3056ba3a-d89e-2491-671b-7a50470e865b@codeaurora.org> (raw)
In-Reply-To: <20170411171547.qntimdxnqmtf43ot@pd.tnic>
On 4/11/2017 11:15 AM, Borislav Petkov wrote:
> On Tue, Mar 28, 2017 at 01:30:31PM -0600, Tyler Baicar wrote:
>> A RAS (Reliability, Availability, Serviceability) controller
>> may be a separate processor running in parallel with OS
>> execution, and may generate error records for consumption by
>> the OS. If the RAS controller produces multiple error records,
>> then they may be overwritten before the OS has consumed them.
>>
>> The Generic Hardware Error Source (GHES) v2 structure
>> introduces the capability for the OS to acknowledge the
>> consumption of the error record generated by the RAS
>> controller. A RAS controller supporting GHESv2 shall wait for
>> the acknowledgment before writing a new error record, thus
>> eliminating the race condition.
>>
>> Add support for parsing of GHESv2 sub-tables as well.
>>
>> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
>> CC: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org>
>> Reviewed-by: James Morse <james.morse@arm.com>
>> ---
>> drivers/acpi/apei/ghes.c | 49 +++++++++++++++++++++++++++++++++++++++++++++---
>> drivers/acpi/apei/hest.c | 7 +++++--
>> include/acpi/ghes.h | 5 ++++-
>> 3 files changed, 55 insertions(+), 6 deletions(-)
> ...
>
>> @@ -249,10 +254,18 @@ static struct ghes *ghes_new(struct acpi_hest_generic *generic)
>> ghes = kzalloc(sizeof(*ghes), GFP_KERNEL);
>> if (!ghes)
>> return ERR_PTR(-ENOMEM);
>> +
>> ghes->generic = generic;
>> + if (IS_HEST_TYPE_GENERIC_V2(ghes)) {
>> + rc = apei_map_generic_address(
>> + &ghes->generic_v2->read_ack_register);
> Yeah, that linebreak just to keep the 80-cols rule makes the code ugly
> and hard to read.
>
> Please put that mapping and unmapping in wrappers called
> map_gen_v2(ghes) and unmap_gen_v2(ghes) or so, so that you can call them
> wherever needed. Thus should make the flow a bit more understandable
> what's going on and you won't have to repeat the unmapping lines in
> ghes_fini().
Hello Boris,
Thank you for the feedback. I will make this change in the next version.
>> @@ -649,6 +669,23 @@ static void ghes_estatus_cache_add(
>> rcu_read_unlock();
>> }
>>
>> +static int ghes_ack_error(struct acpi_hest_generic_v2 *generic_v2)
>> +{
>> + int rc;
>> + u64 val = 0;
>> +
>> + rc = apei_read(&val, &generic_v2->read_ack_register);
>> + if (rc)
>> + return rc;
>> + val &= generic_v2->read_ack_preserve <<
>> + generic_v2->read_ack_register.bit_offset;
>> + val |= generic_v2->read_ack_write <<
>> + generic_v2->read_ack_register.bit_offset;
> Yeah, let them stick out, it more readable this way. Line spacing is
> helpful too:
>
> ...
> rc = apei_read(&val, &generic_v2->read_ack_register);
> if (rc)
> return rc;
>
> val &= generic_v2->read_ack_preserve << generic_v2->read_ack_register.bit_offset;
> val |= generic_v2->read_ack_write << generic_v2->read_ack_register.bit_offset;
>
> return apei_write(val, &generic_v2->read_ack_register);
> }
I will make this change in the next version.
Thanks,
Tyler
>> + rc = apei_write(val, &generic_v2->read_ack_register);
>> +
>> + return rc;
>> +}
>> +
>> static int ghes_proc(struct ghes *ghes)
>> {
>> int rc;
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-04-13 19:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 19:30 [PATCH V14 00/10] Add UEFI 2.6 and ACPI 6.1 updates for RAS on ARM64 Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 01/10] acpi: apei: read ack upon ghes record consumption Tyler Baicar
2017-04-11 17:15 ` Borislav Petkov
2017-04-13 19:45 ` Baicar, Tyler [this message]
2017-03-28 19:30 ` [PATCH V14 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1 Tyler Baicar
2017-04-12 13:34 ` Borislav Petkov
2017-04-12 16:40 ` Joe Perches
2017-04-13 20:30 ` Baicar, Tyler
2017-04-13 20:47 ` Borislav Petkov
2017-04-13 21:33 ` Baicar, Tyler
2017-03-28 19:30 ` [PATCH V14 03/10] efi: parse ARM processor error Tyler Baicar
2017-04-12 16:51 ` Borislav Petkov
2017-04-13 20:32 ` Baicar, Tyler
2017-03-28 19:30 ` [PATCH V14 04/10] arm64: exception: handle Synchronous External Abort Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 05/10] acpi: apei: handle SEA notification type for ARMv8 Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 06/10] acpi: apei: panic OS with fatal error status block Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 07/10] efi: print unrecognized CPER section Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 08/10] ras: acpi / apei: generate trace event for " Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 09/10] trace, ras: add ARM processor error trace event Tyler Baicar
2017-03-28 19:30 ` [PATCH V14 10/10] arm/arm64: KVM: add guest SEA support Tyler Baicar
2017-03-28 20:26 ` Christoffer Dall
2017-03-28 21:33 ` Baicar, Tyler
2017-03-28 22:18 ` Christoffer Dall
2017-04-06 17:12 ` [PATCH V14 00/10] Add UEFI 2.6 and ACPI 6.1 updates for RAS on ARM64 Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3056ba3a-d89e-2491-671b-7a50470e865b@codeaurora.org \
--to=tbaicar@codeaurora.org \
--cc=Suzuki.Poulose@arm.com \
--cc=akpm@linux-foundation.org \
--cc=astone@redhat.com \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=devel@acpica.org \
--cc=eun.taik.lee@samsung.com \
--cc=fu.wei@linaro.org \
--cc=gengdongjiu@huawei.com \
--cc=hanjun.guo@linaro.org \
--cc=harba@codeaurora.org \
--cc=james.morse@arm.com \
--cc=joe@perches.com \
--cc=john.garry@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=labbott@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lv.zheng@intel.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=nkaje@codeaurora.org \
--cc=paul.gortmaker@windriver.com \
--cc=pbonzini@redhat.com \
--cc=punit.agrawal@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rkrcmar@redhat.com \
--cc=robert.moore@intel.com \
--cc=rostedt@goodmis.org \
--cc=rruigrok@codeaurora.org \
--cc=sandeepa.s.prabhu@gmail.com \
--cc=shijie.huang@arm.com \
--cc=shiju.jose@huawei.com \
--cc=tn@semihalf.com \
--cc=will.deacon@arm.com \
--cc=xiexiuqi@huawei.com \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).