* [PATCH v2] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK
@ 2017-04-17 17:38 Matthias Kaehlcke
2017-04-18 8:13 ` Thomas Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2017-04-17 17:38 UTC (permalink / raw)
To: John Stultz, Thomas Gleixner
Cc: linux-kernel, Dmitry Torokhov, Grant Grundler, Greg Hackmann,
Michael Davidson, Matthias Kaehlcke
Besides reusing existing code this removes the special case handling
for 64-bit masks, which causes clang to raise a shift count overflow
warning due to https://bugs.llvm.org//show_bug.cgi?id=10030.
Suggested-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in v2:
- Remove unnecessary cast to u64
include/linux/clocksource.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
index cfc75848a35d..f2b10d9ebd04 100644
--- a/include/linux/clocksource.h
+++ b/include/linux/clocksource.h
@@ -120,7 +120,7 @@ struct clocksource {
#define CLOCK_SOURCE_RESELECT 0x100
/* simplify initialization of mask field */
-#define CLOCKSOURCE_MASK(bits) (u64)((bits) < 64 ? ((1ULL<<(bits))-1) : -1)
+#define CLOCKSOURCE_MASK(bits) GENMASK_ULL((bits) - 1, 0)
static inline u32 clocksource_freq2mult(u32 freq, u32 shift_constant, u64 from)
{
--
2.12.2.762.g0e3151a226-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK
2017-04-17 17:38 [PATCH v2] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK Matthias Kaehlcke
@ 2017-04-18 8:13 ` Thomas Gleixner
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2017-04-18 8:13 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: John Stultz, linux-kernel, Dmitry Torokhov, Grant Grundler,
Greg Hackmann, Michael Davidson
On Mon, 17 Apr 2017, Matthias Kaehlcke wrote:
> Besides reusing existing code this removes the special case handling
> for 64-bit masks, which causes clang to raise a shift count overflow
> warning due to https://bugs.llvm.org//show_bug.cgi?id=10030.
>
> Suggested-by: Dmitry Torokhov <dtor@chromium.org>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Changes in v2:
> - Remove unnecessary cast to u64
>
> include/linux/clocksource.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
> index cfc75848a35d..f2b10d9ebd04 100644
> --- a/include/linux/clocksource.h
> +++ b/include/linux/clocksource.h
> @@ -120,7 +120,7 @@ struct clocksource {
> #define CLOCK_SOURCE_RESELECT 0x100
>
> /* simplify initialization of mask field */
> -#define CLOCKSOURCE_MASK(bits) (u64)((bits) < 64 ? ((1ULL<<(bits))-1) : -1)
> +#define CLOCKSOURCE_MASK(bits) GENMASK_ULL((bits) - 1, 0)
>
> static inline u32 clocksource_freq2mult(u32 freq, u32 shift_constant, u64 from)
> {
> --
> 2.12.2.762.g0e3151a226-goog
Neither patch nor git-am can apply that patch. Please fix your tools.
Thanks,
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK
@ 2017-04-18 23:30 Matthias Kaehlcke
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2017-04-18 23:30 UTC (permalink / raw)
To: John Stultz, Thomas Gleixner
Cc: linux-kernel, Dmitry Torokhov, Grant Grundler, Greg Hackmann,
Michael Davidson, Matthias Kaehlcke
Besides reusing existing code this removes the special case handling
for 64-bit masks, which causes clang to raise a shift count overflow
warning due to https://bugs.llvm.org//show_bug.cgi?id=10030.
Suggested-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in v2:
- Remove unnecessary cast to u64
include/linux/clocksource.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
index cfc75848a35d..f2b10d9ebd04 100644
--- a/include/linux/clocksource.h
+++ b/include/linux/clocksource.h
@@ -120,7 +120,7 @@ struct clocksource {
#define CLOCK_SOURCE_RESELECT 0x100
/* simplify initialization of mask field */
-#define CLOCKSOURCE_MASK(bits) (u64)((bits) < 64 ? ((1ULL<<(bits))-1) : -1)
+#define CLOCKSOURCE_MASK(bits) GENMASK_ULL((bits) - 1, 0)
static inline u32 clocksource_freq2mult(u32 freq, u32 shift_constant, u64 from)
{
--
2.12.2.816.g2cccc81164-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-18 23:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-17 17:38 [PATCH v2] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK Matthias Kaehlcke
2017-04-18 8:13 ` Thomas Gleixner
2017-04-18 23:30 Matthias Kaehlcke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).