* Re: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues
[not found] ` <VI1PR0901MB16166F494E9CECB93E1CD478A4040@VI1PR0901MB1616.eurprd09.prod.outlook.com>
@ 2017-04-18 15:50 ` greg
2017-04-19 1:21 ` Dilger, Andreas
0 siblings, 1 reply; 2+ messages in thread
From: greg @ 2017-04-18 15:50 UTC (permalink / raw)
To: Rishiraj Manwatkar
Cc: lustre-devel, devel, linux-kernel, andreas.dilger, oleg.drokin
On Sat, Apr 15, 2017 at 01:50:42PM +0000, Rishiraj Manwatkar wrote:
> Parantheses are added for Macro argument, to avoid precedence issues.
>
> Signed-off-by: Rishiraj Manwatkar <manwatkar@outlook.com>
> ---
> v1 -> v2: Added mailing list in cc.
> v2 -> v3: Changed From: to be same as Signed-off-by:.
> drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> index ee7d677..0997254 100755
> --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> @@ -52,9 +52,9 @@
> */
>
> #define cl_io_for_each(slice, io) \
> - list_for_each_entry((slice), &io->ci_layers, cis_linkage)
> + list_for_each_entry((slice), &(io)->ci_layers, cis_linkage)
Really? There is no precedence issues that I can see here, sorry.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues
2017-04-18 15:50 ` [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues greg
@ 2017-04-19 1:21 ` Dilger, Andreas
0 siblings, 0 replies; 2+ messages in thread
From: Dilger, Andreas @ 2017-04-19 1:21 UTC (permalink / raw)
To: greg; +Cc: Rishiraj Manwatkar, lustre-devel, devel, linux-kernel, Drokin, Oleg
On Apr 18, 2017, at 09:50, greg@kroah.com wrote:
>
> On Sat, Apr 15, 2017 at 01:50:42PM +0000, Rishiraj Manwatkar wrote:
>> Subject: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues
(typo) s/Parantheses/parenthesis/ s/Macro/macro/
The Subject line (excluding [PATCH] part) should be under 60
>> Parantheses are added for Macro argument, to avoid precedence issues.
Should be something like:
Subject: [PATCH v4 1/2] staging/lustre: add parenthesis to macro arguments
Add parenthesis to cl_io_for_each() macro to avoid potential issues with
unexpected argument expansion in CPP.
>> Signed-off-by: Rishiraj Manwatkar <manwatkar@outlook.com>
>> ---
>> v1 -> v2: Added mailing list in cc.
>> v2 -> v3: Changed From: to be same as Signed-off-by:.
>> drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
>> index ee7d677..0997254 100755
>> --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c
>> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
>> @@ -52,9 +52,9 @@
>> */
>>
>> #define cl_io_for_each(slice, io) \
>> - list_for_each_entry((slice), &io->ci_layers, cis_linkage)
>> + list_for_each_entry((slice), &(io)->ci_layers, cis_linkage)
>
> Really? There is no precedence issues that I can see here, sorry.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-19 1:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <a2e734ab4562ded68cb7e7b8d55f51f757189fcd.1492255078>
[not found] ` <VI1PR0901MB16166F494E9CECB93E1CD478A4040@VI1PR0901MB1616.eurprd09.prod.outlook.com>
2017-04-18 15:50 ` [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues greg
2017-04-19 1:21 ` Dilger, Andreas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).