From: Wolfram Sang <wsa@the-dreams.de>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
Aaro Koskinen <aaro.koskinen@iki.fi>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Lee Jones <lee.jones@linaro.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [v5,1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings
Date: Wed, 19 Apr 2017 21:39:33 +0200 [thread overview]
Message-ID: <20170419193933.ocnhxdfojanp5324@ninjato> (raw)
In-Reply-To: <20170412172800.23035-2-javier@osg.samsung.com>
[-- Attachment #1: Type: text/plain, Size: 2680 bytes --]
On Wed, Apr 12, 2017 at 02:27:52PM -0300, Javier Martinez Canillas wrote:
> There are Device Tree source files defining a device node for the
> retu/tahvo I2C chip, but there isn't a DT binding document for it.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> Acked-by: Tony Lindgren <tony@atomide.com>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
>
> Changes in v5:
> - Add missing properties for interrupts to DT binding doc (Rob Herring).
> - Add Rob Herring's Acked-by tag.
> - Add Aaro Koskinen's Acked-by tag.
> - Add Acked-by: Tony Lindgren <tony@atomide.com>'s Acked-by tag.
> - Add Lee Jones <lee.jones@linaro.org>'s Acked-by tag.
>
> Changes in v4:
> - Use "dt-bindings: mfd:" prefix in subject line (Rob Herring).
> - Add information about what functions the device serve (Lee Jones).
> - Avoid using MFD in Device Tree (Lee Jones).
>
> Changes in v3: None
> Changes in v2: None
>
> Documentation/devicetree/bindings/mfd/retu.txt | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/retu.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/retu.txt b/Documentation/devicetree/bindings/mfd/retu.txt
> new file mode 100644
> index 000000000000..e1ea3a36a038
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/retu.txt
> @@ -0,0 +1,23 @@
> +* Device tree bindings for Nokia Retu and Tahvo multi-function device
> +
> +Retu and Tahvo are a multi-function devices found on Nokia Internet
> +Tablets (770, N800 and N810). The Retu chip provides watchdog timer
> +and power button control functionalities while Tahvo chip provides
> +USB transceiver functionality.
> +
> +Required properties:
> +- compatible: "nokia,retu" or "nokia,tahvo"
> +- reg: Specifies the I2C slave address of the ASIC chip
This should be "CBUS slave address". CBUS is a strange subset of I2C,
yet I'd like the distinction because 0x1 is not a valid I2C address.
> +- interrupts: The interrupt line the device is connected to
> +- interrupt-parent: The parent interrupt controller
> +
> +Example:
> +
> +i2c0 {
To make it super clear, we are talking CBUS here, it might make sense to
add here:
+ compatible = "i2c-cbus-gpio";
+ ...
? It could be argued that the above "i2c0" should be "cbus0" as well but
that is a separate issue, I'd think.
> + retu: retu@1 {
> + compatible = "nokia,retu";
> + interrupt-parent = <&gpio4>;
> + interrupts = <12 IRQ_TYPE_EDGE_RISING>;
> + reg = <0x1>;
> + };
> +};
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-04-19 19:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 17:27 [PATCH v5 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
2017-04-12 17:27 ` [PATCH v5 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Javier Martinez Canillas
2017-04-19 19:39 ` Wolfram Sang [this message]
2017-04-12 17:27 ` [PATCH v5 2/8] mfd: retu: Drop -mfd suffix from I2C device ID name Javier Martinez Canillas
2017-04-19 19:40 ` [v5,2/8] " Wolfram Sang
2017-04-12 17:27 ` [PATCH v5 3/8] mfd: retu: Add OF device ID table Javier Martinez Canillas
2017-04-19 19:40 ` [v5,3/8] " Wolfram Sang
2017-04-12 17:27 ` [PATCH v5 4/8] ARM: dts: n8x0: Add vendor prefix to retu node Javier Martinez Canillas
2017-04-19 19:40 ` [v5,4/8] " Wolfram Sang
2017-04-12 17:27 ` [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Javier Martinez Canillas
2017-04-19 18:51 ` Wolfram Sang
2017-04-19 19:13 ` Javier Martinez Canillas
2017-04-19 19:41 ` Wolfram Sang
2017-04-12 17:27 ` [PATCH v5 6/8] dt-bindings: mfd: Add TI tps6105x chip bindings Javier Martinez Canillas
2017-04-12 17:27 ` [PATCH v5 7/8] mfd: tps6105x: Add OF device ID table Javier Martinez Canillas
2017-04-12 17:27 ` [PATCH v5 8/8] ARM: ux500: Add vendor prefix to tps61052 node Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419193933.ocnhxdfojanp5324@ninjato \
--to=wsa@the-dreams.de \
--cc=aaro.koskinen@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).