From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH v3 02/12] arm64: allwinner: a64: add NMI controller on A64
Date: Thu, 20 Apr 2017 07:58:02 +0200 [thread overview]
Message-ID: <20170420055802.btibui5pspan4qal@lukather> (raw)
In-Reply-To: <FB3B3C68-EB16-4352-B0B9-64857B1A6C03@aosc.io>
[-- Attachment #1: Type: text/plain, Size: 1679 bytes --]
On Tue, Apr 18, 2017 at 06:56:43PM +0800, Icenowy Zheng wrote:
>
>
> 于 2017年4月18日 GMT+08:00 下午3:00:16, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:
> >On Mon, Apr 17, 2017 at 07:57:37PM +0800, Icenowy Zheng wrote:
> >> Allwinner A64 SoC features a NMI controller, which is usually
> >connected
> >> to the AXP PMIC.
> >>
> >> Add support for it.
> >>
> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> >> Acked-by: Chen-Yu Tsai <wens@csie.org>
> >> ---
> >> Changes in v2:
> >> - Added Chen-Yu's ACK.
> >>
> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> index 05ec9fc5e81f..53c18ca372ea 100644
> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> @@ -403,6 +403,14 @@
> >> <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
> >> };
> >>
> >> + nmi_intc: interrupt-controller@01f00c0c {
> >> + compatible = "allwinner,sun6i-a31-sc-nmi";
> >> + interrupt-controller;
> >> + #interrupt-cells = <2>;
> >> + reg = <0x01f00c0c 0x38>;
> >
> >The base address is not correct, and there's uncertainty on whether
> >this is this particular controller or not. Did you even test this?
>
> Tested by axp20x-pek.
Still, the base address is wrong, which is yet another hint that this
is not the same interrupt controller, and just works by accident.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-04-20 6:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 11:57 [PATCH v3 00/12] AXP803 PMIC support for Pine64 Icenowy Zheng
2017-04-17 11:57 ` [PATCH v3 01/12] arm64: allwinner: a64: enable RSB on A64 Icenowy Zheng
2017-04-18 5:37 ` Maxime Ripard
2017-04-17 11:57 ` [PATCH v3 02/12] arm64: allwinner: a64: add NMI controller " Icenowy Zheng
2017-04-18 7:00 ` Maxime Ripard
2017-04-18 10:56 ` [linux-sunxi] " Icenowy Zheng
2017-04-20 5:58 ` Maxime Ripard [this message]
2017-04-20 7:03 ` icenowy
2017-04-24 7:17 ` Maxime Ripard
2017-04-24 10:25 ` icenowy
2017-04-17 11:57 ` [PATCH v3 03/12] dt-bindings: make AXP20X compatible strings one per line Icenowy Zheng
2017-04-18 10:35 ` [linux-sunxi] " Chen-Yu Tsai
2017-04-20 14:18 ` Rob Herring
2017-04-24 12:07 ` Lee Jones
2017-04-17 11:57 ` [PATCH v3 04/12] dt-bindings: add device tree binding for X-Powers AXP803 PMIC Icenowy Zheng
2017-04-24 12:08 ` Lee Jones
2017-04-17 11:57 ` [PATCH v3 05/12] mfd: axp20x: support AXP803 variant Icenowy Zheng
2017-04-24 12:09 ` Lee Jones
2017-04-17 11:57 ` [PATCH v3 06/12] arm64: allwinner: a64: add AXP803 node to Pine64 device tree Icenowy Zheng
2017-04-17 11:57 ` [PATCH v3 07/12] dt-bindings: add AXP803's regulator info Icenowy Zheng
2017-04-18 10:36 ` [linux-sunxi] " Chen-Yu Tsai
2017-04-24 12:09 ` Lee Jones
2017-04-17 11:57 ` [PATCH v3 08/12] regulator: axp20x-regulator: add support for AXP803 Icenowy Zheng
2017-04-18 12:07 ` [linux-sunxi] " Chen-Yu Tsai
2017-04-26 14:45 ` Mark Brown
2017-04-17 11:57 ` [PATCH v3 09/12] mfd: axp20x: add axp20x-regulator cell " Icenowy Zheng
2017-04-18 10:38 ` [linux-sunxi] " Chen-Yu Tsai
2017-04-18 10:55 ` Icenowy Zheng
2017-04-18 11:58 ` Chen-Yu Tsai
2017-04-17 11:57 ` [PATCH v3 10/12] arm64: allwinner: a64: add DTSI file for AXP803 PMIC Icenowy Zheng
2017-04-18 7:08 ` Maxime Ripard
2017-04-18 7:20 ` [linux-sunxi] " Chen-Yu Tsai
2017-04-17 11:57 ` [PATCH v3 11/12] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Icenowy Zheng
2017-04-17 11:57 ` [PATCH v3 12/12] arm64: allwinner: a64: enable Wi-Fi " Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420055802.btibui5pspan4qal@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).