From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Roger Quadros <rogerq@ti.com>,
davem@davemloft.net, tony@atomide.com, nsekhar@ti.com,
jsarha@ti.com, netdev@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 net-next] mdio_bus: Issue GPIO RESET to PHYs.
Date: Fri, 21 Apr 2017 03:38:58 +0200 [thread overview]
Message-ID: <20170421013858.GB705@lunn.ch> (raw)
In-Reply-To: <fa24ae98-3d4f-4b11-bbb4-485b9ed41ed7@gmail.com>
> > + gpiod_set_value_cansleep(gpiod, 1);
> > + udelay(bus->reset_delay_us);
> > + gpiod_set_value_cansleep(gpiod, 0);
>
> Does that work even if the polarity of the reset line is active low?
Hi Florian
Yes, it does. The gpiod_ API takes care of that, if you set the flag
GPIO_ACTIVE_LOW in the device tree blob. This is one of the
improvements over the gpio_ API.
Andrew
next prev parent reply other threads:[~2017-04-21 1:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 8:33 [PATCH] net: davinci_mdio: add GPIO reset logic Roger Quadros
2017-04-05 15:03 ` Andrew Lunn
2017-04-06 9:15 ` Roger Quadros
2017-04-06 12:05 ` Andrew Lunn
2017-04-06 16:48 ` Roger Quadros
2017-04-08 13:55 ` David Miller
2017-04-08 15:10 ` Andrew Lunn
2017-04-08 15:18 ` Florian Fainelli
2017-04-10 7:52 ` Roger Quadros
2017-04-19 9:24 ` [PATCH] mdio_bus: Issue GPIO RESET to PHYs Roger Quadros
2017-04-19 11:39 ` Andrew Lunn
2017-04-19 11:56 ` Roger Quadros
2017-04-19 13:38 ` Andrew Lunn
2017-04-20 7:58 ` Roger Quadros
2017-04-20 8:39 ` [PATCH v2] " Roger Quadros
2017-04-20 13:13 ` Andrew Lunn
2017-04-20 13:56 ` Roger Quadros
2017-04-20 14:11 ` [PATCH v3 net-next] " Roger Quadros
2017-04-21 1:12 ` Andrew Lunn
2017-04-21 1:23 ` Florian Fainelli
2017-04-21 1:38 ` Andrew Lunn [this message]
2017-04-21 8:04 ` Roger Quadros
2017-04-21 13:15 ` [PATCH v4 " Roger Quadros
2017-04-21 13:31 ` Lars-Peter Clausen
2017-04-23 23:35 ` Andrew Lunn
2017-04-24 9:04 ` Roger Quadros
2017-04-24 16:32 ` Florian Fainelli
2017-04-25 16:22 ` Lars-Peter Clausen
2017-04-25 16:31 ` Florian Fainelli
2017-04-26 10:46 ` Roger Quadros
2017-04-26 12:27 ` Andrew Lunn
2017-04-26 10:43 ` Roger Quadros
2017-04-24 16:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421013858.GB705@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).