From: Stephen Boyd <sboyd@codeaurora.org>
To: Dong Aisheng <dongas86@gmail.com>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
broonie@kernel.org, yibin.gong@nxp.com, rjw@rjwysocki.net,
viresh.kumar@linaro.org, mturquette@baylibre.com,
shawnguo@kernel.org, fabio.estevam@nxp.com, anson.huang@nxp.com,
ping.bai@nxp.com, leonard.crestez@nxp.com,
octavian.purdila@nxp.com
Subject: Re: [RFC PATCH 2/3] clk: add managed version of clk_bulk_get
Date: Fri, 21 Apr 2017 19:58:37 -0700 [thread overview]
Message-ID: <20170422025837.GU7065@codeaurora.org> (raw)
In-Reply-To: <20170413143727.GE24254@b29396-OptiPlex-7040>
On 04/13, Dong Aisheng wrote:
> On Wed, Apr 12, 2017 at 12:03:28PM +0800, Dong Aisheng wrote:
>
> drivers/built-in.o: In function `devm_clk_bulk_get':
> >> (.text+0x1930e): undefined reference to `clk_bulk_get'
> drivers/built-in.o: In function `devm_clk_bulk_release':
> >> clk-devres.c:(.text+0x19370): undefined reference to `clk_bulk_put'
>
> clk_bulk_get is defined in clkdev.c which depends on CONFIG_CLKDEV_LOOKUP.
> However, some platforms like m68k may not select CLKDEV_LOOKUP but
> select HAVE_CLK. Thus compiling devm_clk_bulk_get may cause a undefined
> reference to 'clk_bulk_get'.
>
> Since clk_bulk_get is built upon the platform specific clk_get api,
> clk_bulk_get can also be used by that platform accordingly.
>
> Then we probably could move clk_bulk_get into clk-devres.c as well which
> is controlled by common CONFIG_HAVE_CLK to benifit all platforms.
clk-devres is for devm* things. I'd just make another file for
now, clk-bulk.c or something like that. When everyone moves to
common clk, we can fold it into clk.c, or not because clk.c is
rather large right now.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-04-22 2:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 4:03 [RFC PATCH 0/3] clk: introduce clk_bulk_get accessories Dong Aisheng
2017-04-11 17:01 ` Florian Fainelli
2017-04-13 13:58 ` Dong Aisheng
2017-04-12 4:03 ` [RFC PATCH 1/3] clk: add " Dong Aisheng
2017-04-11 17:19 ` Leonard Crestez
2017-04-13 14:02 ` Dong Aisheng
2017-04-13 19:57 ` Geert Uytterhoeven
2017-04-13 14:25 ` Dong Aisheng
2017-04-13 19:56 ` Geert Uytterhoeven
2017-04-14 16:14 ` Dong Aisheng
2017-04-22 3:16 ` Stephen Boyd
2017-05-08 11:34 ` Dong Aisheng
2017-04-12 4:03 ` [RFC PATCH 2/3] clk: add managed version of clk_bulk_get Dong Aisheng
2017-04-13 14:37 ` Dong Aisheng
2017-04-22 2:58 ` Stephen Boyd [this message]
2017-05-08 11:41 ` Dong Aisheng
2017-04-22 2:55 ` Stephen Boyd
2017-05-08 11:37 ` Dong Aisheng
2017-04-12 4:03 ` [RFC PATCH 3/3] cpufreq: imx6q: refine clk operations Dong Aisheng
2017-04-11 17:48 ` Leonard Crestez
2017-04-13 14:21 ` Dong Aisheng
2017-04-22 3:04 ` [RFC PATCH 0/3] clk: introduce clk_bulk_get accessories Stephen Boyd
2017-05-08 11:07 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170422025837.GU7065@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=broonie@kernel.org \
--cc=dongas86@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=octavian.purdila@nxp.com \
--cc=ping.bai@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).