From: Dong Aisheng <dongas86@gmail.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
broonie@kernel.org, yibin.gong@nxp.com, rjw@rjwysocki.net,
viresh.kumar@linaro.org, mturquette@baylibre.com,
shawnguo@kernel.org, fabio.estevam@nxp.com, anson.huang@nxp.com,
ping.bai@nxp.com, leonard.crestez@nxp.com,
octavian.purdila@nxp.com
Subject: Re: [RFC PATCH 1/3] clk: add clk_bulk_get accessories
Date: Mon, 8 May 2017 19:34:59 +0800 [thread overview]
Message-ID: <20170508113459.GB18153@b29396-OptiPlex-7040> (raw)
In-Reply-To: <20170422031647.GW7065@codeaurora.org>
On Fri, Apr 21, 2017 at 08:16:47PM -0700, Stephen Boyd wrote:
> On 04/12, Dong Aisheng wrote:
> >
> > #ifdef CONFIG_HAVE_CLK
> > @@ -230,6 +257,32 @@ static inline void clk_unprepare(struct clk *clk)
> > struct clk *clk_get(struct device *dev, const char *id);
> >
> > /**
> > + * clk_bulk_get - lookup and obtain a number of references to clock producer.
> > + * @dev: device for clock "consumer"
> > + * @num_clks: the number of clk_bulk_data
> > + * @clks: the clk_bulk_data table of consumer
> > + *
> > + * This helper function allows drivers to get several clk consumers in one
> > + * operation. If any of the clk cannot be acquired then any clks
> > + * that were obtained will be freed before returning to the caller.
> > + *
> > + * Returns 0 if all clocks specified in clk_bulk_data table are obtained
> > + * successfully, or valid IS_ERR() condition containing errno.
> > + * The implementation uses @dev and @clk_bulk_data.id to determine the
> > + * clock consumer, and thereby the clock producer.
> > + * (IOW, @id may be identical strings, but clk_get may return different
> > + * clock producers depending on @dev.) The clock returned is stored in
>
> This comment is inaccurate. Only one dev is possible with this
> API.
>
Good catch! Will fix it.
> > + * each @clk_bulk_data.clk field.
> > + *
> > + * Drivers must assume that the clock source is not enabled.
> > + *
> > + * clk_bulk_get should not be called from within interrupt context.
> > + */
> > +
>
> Drop space.
>
Got it
> > +int __must_check clk_bulk_get(struct device *dev, int num_clks,
> > + struct clk_bulk_data *clks);
> > +
> > +/**
> > * devm_clk_get - lookup and obtain a managed reference to a clock producer.
> > * @dev: device for clock "consumer"
> > * @id: clock consumer ID
> > @@ -279,6 +332,20 @@ struct clk *devm_get_clk_from_child(struct device *dev,
> > int clk_enable(struct clk *clk);
> >
> > /**
> > + * clk_bulk_enable - inform the system when the bulk of clock source should
> > + * be running.
> > + * @num_clks: the number of clk_bulk_data
> > + * @clks: the clk_bulk_data table of consumer
> > + *
> > + * If the clock can not be enabled/disabled all, this should return success.
> > + *
> > + * May be called from atomic contexts.
> > + *
> > + * Returns success (0) or negative errno.
> > + */
> > +int __must_check clk_bulk_enable(int num_clks, struct clk_bulk_data *clks);
> > +
> > +/**
> > * clk_disable - inform the system when the clock source is no longer required.
> > * @clk: clock source
> > *
> > @@ -295,6 +362,24 @@ int clk_enable(struct clk *clk);
> > void clk_disable(struct clk *clk);
> >
> > /**
> > + * clk_bulk_disable - inform the system when the bulk of clock source is no
> > + * longer required.
> > + * @num_clks: the number of clk_bulk_data
> > + * @clks: the clk_bulk_data table of consumer
> > + *
> > + * Inform the system that a bulk of clock source is no longer required by
> > + * a driver and may be shut down.
> > + *
> > + * May be called from atomic contexts.
> > + *
> > + * Implementation detail: if the bulk of clock source is shared between
>
> I'm not sure "bulk of clock source" is the correct terminology.
> Perhaps "set of clks"?
>
Good to me, will change.
> > + * multiple drivers, clk_bulk_enable() calls must be balanced by the
> > + * same number of clk_bulk_disable() calls for the clock source to be
> > + * disabled.
> > + */
> > +void clk_bulk_disable(int num_clks, struct clk_bulk_data *clks);
>
> We can mark clk_bulk_data structure as const here? Probably
> applies in other places as well in this patch.
>
Sounds good, will change the following API,
clk_bulk_{enable|disable}
clk_bulk_{prepare|unprepare}
except clk_bulk_{get|put} which needs update clk_bulk_date.
Regards
Dong Aisheng
next prev parent reply other threads:[~2017-05-08 11:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 4:03 [RFC PATCH 0/3] clk: introduce clk_bulk_get accessories Dong Aisheng
2017-04-11 17:01 ` Florian Fainelli
2017-04-13 13:58 ` Dong Aisheng
2017-04-12 4:03 ` [RFC PATCH 1/3] clk: add " Dong Aisheng
2017-04-11 17:19 ` Leonard Crestez
2017-04-13 14:02 ` Dong Aisheng
2017-04-13 19:57 ` Geert Uytterhoeven
2017-04-13 14:25 ` Dong Aisheng
2017-04-13 19:56 ` Geert Uytterhoeven
2017-04-14 16:14 ` Dong Aisheng
2017-04-22 3:16 ` Stephen Boyd
2017-05-08 11:34 ` Dong Aisheng [this message]
2017-04-12 4:03 ` [RFC PATCH 2/3] clk: add managed version of clk_bulk_get Dong Aisheng
2017-04-13 14:37 ` Dong Aisheng
2017-04-22 2:58 ` Stephen Boyd
2017-05-08 11:41 ` Dong Aisheng
2017-04-22 2:55 ` Stephen Boyd
2017-05-08 11:37 ` Dong Aisheng
2017-04-12 4:03 ` [RFC PATCH 3/3] cpufreq: imx6q: refine clk operations Dong Aisheng
2017-04-11 17:48 ` Leonard Crestez
2017-04-13 14:21 ` Dong Aisheng
2017-04-22 3:04 ` [RFC PATCH 0/3] clk: introduce clk_bulk_get accessories Stephen Boyd
2017-05-08 11:07 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508113459.GB18153@b29396-OptiPlex-7040 \
--to=dongas86@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=broonie@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=octavian.purdila@nxp.com \
--cc=ping.bai@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).