* [PATCH] usb: serial: upd78f0730: Make constants static
@ 2017-04-24 9:59 Maksim Salau
2017-06-01 9:08 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Maksim Salau @ 2017-04-24 9:59 UTC (permalink / raw)
To: Johan Hovold, Greg Kroah-Hartman, linux-usb, linux-kernel; +Cc: Maksim Salau
Some local constants don't change from call to call and are good
candidates to become static. This will prevent copying of these
constants to stack during runtime.
Signed-off-by: Maksim Salau <maksim.salau@gmail.com>
---
drivers/usb/serial/upd78f0730.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/upd78f0730.c b/drivers/usb/serial/upd78f0730.c
index a028dd2..6819a34 100644
--- a/drivers/usb/serial/upd78f0730.c
+++ b/drivers/usb/serial/upd78f0730.c
@@ -288,7 +288,7 @@ static void upd78f0730_dtr_rts(struct usb_serial_port *port, int on)
static speed_t upd78f0730_get_baud_rate(struct tty_struct *tty)
{
const speed_t baud_rate = tty_get_baud_rate(tty);
- const speed_t supported[] = {
+ static const speed_t supported[] = {
0, 2400, 4800, 9600, 19200, 38400, 57600, 115200, 153600
};
int i;
@@ -384,7 +384,7 @@ static void upd78f0730_set_termios(struct tty_struct *tty,
static int upd78f0730_open(struct tty_struct *tty, struct usb_serial_port *port)
{
- struct upd78f0730_open_close request = {
+ static const struct upd78f0730_open_close request = {
.opcode = UPD78F0730_CMD_OPEN_CLOSE,
.state = UPD78F0730_PORT_OPEN
};
@@ -402,7 +402,7 @@ static int upd78f0730_open(struct tty_struct *tty, struct usb_serial_port *port)
static void upd78f0730_close(struct usb_serial_port *port)
{
- struct upd78f0730_open_close request = {
+ static const struct upd78f0730_open_close request = {
.opcode = UPD78F0730_CMD_OPEN_CLOSE,
.state = UPD78F0730_PORT_CLOSE
};
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: serial: upd78f0730: Make constants static
2017-04-24 9:59 [PATCH] usb: serial: upd78f0730: Make constants static Maksim Salau
@ 2017-06-01 9:08 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2017-06-01 9:08 UTC (permalink / raw)
To: Maksim Salau; +Cc: Johan Hovold, Greg Kroah-Hartman, linux-usb, linux-kernel
On Mon, Apr 24, 2017 at 12:59:53PM +0300, Maksim Salau wrote:
> Some local constants don't change from call to call and are good
> candidates to become static. This will prevent copying of these
> constants to stack during runtime.
>
> Signed-off-by: Maksim Salau <maksim.salau@gmail.com>
Now applied, thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-01 9:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-24 9:59 [PATCH] usb: serial: upd78f0730: Make constants static Maksim Salau
2017-06-01 9:08 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).