* [PATCH -next] firmware: google memconsole: Fix return value check in platform_memconsole_init()
@ 2017-04-25 3:11 Wei Yongjun
0 siblings, 0 replies; only message in thread
From: Wei Yongjun @ 2017-04-25 3:11 UTC (permalink / raw)
To: Greg Kroah-Hartman, Thierry Escande; +Cc: Wei Yongjun, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
In case of error, the function platform_device_register_simple() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().
Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/firmware/google/memconsole-coreboot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/google/memconsole-coreboot.c b/drivers/firmware/google/memconsole-coreboot.c
index 2121014..0271111 100644
--- a/drivers/firmware/google/memconsole-coreboot.c
+++ b/drivers/firmware/google/memconsole-coreboot.c
@@ -95,8 +95,8 @@ static int __init platform_memconsole_init(void)
struct platform_device *pdev;
pdev = platform_device_register_simple("memconsole", -1, NULL, 0);
- if (pdev == NULL)
- return -ENODEV;
+ if (IS_ERR(pdev))
+ return PTR_ERR(pdev);
platform_driver_register(&memconsole_driver);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-04-25 3:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-25 3:11 [PATCH -next] firmware: google memconsole: Fix return value check in platform_memconsole_init() Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).