From: Borislav Petkov <bp@alien8.de>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
Brian Gerst <brgerst@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, msr: Better document AMD "tweak MSRs", rename MSR_F15H_IC_CFG
Date: Tue, 25 Apr 2017 13:59:48 +0200 [thread overview]
Message-ID: <20170425115948.6hekn2xklodjil7e@pd.tnic> (raw)
In-Reply-To: <20170425114541.8267-1-dvlasenk@redhat.com>
On Tue, Apr 25, 2017 at 01:45:41PM +0200, Denys Vlasenko wrote:
> Before this patch, we have a define for MSR 0xc0011021: MSR_F15H_IC_CFG.
> But it exists starting from K8, so it's not really a Fam15h MSR only.
>
> Lat's call it MSR_AMD64_IC_CFG.
Except that we name only those MSRs with "AMD64" which are
architectural. See "Appendix A MSR Cross-Reference" in APM vol 2.
And the ones you want to rename are not and there is no guarantee about
anything wrt to those. So no, I'd prefer if those remained per-family as
it is now.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2017-04-25 12:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 11:45 [PATCH] x86, msr: Better document AMD "tweak MSRs", rename MSR_F15H_IC_CFG Denys Vlasenko
2017-04-25 11:59 ` Borislav Petkov [this message]
2017-04-25 12:16 ` Denys Vlasenko
2017-04-25 12:59 ` Borislav Petkov
2017-04-25 13:05 ` Denys Vlasenko
2017-04-25 13:18 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425115948.6hekn2xklodjil7e@pd.tnic \
--to=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).