From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] HSI: omap_ssi: Delete an error message for a failed memory allocation in ssi_add_controller()
Date: Tue, 25 Apr 2017 15:32:50 +0300 [thread overview]
Message-ID: <20170425123250.ipltfpgcgbtk6h3g@mwanda> (raw)
In-Reply-To: <20170425115446.GC7926@amd>
1) That allocation will never fail in real life so it's dead code.
2) kmalloc and friends already have much better builtin in error
messages so it's useless.
3) There is a small memory savings from removing it.
I'm not saying you should apply the patch, I'm just saying that these
messages are pointless and detrimental.
regards,
an carpenter
next prev parent reply other threads:[~2017-04-25 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 11:12 [PATCH 0/3] HSI: omap_ssi: Fine-tuning for two function implementations SF Markus Elfring
2017-04-25 11:15 ` [PATCH 1/3] HSI: omap_ssi: Use devm_kcalloc() in ssi_add_controller() SF Markus Elfring
2017-04-25 11:16 ` [PATCH 2/3] HSI: omap_ssi: Fix a typo in a comment line SF Markus Elfring
2017-04-25 11:18 ` [PATCH 3/3] HSI: omap_ssi: Delete an error message for a failed memory allocation in ssi_add_controller() SF Markus Elfring
2017-04-25 11:54 ` Pavel Machek
2017-04-25 12:32 ` Dan Carpenter [this message]
2017-05-01 9:07 ` [PATCH 0/3] HSI: omap_ssi: Fine-tuning for two function implementations Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425123250.ipltfpgcgbtk6h3g@mwanda \
--to=dan.carpenter@oracle.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).