* [PATCH 1/1] libertas: check return value of alloc_workqueue
@ 2017-04-23 13:19 Pan Bian
2017-04-26 9:03 ` [1/1] " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Pan Bian @ 2017-04-23 13:19 UTC (permalink / raw)
To: Kalle Valo, Bhaktipriya Shridhar, Tejun Heo
Cc: libertas-dev, linux-wireless, netdev, linux-kernel, Pan Bian
From: Pan Bian <bianpan2016@163.com>
Function alloc_workqueue() will return a NULL pointer if there is no
enough memory, and its return value should be validated before using.
However, in function if_spi_probe(), its return value is not checked.
This may result in a NULL dereference bug. This patch fixes the bug.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/net/wireless/marvell/libertas/if_spi.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/wireless/marvell/libertas/if_spi.c b/drivers/net/wireless/marvell/libertas/if_spi.c
index c3a53cd..7b4955c 100644
--- a/drivers/net/wireless/marvell/libertas/if_spi.c
+++ b/drivers/net/wireless/marvell/libertas/if_spi.c
@@ -1181,6 +1181,10 @@ static int if_spi_probe(struct spi_device *spi)
/* Initialize interrupt handling stuff. */
card->workqueue = alloc_workqueue("libertas_spi", WQ_MEM_RECLAIM, 0);
+ if (!card->workqueue) {
+ err = -ENOMEM;
+ goto remove_card;
+ }
INIT_WORK(&card->packet_work, if_spi_host_to_card_worker);
INIT_WORK(&card->resume_work, if_spi_resume_worker);
@@ -1209,6 +1213,7 @@ static int if_spi_probe(struct spi_device *spi)
free_irq(spi->irq, card);
terminate_workqueue:
destroy_workqueue(card->workqueue);
+remove_card:
lbs_remove_card(priv); /* will call free_netdev */
free_card:
free_if_spi_card(card);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [1/1] libertas: check return value of alloc_workqueue
2017-04-23 13:19 [PATCH 1/1] libertas: check return value of alloc_workqueue Pan Bian
@ 2017-04-26 9:03 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2017-04-26 9:03 UTC (permalink / raw)
To: Pan Bian
Cc: Bhaktipriya Shridhar, Tejun Heo, libertas-dev, linux-wireless,
netdev, linux-kernel, Pan Bian
Pan Bian <bianpan201603@163.com> wrote:
> From: Pan Bian <bianpan2016@163.com>
>
> Function alloc_workqueue() will return a NULL pointer if there is no
> enough memory, and its return value should be validated before using.
> However, in function if_spi_probe(), its return value is not checked.
> This may result in a NULL dereference bug. This patch fixes the bug.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Patch applied to wireless-drivers-next.git, thanks.
dc3f89c38a84 libertas: check return value of alloc_workqueue
--
https://patchwork.kernel.org/patch/9694827/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-26 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-23 13:19 [PATCH 1/1] libertas: check return value of alloc_workqueue Pan Bian
2017-04-26 9:03 ` [1/1] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).