* [PATCH] ASoC: Intel: Skylake: use dev in dev_err rather than skl pointer
@ 2017-04-27 15:13 Colin King
2017-04-27 22:38 ` Takashi Sakamoto
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-04-27 15:13 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Vinod Koul, Jeeja KP, Jayachandran B, Senthilnathan Veppur,
Colin Ian King, Ramesh Babu, Subhransu S . Prusty, G Kranthi,
alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The dev_err message is dereferencing an uininitialized skl pointer
which should be avoided. Don't use skl, use dev instead.
Detected by CoverityScan, CID#1432042 ("Uninitialized pointer read")
Fixes: 9fe9c71192832 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/soc/intel/skylake/bxt-sst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/bxt-sst.c b/sound/soc/intel/skylake/bxt-sst.c
index fde4bc0f35b0..f5e7dbb1ba39 100644
--- a/sound/soc/intel/skylake/bxt-sst.c
+++ b/sound/soc/intel/skylake/bxt-sst.c
@@ -564,7 +564,7 @@ int bxt_sst_dsp_init(struct device *dev, void __iomem *mmio_base, int irq,
ret = skl_sst_ctx_init(dev, irq, fw_name, dsp_ops, dsp, &skl_dev);
if (ret < 0) {
- dev_err(skl->dev, "%s: no device\n", __func__);
+ dev_err(dev, "%s: no device\n", __func__);
return ret;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: Intel: Skylake: use dev in dev_err rather than skl pointer
2017-04-27 15:13 [PATCH] ASoC: Intel: Skylake: use dev in dev_err rather than skl pointer Colin King
@ 2017-04-27 22:38 ` Takashi Sakamoto
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Sakamoto @ 2017-04-27 22:38 UTC (permalink / raw)
To: Colin King, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Vinod Koul, Jeeja KP, Jayachandran B,
Senthilnathan Veppur, Ramesh Babu, Subhransu S . Prusty,
G Kranthi, alsa-devel
Cc: kernel-janitors, linux-kernel
Hi,
On Apr 28 2017 00:13, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The dev_err message is dereferencing an uininitialized skl pointer
> which should be avoided. Don't use skl, use dev instead.
>
> Detected by CoverityScan, CID#1432042 ("Uninitialized pointer read")
>
> Fixes: 9fe9c71192832 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/intel/skylake/bxt-sst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/skylake/bxt-sst.c b/sound/soc/intel/skylake/bxt-sst.c
> index fde4bc0f35b0..f5e7dbb1ba39 100644
> --- a/sound/soc/intel/skylake/bxt-sst.c
> +++ b/sound/soc/intel/skylake/bxt-sst.c
> @@ -564,7 +564,7 @@ int bxt_sst_dsp_init(struct device *dev, void __iomem *mmio_base, int irq,
>
> ret = skl_sst_ctx_init(dev, irq, fw_name, dsp_ops, dsp, &skl_dev);
> if (ret < 0) {
> - dev_err(skl->dev, "%s: no device\n", __func__);
> + dev_err(dev, "%s: no device\n", __func__);
> return ret;
> }
Thanks for posting this patch, however Vinod already posted the same
fix. Please wait for merging it and verify again:
[alsa-devel] [PATCH 1/3] ASoC: Intel: Skylake: Fix uninitialized pointer
usage
http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/120214.html
Regards
Takashi Sakamoto
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-27 22:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 15:13 [PATCH] ASoC: Intel: Skylake: use dev in dev_err rather than skl pointer Colin King
2017-04-27 22:38 ` Takashi Sakamoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).