From: Johan Hovold <email@example.com>
To: Andreas Kemnade <firstname.lastname@example.org>
Cc: Johan Hovold <email@example.com>,
firstname.lastname@example.org, email@example.com, firstname.lastname@example.org,
Subject: Re: [PATCH] net: hso: register netdev later to avoid a race condition
Date: Fri, 28 Apr 2017 21:00:22 +0200 [thread overview]
Message-ID: <20170428190022.GV2823@localhost> (raw)
On Fri, Apr 28, 2017 at 07:36:29PM +0200, Andreas Kemnade wrote:
> On Thu, 27 Apr 2017 10:44:01 +0200
> Johan Hovold <email@example.com> wrote:
> > On Wed, Apr 26, 2017 at 07:26:40PM +0200, Andreas Kemnade wrote:
> > > If the netdev is accessed before the urbs are initialized,
> > > there will be NULL pointer dereferences. That is avoided by
> > > registering it when it is fully initialized.
> > > Reported-by: H. Nikolaus Schaller <firstname.lastname@example.org>
> > > Signed-off-by: Andreas Kemnade <email@example.com>
> > This all looks good, but you should consider cleaning up the error
> > handling of this function as a follow-up as we should not be
> > deregistering netdevs that have never been registered (e.g. if a
> > required endpoint is missing or if registration fails for some reason).
> > But just to be clear, this problem existed also before this change.
> Just to check wether I am understanding this correctly. In your opinion
> this patch is good for now. And later when it is applied, there should
> be an additional error handling cleanup patch.
Exactly; your patch is fine as is and the error-handling issue can be
next prev parent reply other threads:[~2017-04-28 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 17:26 [PATCH] net: hso: register netdev later to avoid a race condition Andreas Kemnade
2017-04-27 8:44 ` Johan Hovold
2017-04-28 17:36 ` Andreas Kemnade
2017-04-28 19:00 ` Johan Hovold [this message]
2017-04-28 20:12 ` David Miller
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).