* [PATCH] crypto: stm32 - fix building as a module
@ 2017-04-27 11:07 Arnd Bergmann
2017-04-29 17:54 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-04-27 11:07 UTC (permalink / raw)
To: Herbert Xu
Cc: Arnd Bergmann, David S. Miller, Maxime Coquelin,
Alexandre Torgue, Fabien DESSENNE, linux-crypto,
linux-arm-kernel, linux-kernel
The names in the MODULE_DEVICE_TABLE and the actual array don't match:
drivers/crypto/stm32/stm32_crc32.c:309:21: error: 'sti_dt_ids' undeclared here (not in a function); did you mean 'stm32_dt_ids'?
This changes the reference that was evidently copied incorrectly from
another driver.
Fixes: b51dbe90912a ("crypto: stm32 - Support for STM32 CRC32 crypto module")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/crypto/stm32/stm32_crc32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/stm32/stm32_crc32.c b/drivers/crypto/stm32/stm32_crc32.c
index 765282262d44..ec83b1e6bfe8 100644
--- a/drivers/crypto/stm32/stm32_crc32.c
+++ b/drivers/crypto/stm32/stm32_crc32.c
@@ -306,7 +306,7 @@ static const struct of_device_id stm32_dt_ids[] = {
{ .compatible = "st,stm32f7-crc", },
{},
};
-MODULE_DEVICE_TABLE(of, sti_dt_ids);
+MODULE_DEVICE_TABLE(of, stm32_dt_ids);
static struct platform_driver stm32_crc_driver = {
.probe = stm32_crc_probe,
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: stm32 - fix building as a module
2017-04-27 11:07 [PATCH] crypto: stm32 - fix building as a module Arnd Bergmann
@ 2017-04-29 17:54 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2017-04-29 17:54 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David S. Miller, Maxime Coquelin, Alexandre Torgue,
Fabien DESSENNE, linux-crypto, linux-arm-kernel, linux-kernel
On Thu, Apr 27, 2017 at 01:07:07PM +0200, Arnd Bergmann wrote:
> The names in the MODULE_DEVICE_TABLE and the actual array don't match:
>
> drivers/crypto/stm32/stm32_crc32.c:309:21: error: 'sti_dt_ids' undeclared here (not in a function); did you mean 'stm32_dt_ids'?
>
> This changes the reference that was evidently copied incorrectly from
> another driver.
>
> Fixes: b51dbe90912a ("crypto: stm32 - Support for STM32 CRC32 crypto module")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This has already been fixed by
https://patchwork.kernel.org/patch/9698299/
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-29 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 11:07 [PATCH] crypto: stm32 - fix building as a module Arnd Bergmann
2017-04-29 17:54 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).