From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Han Xu <xhnjupt@gmail.com>
Cc: Stefan Agner <stefan@agner.ch>,
Marek Vasut <marek.vasut@gmail.com>,
mark.rutland@arm.com, Fabio Estevam <fabio.estevam@freescale.com>,
devicetree@vger.kernel.org, Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Sascha Hauer <kernel@pengutronix.de>, Han Xu <han.xu@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org, LW@karo-electronics.de
Subject: Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support
Date: Tue, 2 May 2017 11:17:58 +0200 [thread overview]
Message-ID: <20170502111758.53e9a959@bbrezillon> (raw)
In-Reply-To: <CA+EcR20FCPSec+ihTMA=SGwogd7p5tsnECCp3CR-Nv6fUciK4g@mail.gmail.com>
Hi Han,
On Fri, 21 Apr 2017 13:29:16 -0500
Han Xu <xhnjupt@gmail.com> wrote:
> >>
> >>>>> But then, adding the type would only require 2-3 lines of change if I
> >>>>> add it to the GPMI_IS_MX6 macro...
> >>>>
> >>>> Then at least add a comment because using type = IMX6SX right under
> >>>> gpmi_data_mx7d can trigger some head-scratching. And put my R-B on V2.
> >>>
> >>> FWIW, I mentioned it in the commit message.
> >>>
> >>> I think rather then adding a comment it is cleaner to just add IS_IMX7D
> >>> and add it to the GPMI_IS_MX6 macro. That does not need a comment since
> >>> it implicitly says we have a i.MX 7 but treat it like i.MX 6 and it is a
> >>> rather small change. Does that sound acceptable?
> >>
> >> Sure, that's even better, thanks.
> >>
> >> btw isn't there some single-core mx7 (mx7s ?) , maybe we should just go
> >> with mx7 (without the d suffix). I dunno if it has GPMI NAND though, so
> >> maybe mx7d is the right thing to do here ...
> >>
> >
> > There is a Solo version yes, and it has GPMI NAND too. However, almost
> > all i.MX 7 IPs have been named imx7d by NXP for some reason (including
> > compatible strings, see grep -r -e imx7 Documentation/), so I thought I
> > stay consistent here...
>
> Hi Guys,
>
> Yes, there should be a i.MX7 Solo version with one core fused out. IMO, can
> we use QUIRK to distinguish them rather than SoC name. I know I also sent
> some patch set with SoC Name but I prefer to use QUIRK now.
Not sure what this means. Are you okay with Stefan's v2?
Regards,
Boris
next prev parent reply other threads:[~2017-05-02 9:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 1:07 [PATCH 0/5] mtd: nand: gpmi: add i.MX 7 support Stefan Agner
2017-04-21 1:07 ` [PATCH 1/5] mtd: nand: gpmi: unify clock handling Stefan Agner
2017-04-21 2:02 ` Marek Vasut
2017-04-21 1:07 ` [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support Stefan Agner
2017-04-21 2:03 ` Marek Vasut
2017-04-21 3:15 ` Stefan Agner
2017-04-21 13:08 ` Marek Vasut
2017-04-21 16:19 ` Stefan Agner
2017-04-21 17:22 ` Marek Vasut
2017-04-21 17:38 ` Stefan Agner
2017-04-21 18:29 ` Han Xu
2017-05-02 9:17 ` Boris Brezillon [this message]
2017-05-02 11:18 ` Marek Vasut
2017-05-03 21:24 ` Stefan Agner
2017-04-21 1:07 ` [PATCH 3/5] mtd: gpmi: document current clock requirements Stefan Agner
2017-04-21 1:07 ` [PATCH 4/5] ARM: dts: imx7: add GPMI NAND Stefan Agner
2017-04-21 1:07 ` [PATCH 5/5] ARM: dts: imx7-colibri: add NAND support Stefan Agner
2017-04-21 2:33 ` [PATCH 0/5] mtd: nand: gpmi: add i.MX 7 support Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502111758.53e9a959@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=LW@karo-electronics.de \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@freescale.com \
--cc=han.xu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=xhnjupt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).