From: Marek Vasut <marek.vasut@gmail.com>
To: Stefan Agner <stefan@agner.ch>,
dwmw2@infradead.org, computersforpeace@gmail.com,
boris.brezillon@free-electrons.com, richard@nod.at,
cyrille.pitchen@atmel.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org,
kernel@pengutronix.de, han.xu@nxp.com,
fabio.estevam@freescale.com, LW@KARO-electronics.de,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] mtd: nand: gpmi: unify clock handling
Date: Fri, 21 Apr 2017 04:02:03 +0200 [thread overview]
Message-ID: <66b18c07-54f1-a532-5fce-e1759c5d3488@gmail.com> (raw)
In-Reply-To: <20170421010755.18025-2-stefan@agner.ch>
On 04/21/2017 03:07 AM, Stefan Agner wrote:
> Add device specific list of clocks required, and handle all clocks
> in a single for loop. This avoids further code duplication when
> adding i.MX 7 support.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
[...]
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.h b/drivers/mtd/nand/gpmi-nand/gpmi-nand.h
> index 4e49a1f5fa27..2e584e18d980 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.h
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.h
> @@ -130,6 +130,8 @@ struct gpmi_devdata {
> enum gpmi_type type;
> int bch_max_ecc_strength;
> int max_chain_delay; /* See the async EDO mode */
> + const char * const *clks;
> + int clks_count;
const int ? :)
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-04-21 2:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 1:07 [PATCH 0/5] mtd: nand: gpmi: add i.MX 7 support Stefan Agner
2017-04-21 1:07 ` [PATCH 1/5] mtd: nand: gpmi: unify clock handling Stefan Agner
2017-04-21 2:02 ` Marek Vasut [this message]
2017-04-21 1:07 ` [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support Stefan Agner
2017-04-21 2:03 ` Marek Vasut
2017-04-21 3:15 ` Stefan Agner
2017-04-21 13:08 ` Marek Vasut
2017-04-21 16:19 ` Stefan Agner
2017-04-21 17:22 ` Marek Vasut
2017-04-21 17:38 ` Stefan Agner
2017-04-21 18:29 ` Han Xu
2017-05-02 9:17 ` Boris Brezillon
2017-05-02 11:18 ` Marek Vasut
2017-05-03 21:24 ` Stefan Agner
2017-04-21 1:07 ` [PATCH 3/5] mtd: gpmi: document current clock requirements Stefan Agner
2017-04-21 1:07 ` [PATCH 4/5] ARM: dts: imx7: add GPMI NAND Stefan Agner
2017-04-21 1:07 ` [PATCH 5/5] ARM: dts: imx7-colibri: add NAND support Stefan Agner
2017-04-21 2:33 ` [PATCH 0/5] mtd: nand: gpmi: add i.MX 7 support Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66b18c07-54f1-a532-5fce-e1759c5d3488@gmail.com \
--to=marek.vasut@gmail.com \
--cc=LW@KARO-electronics.de \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@freescale.com \
--cc=han.xu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).