From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: icenowy@aosc.io
Cc: Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com, linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH v5 01/10] arm64: allwinner: a64: enable RSB on A64
Date: Tue, 2 May 2017 13:22:08 +0200 [thread overview]
Message-ID: <20170502112208.km7q4inncospx673@lukather> (raw)
In-Reply-To: <4f910cd7ab972c1b6d93b0327833b596@aosc.io>
[-- Attachment #1: Type: text/plain, Size: 2018 bytes --]
On Fri, Apr 28, 2017 at 02:14:58AM +0800, icenowy@aosc.io wrote:
> 在 2017-04-27 21:28,Maxime Ripard 写道:
> > On Wed, Apr 26, 2017 at 11:20:14PM +0800, Icenowy Zheng wrote:
> > > Allwinner A64 have a RSB controller like the one on A23/A33 SoCs.
> > >
> > > Add it and its pinmux.
> > >
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > Acked-by: Chen-Yu Tsai <wens@csie.org>
> > > ---
> > > Changes in v2:
> > > - Removed bonus properties in pio node.
> > > - Added Chen-Yu's ACK.
> > >
> > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 19
> > > +++++++++++++++++++
> > > 1 file changed, 19 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > > index c7f669f5884f..05ec9fc5e81f 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > > @@ -422,6 +422,25 @@
> > > #gpio-cells = <3>;
> > > interrupt-controller;
> > > #interrupt-cells = <3>;
> > > +
> > > + r_rsb_pins: rsb@0 {
> > > + pins = "PL0", "PL1";
> > > + function = "s_rsb";
> > > + };
> > > + };
> > > +
> > > + r_rsb: rsb@1f03400 {
> > > + compatible = "allwinner,sun8i-a23-rsb";
> > > + reg = <0x01f03400 0x400>;
> > > + interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> > > + clocks = <&r_ccu 6>;
> >
> > Please use the defines here..
>
> Linux-4.12 doesn't yet enter rc1, and the defines are still not in
> Linus's tree.
>
> Please note that I have already mentioned that this patch is necessary
> to be merged into 4.12, otherwise poweroff won't work properly at 4.12 .
This is too late for 4.12. We don't merge any patch two weeks before
the merge window opens, which makes it around -rc6. This will be 4.13
material, so we'll definitely have the defines by then.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-05-02 11:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 15:20 [PATCH v5 00/10] AXP803 PMIC support for Pine64 Icenowy Zheng
2017-04-26 15:20 ` [PATCH v5 01/10] arm64: allwinner: a64: enable RSB on A64 Icenowy Zheng
2017-04-27 13:28 ` Maxime Ripard
2017-04-27 18:14 ` icenowy
2017-05-02 11:22 ` Maxime Ripard [this message]
2017-04-26 15:20 ` [PATCH v5 02/10] irqchip/sunxi-nmi: add A64 R_INTC to the binding doc Icenowy Zheng
2017-04-28 20:51 ` Rob Herring
2017-04-26 15:20 ` [PATCH v5 03/10] irqchip/sunxi-nmi: add support for the NMI in A64 R_INTC Icenowy Zheng
2017-04-26 15:20 ` [PATCH v5 04/10] arm64: allwinner: a64: add NMI (R_INTC) controller on A64 Icenowy Zheng
2017-04-26 15:20 ` [PATCH v5 05/10] arm64: allwinner: a64: add AXP803 node to Pine64 device tree Icenowy Zheng
2017-04-26 15:20 ` [PATCH v5 06/10] regulator: axp20x-regulator: add support for AXP803 Icenowy Zheng
2017-05-19 17:04 ` Applied "regulator: axp20x-regulator: add support for AXP803" to the regulator tree Mark Brown
2017-04-26 15:20 ` [PATCH v5 07/10] mfd: axp20x: add axp20x-regulator cell for AXP803 Icenowy Zheng
2017-04-26 15:20 ` [PATCH v5 08/10] arm64: allwinner: a64: add DTSI file for AXP803 PMIC Icenowy Zheng
2017-04-26 15:20 ` [PATCH v5 09/10] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Icenowy Zheng
2017-04-26 15:20 ` [PATCH v5 10/10] arm64: allwinner: a64: enable Wi-Fi " Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502112208.km7q4inncospx673@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).