From: Yury Norov <ynorov@caviumnetworks.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Will Deacon <will.deacon@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Adam Wallis <awallis@codeaurora.org>,
Andrew Pinski <Andrew.Pinski@cavium.com>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Ingo Molnar <mingo@redhat.com>, Jan Glauber <jglauber@cavium.com>,
Mark Rutland <mark.rutland@arm.com>,
Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/3] kernel/locking: #include <asm/spinlock.h> in qrwlock.c
Date: Wed, 3 May 2017 23:32:09 +0300 [thread overview]
Message-ID: <20170503203209.ilcifmyqxkv2igq3@yury-N73SV> (raw)
In-Reply-To: <CAMuHMdXks7pXcg+MNvqYyRWHf-WUrNWLrG8GcPWy8ho49Wx7ug@mail.gmail.com>
On Wed, May 03, 2017 at 05:05:29PM +0200, Geert Uytterhoeven wrote:
> On Wed, May 3, 2017 at 4:51 PM, Yury Norov <ynorov@caviumnetworks.com> wrote:
> > --- a/kernel/locking/qrwlock.c
> > +++ b/kernel/locking/qrwlock.c
> > @@ -20,6 +20,7 @@
> > #include <linux/cpumask.h>
> > #include <linux/percpu.h>
> > #include <linux/hardirq.h>
> > +#include <asm/spinlock.h>
>
> linux/spinlock.h?
Comment in include/linux/spinlock.h says:
* here's the role of the various spinlock/rwlock related include
* files:
*
* on SMP builds:
*
[...]
* asm/spinlock.h: contains the arch_spin_*()/etc. lowlevel
* implementations, mostly inline assembly code
*
This, and the fact that include/asm-generic/spinlock.h and
arch/arm64/include/asm/spinlock.h doesn't prevent the direct
inclusion means, for me, that I should include asm/spinlock.h,
because of all that I need only arch_spin_lock() and arch_spin_unlock().
Am I wrong?
Yury
next prev parent reply other threads:[~2017-05-03 20:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 14:51 [PATCH 0/3] arm64: queued spinlocks and rw-locks Yury Norov
2017-05-03 14:51 ` [PATCH 1/3] kernel/locking: #include <asm/spinlock.h> in qrwlock.c Yury Norov
2017-05-03 15:05 ` Geert Uytterhoeven
2017-05-03 20:32 ` Yury Norov [this message]
2017-05-03 14:51 ` [PATCH 2/3] asm-generic: don't #include <linux/atomic.h> in qspinlock_types.h Yury Norov
2017-05-04 8:01 ` Arnd Bergmann
2017-05-03 14:51 ` [PATCH 3/3] arm64/locking: qspinlocks and qrwlocks support Yury Norov
2017-05-09 4:47 ` Boqun Feng
2017-05-09 18:48 ` Yury Norov
2017-05-09 19:37 ` Yury Norov
[not found] ` <SIXPR0199MB0604CF9C101455F7D7417FF7C5160@SIXPR0199MB0604.apcprd01.prod.exchangelabs.com>
2017-05-04 20:28 ` 答复: [PATCH 0/3] arm64: queued spinlocks and rw-locks Yury Norov
2017-05-05 11:53 ` Peter Zijlstra
2017-05-05 12:26 ` Will Deacon
2017-05-05 15:28 ` Yury Norov
2017-05-05 15:32 ` Will Deacon
-- strict thread matches above, loose matches on Subject: below --
2017-04-10 21:35 [RFC PATCH " Yury Norov
2017-04-10 21:35 ` [PATCH 1/3] kernel/locking: #include <asm/spinlock.h> in qrwlock.c Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503203209.ilcifmyqxkv2igq3@yury-N73SV \
--to=ynorov@caviumnetworks.com \
--cc=Andrew.Pinski@cavium.com \
--cc=arnd@arndb.de \
--cc=awallis@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=geert@linux-m68k.org \
--cc=jglauber@cavium.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
--cc=xinhui.pan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).