* [PATCH] staging: typec: fusb302: Fix module autoload
@ 2017-05-04 6:33 Javier Martinez Canillas
2017-05-04 18:06 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2017-05-04 6:33 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, devel, Guenter Roeck, Yueyao Zhu,
Greg Kroah-Hartman
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the OF and I2C device ID table entries as module aliases, using the
MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/staging/typec/fusb302/fusb302.ko | grep alias
$
After this patch:
$ modinfo drivers/staging/typec/fusb302/fusb302.ko | grep alias
alias: of:N*T*Cfcs,fusb302C*
alias: of:N*T*Cfcs,fusb302
alias: i2c:typec_fusb302
Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
---
drivers/staging/typec/fusb302/fusb302.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
index 2cee9a952c9b..aa460f93a293 100644
--- a/drivers/staging/typec/fusb302/fusb302.c
+++ b/drivers/staging/typec/fusb302/fusb302.c
@@ -1787,11 +1787,13 @@ static const struct of_device_id fusb302_dt_match[] = {
{.compatible = "fcs,fusb302"},
{},
};
+MODULE_DEVICE_TABLE(of, fusb302_dt_match);
static const struct i2c_device_id fusb302_i2c_device_id[] = {
{"typec_fusb302", 0},
{},
};
+MODULE_DEVICE_TABLE(i2c, fusb302_i2c_device_id);
static const struct dev_pm_ops fusb302_pm_ops = {
.suspend = fusb302_pm_suspend,
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: typec: fusb302: Fix module autoload
2017-05-04 6:33 [PATCH] staging: typec: fusb302: Fix module autoload Javier Martinez Canillas
@ 2017-05-04 18:06 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2017-05-04 18:06 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, devel, Yueyao Zhu, Greg Kroah-Hartman
On Thu, May 04, 2017 at 08:33:45AM +0200, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the OF and I2C device ID table entries as module aliases, using the
> MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/staging/typec/fusb302/fusb302.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/staging/typec/fusb302/fusb302.ko | grep alias
> alias: of:N*T*Cfcs,fusb302C*
> alias: of:N*T*Cfcs,fusb302
> alias: i2c:typec_fusb302
>
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
Thanks, queued.
Guenter
> ---
>
> drivers/staging/typec/fusb302/fusb302.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
> index 2cee9a952c9b..aa460f93a293 100644
> --- a/drivers/staging/typec/fusb302/fusb302.c
> +++ b/drivers/staging/typec/fusb302/fusb302.c
> @@ -1787,11 +1787,13 @@ static const struct of_device_id fusb302_dt_match[] = {
> {.compatible = "fcs,fusb302"},
> {},
> };
> +MODULE_DEVICE_TABLE(of, fusb302_dt_match);
>
> static const struct i2c_device_id fusb302_i2c_device_id[] = {
> {"typec_fusb302", 0},
> {},
> };
> +MODULE_DEVICE_TABLE(i2c, fusb302_i2c_device_id);
>
> static const struct dev_pm_ops fusb302_pm_ops = {
> .suspend = fusb302_pm_suspend,
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-04 18:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-04 6:33 [PATCH] staging: typec: fusb302: Fix module autoload Javier Martinez Canillas
2017-05-04 18:06 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).