From: Oleg Nesterov <oleg@redhat.com>
To: Jamie Iles <jamie.iles@oracle.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.
Date: Fri, 5 May 2017 18:26:07 +0200 [thread overview]
Message-ID: <20170505162606.GA32256@redhat.com> (raw)
In-Reply-To: <20170504125136.11352-1-jamie.iles@oracle.com>
Hi Jamie,
I am sorry for being slow... yes, probably we should start with this
simple change, and perhaps we do not really need anything else. But
let me think about this till Monday, perhaps we can remove this "clear
SIGNAL_UNKILLABLE" logic in force_sig_info() altogether.
On 05/04, Jamie Iles wrote:
>
> When forcing a signal, SIGNAL_UNKILLABLE is removed to prevent recursive
> faults, but this is undesirable when tracing. For example, debugging an
> init process (whether global or namespace), hitting a breakpoint and
> SIGTRAP will force SIGTRAP and then remove SIGNAL_UNKILLABLE.
> Everything continues fine, but then once debugging has finished, the
> init process is left killable which is unlikely what the user expects,
> resulting in either an accidentally killed init or an init that stops
> reaping zombies.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Signed-off-by: Jamie Iles <jamie.iles@oracle.com>
> ---
> kernel/signal.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 7e59ebc2c25e..5516a0cda668 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -1185,7 +1185,11 @@ force_sig_info(int sig, struct siginfo *info, struct task_struct *t)
> recalc_sigpending_and_wake(t);
> }
> }
> - if (action->sa.sa_handler == SIG_DFL)
> + /*
> + * Don't clear SIGNAL_UNKILLABLE for traced tasks, users won't expect
> + * debugging to leave init killable.
> + */
> + if (action->sa.sa_handler == SIG_DFL && !t->ptrace)
> t->signal->flags &= ~SIGNAL_UNKILLABLE;
> ret = specific_send_sig_info(sig, info, t);
> spin_unlock_irqrestore(&t->sighand->siglock, flags);
> --
> 2.12.0.rc0
>
next prev parent reply other threads:[~2017-05-05 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 12:51 [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks Jamie Iles
2017-05-05 16:26 ` Oleg Nesterov [this message]
2017-05-05 16:34 ` Jamie Iles
2017-06-08 10:07 ` Jamie Iles
2017-08-15 11:28 Jamie Iles
2017-08-15 16:16 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170505162606.GA32256@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jamie.iles@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).