* [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.
@ 2017-05-04 12:51 Jamie Iles
2017-05-05 16:26 ` Oleg Nesterov
0 siblings, 1 reply; 6+ messages in thread
From: Jamie Iles @ 2017-05-04 12:51 UTC (permalink / raw)
To: linux-kernel, oleg; +Cc: Jamie Iles, Andrew Morton
When forcing a signal, SIGNAL_UNKILLABLE is removed to prevent recursive
faults, but this is undesirable when tracing. For example, debugging an
init process (whether global or namespace), hitting a breakpoint and
SIGTRAP will force SIGTRAP and then remove SIGNAL_UNKILLABLE.
Everything continues fine, but then once debugging has finished, the
init process is left killable which is unlikely what the user expects,
resulting in either an accidentally killed init or an init that stops
reaping zombies.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Jamie Iles <jamie.iles@oracle.com>
---
kernel/signal.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index 7e59ebc2c25e..5516a0cda668 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1185,7 +1185,11 @@ force_sig_info(int sig, struct siginfo *info, struct task_struct *t)
recalc_sigpending_and_wake(t);
}
}
- if (action->sa.sa_handler == SIG_DFL)
+ /*
+ * Don't clear SIGNAL_UNKILLABLE for traced tasks, users won't expect
+ * debugging to leave init killable.
+ */
+ if (action->sa.sa_handler == SIG_DFL && !t->ptrace)
t->signal->flags &= ~SIGNAL_UNKILLABLE;
ret = specific_send_sig_info(sig, info, t);
spin_unlock_irqrestore(&t->sighand->siglock, flags);
--
2.12.0.rc0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.
2017-05-04 12:51 [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks Jamie Iles
@ 2017-05-05 16:26 ` Oleg Nesterov
2017-05-05 16:34 ` Jamie Iles
2017-06-08 10:07 ` Jamie Iles
0 siblings, 2 replies; 6+ messages in thread
From: Oleg Nesterov @ 2017-05-05 16:26 UTC (permalink / raw)
To: Jamie Iles; +Cc: linux-kernel, Andrew Morton
Hi Jamie,
I am sorry for being slow... yes, probably we should start with this
simple change, and perhaps we do not really need anything else. But
let me think about this till Monday, perhaps we can remove this "clear
SIGNAL_UNKILLABLE" logic in force_sig_info() altogether.
On 05/04, Jamie Iles wrote:
>
> When forcing a signal, SIGNAL_UNKILLABLE is removed to prevent recursive
> faults, but this is undesirable when tracing. For example, debugging an
> init process (whether global or namespace), hitting a breakpoint and
> SIGTRAP will force SIGTRAP and then remove SIGNAL_UNKILLABLE.
> Everything continues fine, but then once debugging has finished, the
> init process is left killable which is unlikely what the user expects,
> resulting in either an accidentally killed init or an init that stops
> reaping zombies.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Signed-off-by: Jamie Iles <jamie.iles@oracle.com>
> ---
> kernel/signal.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 7e59ebc2c25e..5516a0cda668 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -1185,7 +1185,11 @@ force_sig_info(int sig, struct siginfo *info, struct task_struct *t)
> recalc_sigpending_and_wake(t);
> }
> }
> - if (action->sa.sa_handler == SIG_DFL)
> + /*
> + * Don't clear SIGNAL_UNKILLABLE for traced tasks, users won't expect
> + * debugging to leave init killable.
> + */
> + if (action->sa.sa_handler == SIG_DFL && !t->ptrace)
> t->signal->flags &= ~SIGNAL_UNKILLABLE;
> ret = specific_send_sig_info(sig, info, t);
> spin_unlock_irqrestore(&t->sighand->siglock, flags);
> --
> 2.12.0.rc0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.
2017-05-05 16:26 ` Oleg Nesterov
@ 2017-05-05 16:34 ` Jamie Iles
2017-06-08 10:07 ` Jamie Iles
1 sibling, 0 replies; 6+ messages in thread
From: Jamie Iles @ 2017-05-05 16:34 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Jamie Iles, linux-kernel, Andrew Morton
Hi Oleg,
On Fri, May 05, 2017 at 06:26:07PM +0200, Oleg Nesterov wrote:
> I am sorry for being slow... yes, probably we should start with this
> simple change, and perhaps we do not really need anything else. But
> let me think about this till Monday, perhaps we can remove this "clear
> SIGNAL_UNKILLABLE" logic in force_sig_info() altogether.
No problem, I sent the patch to keep it on my own radar :)
Jamie
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.
2017-05-05 16:26 ` Oleg Nesterov
2017-05-05 16:34 ` Jamie Iles
@ 2017-06-08 10:07 ` Jamie Iles
1 sibling, 0 replies; 6+ messages in thread
From: Jamie Iles @ 2017-06-08 10:07 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Jamie Iles, linux-kernel, Andrew Morton
Hi Oleg,
On Fri, May 05, 2017 at 06:26:07PM +0200, Oleg Nesterov wrote:
> Hi Jamie,
>
> I am sorry for being slow... yes, probably we should start with this
> simple change, and perhaps we do not really need anything else. But
> let me think about this till Monday, perhaps we can remove this "clear
> SIGNAL_UNKILLABLE" logic in force_sig_info() altogether.
I was wondering if you had given this any more thought?
Thanks,
Jamie
> On 05/04, Jamie Iles wrote:
> >
> > When forcing a signal, SIGNAL_UNKILLABLE is removed to prevent recursive
> > faults, but this is undesirable when tracing. For example, debugging an
> > init process (whether global or namespace), hitting a breakpoint and
> > SIGTRAP will force SIGTRAP and then remove SIGNAL_UNKILLABLE.
> > Everything continues fine, but then once debugging has finished, the
> > init process is left killable which is unlikely what the user expects,
> > resulting in either an accidentally killed init or an init that stops
> > reaping zombies.
> >
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Oleg Nesterov <oleg@redhat.com>
> > Signed-off-by: Jamie Iles <jamie.iles@oracle.com>
> > ---
> > kernel/signal.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/kernel/signal.c b/kernel/signal.c
> > index 7e59ebc2c25e..5516a0cda668 100644
> > --- a/kernel/signal.c
> > +++ b/kernel/signal.c
> > @@ -1185,7 +1185,11 @@ force_sig_info(int sig, struct siginfo *info, struct task_struct *t)
> > recalc_sigpending_and_wake(t);
> > }
> > }
> > - if (action->sa.sa_handler == SIG_DFL)
> > + /*
> > + * Don't clear SIGNAL_UNKILLABLE for traced tasks, users won't expect
> > + * debugging to leave init killable.
> > + */
> > + if (action->sa.sa_handler == SIG_DFL && !t->ptrace)
> > t->signal->flags &= ~SIGNAL_UNKILLABLE;
> > ret = specific_send_sig_info(sig, info, t);
> > spin_unlock_irqrestore(&t->sighand->siglock, flags);
> > --
> > 2.12.0.rc0
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.
@ 2017-08-15 11:28 Jamie Iles
2017-08-15 16:16 ` Oleg Nesterov
0 siblings, 1 reply; 6+ messages in thread
From: Jamie Iles @ 2017-08-15 11:28 UTC (permalink / raw)
To: linux-kernel, oleg; +Cc: Jamie Iles, Andrew Morton
When forcing a signal, SIGNAL_UNKILLABLE is removed to prevent recursive
faults, but this is undesirable when tracing. For example, debugging an
init process (whether global or namespace), hitting a breakpoint and
SIGTRAP will force SIGTRAP and then remove SIGNAL_UNKILLABLE.
Everything continues fine, but then once debugging has finished, the
init process is left killable which is unlikely what the user expects,
resulting in either an accidentally killed init or an init that stops
reaping zombies.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Jamie Iles <jamie.iles@oracle.com>
---
kernel/signal.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index 7e33f8c583e6..ed804a470dcd 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1194,7 +1194,11 @@ force_sig_info(int sig, struct siginfo *info, struct task_struct *t)
recalc_sigpending_and_wake(t);
}
}
- if (action->sa.sa_handler == SIG_DFL)
+ /*
+ * Don't clear SIGNAL_UNKILLABLE for traced tasks, users won't expect
+ * debugging to leave init killable.
+ */
+ if (action->sa.sa_handler == SIG_DFL && !t->ptrace)
t->signal->flags &= ~SIGNAL_UNKILLABLE;
ret = specific_send_sig_info(sig, info, t);
spin_unlock_irqrestore(&t->sighand->siglock, flags);
--
2.13.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.
2017-08-15 11:28 Jamie Iles
@ 2017-08-15 16:16 ` Oleg Nesterov
0 siblings, 0 replies; 6+ messages in thread
From: Oleg Nesterov @ 2017-08-15 16:16 UTC (permalink / raw)
To: Jamie Iles; +Cc: linux-kernel, Andrew Morton
On 08/15, Jamie Iles wrote:
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -1194,7 +1194,11 @@ force_sig_info(int sig, struct siginfo *info, struct task_struct *t)
> recalc_sigpending_and_wake(t);
> }
> }
> - if (action->sa.sa_handler == SIG_DFL)
> + /*
> + * Don't clear SIGNAL_UNKILLABLE for traced tasks, users won't expect
> + * debugging to leave init killable.
> + */
> + if (action->sa.sa_handler == SIG_DFL && !t->ptrace)
> t->signal->flags &= ~SIGNAL_UNKILLABLE;
> ret = specific_send_sig_info(sig, info, t);
> spin_unlock_irqrestore(&t->sighand->siglock, flags);
Acked-by: Oleg Nesterov <oleg@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-15 16:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-04 12:51 [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks Jamie Iles
2017-05-05 16:26 ` Oleg Nesterov
2017-05-05 16:34 ` Jamie Iles
2017-06-08 10:07 ` Jamie Iles
2017-08-15 11:28 Jamie Iles
2017-08-15 16:16 ` Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).