From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gideon Sheril <elmocia@gmail.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
rvarsha016@gmail.com, julia.lawall@lip6.fr, alan@linux.intel.com,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/media/atomisp/platform/intel-mid change spaces to tabs and comma/assignment space padding
Date: Sat, 6 May 2017 05:09:52 +0300 [thread overview]
Message-ID: <20170506020952.wzfx2wefmwzxja3d@mwanda> (raw)
In-Reply-To: <1494032690-12302-1-git-send-email-elmocia@gmail.com>
Subject is too long.
On Sat, May 06, 2017 at 04:04:50AM +0300, Gideon Sheril wrote:
> /* The atomisp uses type==0 for the end-of-list marker, so leave space. */
> @@ -152,13 +152,13 @@ const struct camera_af_platform_data *camera_get_af_platform_data(void)
> EXPORT_SYMBOL_GPL(camera_get_af_platform_data);
>
> int atomisp_register_i2c_module(struct v4l2_subdev *subdev,
> - struct camera_sensor_platform_data *plat_data,
> - enum intel_v4l2_subdev_type type)
> + struct camera_sensor_platform_data *plat_data,
> + enum intel_v4l2_subdev_type type)
Huh???
> {
> int i;
> struct i2c_board_info *bi;
> struct gmin_subdev *gs;
> - struct i2c_client *client = v4l2_get_subdevdata(subdev);
> + struct i2c_client *client = v4l2_get_subdevdata(subdev);
Wut? How would this be correct?
regards,
dan carpenter
next prev parent reply other threads:[~2017-05-06 2:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 1:04 [PATCH] staging/media/atomisp/platform/intel-mid change spaces to tabs and comma/assignment space padding Gideon Sheril
2017-05-06 2:09 ` Dan Carpenter [this message]
2017-05-06 12:56 ` [PATCH] Fix spaces ERROR in atomisp_gmin_platform.c Gideon Sheril
2017-05-07 5:52 ` Dan Carpenter
2017-05-08 17:08 ` [PATCH v3] staging: media: atomisp: Fix indentation to tabs Gideon Sheril
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170506020952.wzfx2wefmwzxja3d@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=elmocia@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).