From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gideon Sheril <elmocia@gmail.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
rvarsha016@gmail.com, julia.lawall@lip6.fr, alan@linux.intel.com,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix spaces ERROR in atomisp_gmin_platform.c
Date: Sun, 7 May 2017 08:52:40 +0300 [thread overview]
Message-ID: <20170507055240.562dz4hzjllicto7@mwanda> (raw)
In-Reply-To: <1494075383-8682-1-git-send-email-elmocia@gmail.com>
On Sat, May 06, 2017 at 03:56:23PM +0300, Gideon Sheril wrote:
> int atomisp_register_i2c_module(struct v4l2_subdev *subdev,
> - struct camera_sensor_platform_data *plat_data,
> - enum intel_v4l2_subdev_type type)
> + struct camera_sensor_platform_data *plat_data,
> + enum intel_v4l2_subdev_type type)
It was aligned properly before, it just used spaces instead of tabs.
> + dev_info(&client->dev,
> + "camera pdata: port: %d lanes: %d order: %8.8x\n",
> + port, lanes, bayer_order);
This introduces a checkpatch.pl warning. Do it like this:
[tab][tab][tab][space]"camera pdata: port: %d lanes: %d order: %8.8x\n",
regards,
dan carpenter
next prev parent reply other threads:[~2017-05-07 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 1:04 [PATCH] staging/media/atomisp/platform/intel-mid change spaces to tabs and comma/assignment space padding Gideon Sheril
2017-05-06 2:09 ` Dan Carpenter
2017-05-06 12:56 ` [PATCH] Fix spaces ERROR in atomisp_gmin_platform.c Gideon Sheril
2017-05-07 5:52 ` Dan Carpenter [this message]
2017-05-08 17:08 ` [PATCH v3] staging: media: atomisp: Fix indentation to tabs Gideon Sheril
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170507055240.562dz4hzjllicto7@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=elmocia@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).