* [4.12.0-rc0]: compile error in initramfs.c
@ 2017-05-06 15:40 Jörg Otte
2017-05-06 17:27 ` Linus Torvalds
[not found] ` <aadd0898-c03c-247a-a19a-648c8faad24c@infradead.org>
0 siblings, 2 replies; 4+ messages in thread
From: Jörg Otte @ 2017-05-06 15:40 UTC (permalink / raw)
To: Stafford Horne, Linux Kernel Mailing List, viro, Linus Torvalds
In kernel 4.11.0-10502-g3ef2bc0 I get following compile error:
/kernel/linux/init/initramfs.c: In function 'populate_rootfs':
/kernel/linux/init/initramfs.c:644:2: error: label at end of compound statement
done:
the compile error goes away if I revert
commit 17a9be31747535184f2af156b1f080ec4c92a952
"initramfs: Always do fput() and load modules after rootfs populate"
Thanks
Jörg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [4.12.0-rc0]: compile error in initramfs.c
2017-05-06 15:40 [4.12.0-rc0]: compile error in initramfs.c Jörg Otte
@ 2017-05-06 17:27 ` Linus Torvalds
[not found] ` <aadd0898-c03c-247a-a19a-648c8faad24c@infradead.org>
1 sibling, 0 replies; 4+ messages in thread
From: Linus Torvalds @ 2017-05-06 17:27 UTC (permalink / raw)
To: Jörg Otte; +Cc: Stafford Horne, Linux Kernel Mailing List, Al Viro
On Sat, May 6, 2017 at 8:40 AM, Jörg Otte <jrg.otte@gmail.com> wrote:
> In kernel 4.11.0-10502-g3ef2bc0 I get following compile error:
>
> /kernel/linux/init/initramfs.c: In function 'populate_rootfs':
> /kernel/linux/init/initramfs.c:644:2: error: label at end of compound statement
> done:
Ok,need to add an empty statement there.
I wonder why I didn't see that warning.
.. oh, it's because even my allmodconfig build just ends up having
CONFIG_BLK_DEV_RAM=m
rather than the built-in case.
Will fix.
Linus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [4.12.0-rc0]: compile error in initramfs.c
[not found] ` <aadd0898-c03c-247a-a19a-648c8faad24c@infradead.org>
@ 2017-05-06 17:39 ` Linus Torvalds
2017-05-06 18:53 ` Stafford Horne
0 siblings, 1 reply; 4+ messages in thread
From: Linus Torvalds @ 2017-05-06 17:39 UTC (permalink / raw)
To: Randy Dunlap
Cc: Jörg Otte, Stafford Horne, Linux Kernel Mailing List, Al Viro
On Sat, May 6, 2017 at 10:28 AM, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> A fix was posted here:
> http://marc.info/?l=linux-kernel&m=149405418520059&w=2
That looks like it will just cause a warning instead ("unused label").
The proper fix is to just add an empty statement. Pushing that out.
Linus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [4.12.0-rc0]: compile error in initramfs.c
2017-05-06 17:39 ` Linus Torvalds
@ 2017-05-06 18:53 ` Stafford Horne
0 siblings, 0 replies; 4+ messages in thread
From: Stafford Horne @ 2017-05-06 18:53 UTC (permalink / raw)
To: Linus Torvalds
Cc: Randy Dunlap, Jörg Otte, Linux Kernel Mailing List, Al Viro
On Sat, May 06, 2017 at 10:39:01AM -0700, Linus Torvalds wrote:
> On Sat, May 6, 2017 at 10:28 AM, Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > A fix was posted here:
> > http://marc.info/?l=linux-kernel&m=149405418520059&w=2
>
> That looks like it will just cause a warning instead ("unused label").
>
> The proper fix is to just add an empty statement. Pushing that out.
Thanks for getting that pushed out already, I was just about to send out my
patch. Yours is better as I didnt like moving that label out of the block
and being an unused label.
I guess this is my first brown paper bag bug,
Thanks again,
-Stafford
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-06 18:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-06 15:40 [4.12.0-rc0]: compile error in initramfs.c Jörg Otte
2017-05-06 17:27 ` Linus Torvalds
[not found] ` <aadd0898-c03c-247a-a19a-648c8faad24c@infradead.org>
2017-05-06 17:39 ` Linus Torvalds
2017-05-06 18:53 ` Stafford Horne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).