* [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4
@ 2017-05-08 9:39 Tobias Regnery
2017-05-08 18:28 ` Sebastian Reichel
2017-05-18 12:00 ` Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Tobias Regnery @ 2017-05-08 9:39 UTC (permalink / raw)
To: marcel, gustavo, johan.hedberg, linux-bluetooth, linux-kernel
Cc: sre, Tobias Regnery
We see the following build failure with CONFIG_BT_HCIUART_NOKIA=y and
CONFIG_BT_HCIUART_H4=n:
drivers/bluetooth/hci_nokia.c: In function 'nokia_recv':
drivers/bluetooth/hci_nokia.c:644:18: error: implicit declaration of function 'h4_recv_buf' [-Werror=implicit-function-declaration]
...
Fix this by selecting the BT_HCIUART_H4 symbol like all the other users
of the protocoll.
Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
drivers/bluetooth/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index e5fd24d90b0a..35952a94875e 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -97,6 +97,7 @@ config BT_HCIUART_NOKIA
depends on BT_HCIUART
depends on BT_HCIUART_SERDEV
depends on PM
+ select BT_HCIUART_H4
help
Nokia H4+ is serial protocol for communication between Bluetooth
device and host. This protocol is required for Bluetooth devices
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4
2017-05-08 9:39 [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4 Tobias Regnery
@ 2017-05-08 18:28 ` Sebastian Reichel
2017-05-18 12:00 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2017-05-08 18:28 UTC (permalink / raw)
To: Tobias Regnery; +Cc: marcel, johan.hedberg, linux-bluetooth, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
Hi,
On Mon, May 08, 2017 at 11:39:11AM +0200, Tobias Regnery wrote:
> We see the following build failure with CONFIG_BT_HCIUART_NOKIA=y and
> CONFIG_BT_HCIUART_H4=n:
>
> drivers/bluetooth/hci_nokia.c: In function 'nokia_recv':
> drivers/bluetooth/hci_nokia.c:644:18: error: implicit declaration of function 'h4_recv_buf' [-Werror=implicit-function-declaration]
> ...
>
> Fix this by selecting the BT_HCIUART_H4 symbol like all the other users
> of the protocoll.
>
> Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
Reviewed-by: Sebastian Reichel <sre@kernel.org>
-- Sebastian
> ---
> drivers/bluetooth/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index e5fd24d90b0a..35952a94875e 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -97,6 +97,7 @@ config BT_HCIUART_NOKIA
> depends on BT_HCIUART
> depends on BT_HCIUART_SERDEV
> depends on PM
> + select BT_HCIUART_H4
> help
> Nokia H4+ is serial protocol for communication between Bluetooth
> device and host. This protocol is required for Bluetooth devices
> --
> 2.11.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4
2017-05-08 9:39 [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4 Tobias Regnery
2017-05-08 18:28 ` Sebastian Reichel
@ 2017-05-18 12:00 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2017-05-18 12:00 UTC (permalink / raw)
To: Tobias Regnery
Cc: Gustavo F. Padovan, Johan Hedberg, open list:BLUETOOTH DRIVERS,
linux-kernel, sre
Hi Tobias,
> We see the following build failure with CONFIG_BT_HCIUART_NOKIA=y and
> CONFIG_BT_HCIUART_H4=n:
>
> drivers/bluetooth/hci_nokia.c: In function 'nokia_recv':
> drivers/bluetooth/hci_nokia.c:644:18: error: implicit declaration of function 'h4_recv_buf' [-Werror=implicit-function-declaration]
> ...
>
> Fix this by selecting the BT_HCIUART_H4 symbol like all the other users
> of the protocoll.
>
> Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
> ---
> drivers/bluetooth/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-18 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-08 9:39 [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4 Tobias Regnery
2017-05-08 18:28 ` Sebastian Reichel
2017-05-18 12:00 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).