From: Dan Carpenter <dan.carpenter@oracle.com>
To: Harinath Nampally <harinath922@gmail.com>
Cc: lars@metafoo.de, devel@driverdev.osuosl.org,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
pmeerw@pmeerw.net, knaack.h@gmx.de, jic23@kernel.org
Subject: Re: [PATCH 1/3] staging: iio: meter: Add the comment for mutex definition
Date: Tue, 9 May 2017 10:46:18 +0300 [thread overview]
Message-ID: <20170509074617.x6bdqs7innxhrude@mwanda> (raw)
In-Reply-To: <3aa61726d979dbaf85a116341d169a933218904b.1494293664.git.harinath922@gmail.com>
On Mon, May 08, 2017 at 10:00:37PM -0400, Harinath Nampally wrote:
> This patch fixes below checkpatch.pl warning:
> CHECK: struct mutex definition without comment
>
> Signed-off-by: Harinath Nampally <harinath922@gmail.com>
> ---
> drivers/staging/iio/meter/ade7753.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c
> index b71fbd3..cffe6bf 100644
> --- a/drivers/staging/iio/meter/ade7753.c
> +++ b/drivers/staging/iio/meter/ade7753.c
> @@ -78,12 +78,13 @@
> /**
> * struct ade7753_state - device instance specific data
> * @us: actual spi_device
> + * @buf_lock: mutex to protect tx and rx
> * @tx: transmit buffer
> * @rx: receive buffer
> - * @buf_lock: mutex to protect tx and rx
> **/
> struct ade7753_state {
> struct spi_device *us;
> + /* mutex to protect tx and rx */
Not aligned. We don't need two duplicate comments anyway.
> struct mutex buf_lock;
regards,
dan carpenter
next prev parent reply other threads:[~2017-05-09 7:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1494215850-26005-1-git-send-email-harinath922@gmail.com>
2017-05-09 1:49 ` [PATCH 0/3] coding style warnings fixes Harinath Nampally
2017-05-09 1:49 ` [PATCH 1/3] staging: iio: meter: Add the comment for mutex definition Harinath Nampally
2017-05-09 7:46 ` Dan Carpenter [this message]
2017-05-09 23:41 ` [PATCH v2 0/3] coding style warnings fixes Harinath Nampally
2017-05-09 23:41 ` [PATCH v2 1/3] staging: iio: meter: Add the comment for mutex definition Harinath Nampally
2017-05-14 15:24 ` Jonathan Cameron
2017-05-09 23:41 ` [PATCH v2 2/3] staging: iio: meter: Fix the identations for proper alignments Harinath Nampally
2017-05-14 15:26 ` Jonathan Cameron
2017-05-09 23:41 ` [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions Harinath Nampally
2017-05-14 15:29 ` Jonathan Cameron
2017-05-15 3:10 ` harinath Nampally
2017-05-14 15:23 ` [PATCH v2 0/3] coding style warnings fixes Jonathan Cameron
2017-05-09 1:49 ` [PATCH 2/3] staging: iio: meter: Fix the identations for proper alignments Harinath Nampally
2017-05-09 1:49 ` [PATCH 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions Harinath Nampally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509074617.x6bdqs7innxhrude@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harinath922@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).